mirrors/poky
1
0
Fork 0
mirror of https://git.yoctoproject.org/poky synced 2026-09-25 07:36:23 +02:00
Code Issues Packages Projects Releases Wiki Activity

bitbake: prserv: store_value() improvements

Browse Source 
Add a test_checksum_value() to test whether
a (version, pkgarch, checksum, value) entry already
exists in the database.

This is used to protect the store_value() function from
an error when trying to store a duplicate entry in the database.

Also check whether the current database is open in read-only mode.

(Bitbake rev: b7f6c085a7cf8ac83695242a0299e2d5f7abc69a)

Signed-off-by: Michael Opdenacker <michael.opdenacker@bootlin.com>
Cc: Joshua Watt <JPEWhacker@gmail.com>
Cc: Tim Orling <ticotimo@gmail.com>
Cc: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
This commit is contained in:
Michael Opdenacker
2024-05-11 16:31:33 +05:30
committed by Richard Purdie
parent 0d6dd343de
commit 3be2201de5
1 changed files with 16 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
bitbake/lib/prserv/db.py
View File

@@ -78,6 +78,18 @@ class PRTable(object):
else: else:
return False return False
def test_checksum_value(self, version, pkgarch, checksum, value):
"""Returns whether the specified value is found in the database for the specified package, architecture and checksum"""
with closing(self.conn.cursor()) as cursor:
data=cursor.execute("SELECT value FROM %s WHERE version=? AND pkgarch=? and checksum=? and value=?;" % self.table,
(version, pkgarch, checksum, value))
row=data.fetchone()
if row is not None:
return True
else:
return False
def test_value(self, version, pkgarch, value): def test_value(self, version, pkgarch, value):
"""Returns whether the specified value is found in the database for the specified package and architecture""" """Returns whether the specified value is found in the database for the specified package and architecture"""
@@ -143,14 +155,12 @@ class PRTable(object):
return base + ".0" return base + ".0"
def store_value(self, version, pkgarch, checksum, value): def store_value(self, version, pkgarch, checksum, value):
"""Store new value in the database""" """Store value in the database"""
if not self.read_only and not self.test_checksum_value(version, pkgarch, checksum, value):
with closing(self.conn.cursor()) as cursor: with closing(self.conn.cursor()) as cursor:
try:
cursor.execute("INSERT INTO %s VALUES (?, ?, ?, ?);" % (self.table), cursor.execute("INSERT INTO %s VALUES (?, ?, ?, ?);" % (self.table),
(version, pkgarch, checksum, value)) (version, pkgarch, checksum, value))
except sqlite3.IntegrityError as exc:
logger.error(str(exc))
self.conn.commit() self.conn.commit()
def _get_value(self, version, pkgarch, checksum, history): def _get_value(self, version, pkgarch, checksum, history):