mirrors/poky
1
0
Fork 0
mirror of https://git.yoctoproject.org/poky synced 2026-09-14 21:49:33 +02:00
Code Issues Packages Projects Releases Wiki Activity

bitbake: cookerdata: Drop dubious exception handling code

Browse Source 
This code appears to be dangerous, it swallows exceptions, turning them into
"handled" versions which then show no errors to the user. This is a pretty
poor user experience and I can't see why this code should be swallowing
such things. Drop the worst bits of code.

(Bitbake rev: a29ffcc12df24737e702e198aeb8f6892884932b)

Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Signed-off-by: Steve Sakoman <steve@sakoman.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
This commit is contained in:
Richard Purdie
2023-03-10 21:46:01 +01:00
parent f8c7c22df8
commit 432bef2a90
1 changed files with 0 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
bitbake/lib/bb/cookerdata.py
View File

@@ -293,14 +293,9 @@ class CookerDataBuilder(object):
bb.event.fire(bb.event.MultiConfigParsed(self.mcdata), self.data) bb.event.fire(bb.event.MultiConfigParsed(self.mcdata), self.data)
self.data_hash = data_hash.hexdigest() self.data_hash = data_hash.hexdigest()
except (SyntaxError, bb.BBHandledException):
raise bb.BBHandledException()
except bb.data_smart.ExpansionError as e: except bb.data_smart.ExpansionError as e:
logger.error(str(e)) logger.error(str(e))
raise bb.BBHandledException() raise bb.BBHandledException()
except Exception:
logger.exception("Error parsing configuration files")
raise bb.BBHandledException()
# Handle obsolete variable names # Handle obsolete variable names