From 9e4cc2010997adf9bdc250a200e21dca74ac5421 Mon Sep 17 00:00:00 2001 From: Richard Purdie Date: Fri, 10 Mar 2023 21:45:19 +0100 Subject: [PATCH] bitbake: cookerdata: Drop dubious exception handling code This code appears to be dangerous, it swallows exceptions, turning them into "handled" versions which then show no errors to the user. This is a pretty poor user experience and I can't see why this code should be swallowing such things. Drop the worst bits of code. (Bitbake rev: 2b239555f76e4e98ca704e7ef60e796d0f19463c) Signed-off-by: Richard Purdie Signed-off-by: Steve Sakoman Signed-off-by: Richard Purdie --- bitbake/lib/bb/cookerdata.py | 5 ----- 1 file changed, 5 deletions(-) diff --git a/bitbake/lib/bb/cookerdata.py b/bitbake/lib/bb/cookerdata.py index 25eea827da..b4bfba335a 100644 --- a/bitbake/lib/bb/cookerdata.py +++ b/bitbake/lib/bb/cookerdata.py @@ -294,14 +294,9 @@ class CookerDataBuilder(object): bb.event.fire(bb.event.MultiConfigParsed(self.mcdata), self.data) self.data_hash = data_hash.hexdigest() - except (SyntaxError, bb.BBHandledException): - raise bb.BBHandledException() except bb.data_smart.ExpansionError as e: logger.error(str(e)) raise bb.BBHandledException() - except Exception: - logger.exception("Error parsing configuration files") - raise bb.BBHandledException() # Handle obsolete variable names