mirrors/poky
1
0
Fork 0
mirror of https://git.yoctoproject.org/poky synced 2026-09-13 09:49:32 +02:00
Code Issues Packages Projects Releases Wiki Activity

bitbake: providers/runqueue/taskdata: Optimise logger.debug calls

Browse Source 
A run of "bitbake bash -c unpack" when the task has already been
completed resulted in about 9000 calls to logger.debug(). With this
patch which comments out some noisy/less usefull logging and moves
other logging calls outside loops, this number is reduced to 1000
calls. This results in cleaner logs and gives a small but
measurable 0.15s speedup. The log size dropped from 900kb to 160kb.

(Bitbake rev: d2677f084fe1d8846db77d89ef5e6ffb18dc171a)

Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
This commit is contained in:
Richard Purdie
2014-03-09 17:55:45 -07:00
parent 0b4ae1c774
commit aadfea6be6
3 changed files with 11 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
bitbake/lib/bb/providers.py
View File

@@ -325,7 +325,7 @@ def filterProvidersRunTime(providers, item, cfgData, dataCache):
provides = dataCache.pn_provides[pn] provides = dataCache.pn_provides[pn]
for provide in provides: for provide in provides:
prefervar = cfgData.getVar('PREFERRED_PROVIDER_%s' % provide, True) prefervar = cfgData.getVar('PREFERRED_PROVIDER_%s' % provide, True)
logger.debug(1, "checking PREFERRED_PROVIDER_%s (value %s) against %s", provide, prefervar, pns.keys()) #logger.debug(1, "checking PREFERRED_PROVIDER_%s (value %s) against %s", provide, prefervar, pns.keys())
if prefervar in pns and pns[prefervar] not in preferred: if prefervar in pns and pns[prefervar] not in preferred:
var = "PREFERRED_PROVIDER_%s = %s" % (provide, prefervar) var = "PREFERRED_PROVIDER_%s = %s" % (provide, prefervar)
logger.verbose("selecting %s to satisfy runtime %s due to %s", prefervar, item, var) logger.verbose("selecting %s to satisfy runtime %s due to %s", prefervar, item, var)

2
bitbake/lib/bb/runqueue.py
View File

@@ -481,7 +481,7 @@ class RunQueueData:
fn = taskData.fn_index[fnid] fn = taskData.fn_index[fnid]
task_deps = self.dataCache.task_deps[fn] task_deps = self.dataCache.task_deps[fn]
logger.debug(2, "Processing %s:%s", fn, taskData.tasks_name[task]) #logger.debug(2, "Processing %s:%s", fn, taskData.tasks_name[task])
if fnid not in taskData.failed_fnids: if fnid not in taskData.failed_fnids:

12
bitbake/lib/bb/taskdata.py
View File

@@ -207,23 +207,29 @@ class TaskData:
if not fnid in self.depids: if not fnid in self.depids:
dependids = {} dependids = {}
for depend in dataCache.deps[fn]: for depend in dataCache.deps[fn]:
logger.debug(2, "Added dependency %s for %s", depend, fn)
dependids[self.getbuild_id(depend)] = None dependids[self.getbuild_id(depend)] = None
self.depids[fnid] = dependids.keys() self.depids[fnid] = dependids.keys()
logger.debug(2, "Added dependencies %s for %s", str(dataCache.deps[fn]), fn)
# Work out runtime dependencies # Work out runtime dependencies
if not fnid in self.rdepids: if not fnid in self.rdepids:
rdependids = {} rdependids = {}
rdepends = dataCache.rundeps[fn] rdepends = dataCache.rundeps[fn]
rrecs = dataCache.runrecs[fn] rrecs = dataCache.runrecs[fn]
rdependlist = []
rreclist = []
for package in rdepends: for package in rdepends:
for rdepend in rdepends[package]: for rdepend in rdepends[package]:
logger.debug(2, "Added runtime dependency %s for %s", rdepend, fn) rdependlist.append(rdepend)
rdependids[self.getrun_id(rdepend)] = None rdependids[self.getrun_id(rdepend)] = None
for package in rrecs: for package in rrecs:
for rdepend in rrecs[package]: for rdepend in rrecs[package]:
logger.debug(2, "Added runtime recommendation %s for %s", rdepend, fn) rreclist.append(rdepend)
rdependids[self.getrun_id(rdepend)] = None rdependids[self.getrun_id(rdepend)] = None
if rdependlist:
logger.debug(2, "Added runtime dependencies %s for %s", str(rdependlist), fn)
if rreclist:
logger.debug(2, "Added runtime recommendations %s for %s", str(rreclist), fn)
self.rdepids[fnid] = rdependids.keys() self.rdepids[fnid] = rdependids.keys()
for dep in self.depids[fnid]: for dep in self.depids[fnid]: