mirror of
https://git.yoctoproject.org/poky
synced 2026-05-02 18:32:15 +02:00
meta: remove True option to getVar calls
getVar() now defaults to expanding by default, thus remove the True option from getVar() calls with a regex search and replace. Search made with the following regex: getVar ?\(( ?[^,()]*), True\) (From OE-Core rev: 7c552996597faaee2fbee185b250c0ee30ea3b5f) Signed-off-by: Joshua Lock <joshua.g.lock@intel.com> Signed-off-by: Ross Burton <ross.burton@intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
This commit is contained in:
committed by
Richard Purdie
parent
d5e67725ac
commit
c4e2c59088
@@ -2,7 +2,7 @@ inherit rootfs_${IMAGE_PKGTYPE}
|
||||
|
||||
# Only Linux SDKs support populate_sdk_ext, fall back to populate_sdk
|
||||
# in the non-Linux SDK_OS case, such as mingw32
|
||||
SDKEXTCLASS ?= "${@['populate_sdk', 'populate_sdk_ext']['linux' in d.getVar("SDK_OS", True)]}"
|
||||
SDKEXTCLASS ?= "${@['populate_sdk', 'populate_sdk_ext']['linux' in d.getVar("SDK_OS")]}"
|
||||
inherit ${SDKEXTCLASS}
|
||||
|
||||
TOOLCHAIN_TARGET_TASK += "${PACKAGE_INSTALL}"
|
||||
@@ -133,7 +133,7 @@ def build_live(d):
|
||||
if bb.utils.contains("IMAGE_FSTYPES", "live", "live", "0", d) == "0": # live is not set but hob might set iso or hddimg
|
||||
d.setVar('NOISO', bb.utils.contains('IMAGE_FSTYPES', "iso", "0", "1", d))
|
||||
d.setVar('NOHDD', bb.utils.contains('IMAGE_FSTYPES', "hddimg", "0", "1", d))
|
||||
if d.getVar('NOISO', True) == "0" or d.getVar('NOHDD', True) == "0":
|
||||
if d.getVar('NOISO') == "0" or d.getVar('NOHDD') == "0":
|
||||
return "image-live"
|
||||
return ""
|
||||
return "image-live"
|
||||
@@ -145,7 +145,7 @@ IMAGE_TYPE_vm = '${@bb.utils.contains_any("IMAGE_FSTYPES", ["vmdk", "vdi", "qcow
|
||||
inherit ${IMAGE_TYPE_vm}
|
||||
|
||||
def build_uboot(d):
|
||||
if 'u-boot' in (d.getVar('IMAGE_FSTYPES', True) or ''):
|
||||
if 'u-boot' in (d.getVar('IMAGE_FSTYPES') or ''):
|
||||
return "image_types_uboot"
|
||||
else:
|
||||
return ""
|
||||
@@ -158,7 +158,7 @@ python () {
|
||||
d.appendVarFlag('do_rootfs', 'depends', deps)
|
||||
|
||||
deps = ""
|
||||
for dep in (d.getVar('EXTRA_IMAGEDEPENDS', True) or "").split():
|
||||
for dep in (d.getVar('EXTRA_IMAGEDEPENDS') or "").split():
|
||||
deps += " %s:do_populate_sysroot" % dep
|
||||
d.appendVarFlag('do_build', 'depends', deps)
|
||||
|
||||
@@ -167,22 +167,22 @@ python () {
|
||||
features = set(oe.data.typed_value('IMAGE_FEATURES', d))
|
||||
remain_features = features.copy()
|
||||
for feature in features:
|
||||
replaces = set((d.getVar("IMAGE_FEATURES_REPLACES_%s" % feature, True) or "").split())
|
||||
replaces = set((d.getVar("IMAGE_FEATURES_REPLACES_%s" % feature) or "").split())
|
||||
remain_features -= replaces
|
||||
|
||||
#Check for conflict image features
|
||||
for feature in remain_features:
|
||||
conflicts = set((d.getVar("IMAGE_FEATURES_CONFLICTS_%s" % feature, True) or "").split())
|
||||
conflicts = set((d.getVar("IMAGE_FEATURES_CONFLICTS_%s" % feature) or "").split())
|
||||
temp = conflicts & remain_features
|
||||
if temp:
|
||||
bb.fatal("%s contains conflicting IMAGE_FEATURES %s %s" % (d.getVar('PN', True), feature, ' '.join(list(temp))))
|
||||
bb.fatal("%s contains conflicting IMAGE_FEATURES %s %s" % (d.getVar('PN'), feature, ' '.join(list(temp))))
|
||||
|
||||
d.setVar('IMAGE_FEATURES', ' '.join(sorted(list(remain_features))))
|
||||
|
||||
check_image_features(d)
|
||||
initramfs_image = d.getVar('INITRAMFS_IMAGE', True) or ""
|
||||
initramfs_image = d.getVar('INITRAMFS_IMAGE') or ""
|
||||
if initramfs_image != "":
|
||||
d.appendVarFlag('do_build', 'depends', " %s:do_bundle_initramfs" % d.getVar('PN', True))
|
||||
d.appendVarFlag('do_build', 'depends', " %s:do_bundle_initramfs" % d.getVar('PN'))
|
||||
d.appendVarFlag('do_bundle_initramfs', 'depends', " %s:do_image_complete" % initramfs_image)
|
||||
}
|
||||
|
||||
@@ -194,7 +194,7 @@ IMAGE_POSTPROCESS_COMMAND ?= ""
|
||||
# some default locales
|
||||
IMAGE_LINGUAS ?= "de-de fr-fr en-gb"
|
||||
|
||||
LINGUAS_INSTALL ?= "${@" ".join(map(lambda s: "locale-base-%s" % s, d.getVar('IMAGE_LINGUAS', True).split()))}"
|
||||
LINGUAS_INSTALL ?= "${@" ".join(map(lambda s: "locale-base-%s" % s, d.getVar('IMAGE_LINGUAS').split()))}"
|
||||
|
||||
# Prefer image, but use the fallback files for lookups if the image ones
|
||||
# aren't yet available.
|
||||
@@ -229,20 +229,20 @@ fakeroot python do_rootfs () {
|
||||
progress_reporter.next_stage()
|
||||
|
||||
# Handle package exclusions
|
||||
excl_pkgs = d.getVar("PACKAGE_EXCLUDE", True).split()
|
||||
inst_pkgs = d.getVar("PACKAGE_INSTALL", True).split()
|
||||
inst_attempt_pkgs = d.getVar("PACKAGE_INSTALL_ATTEMPTONLY", True).split()
|
||||
excl_pkgs = d.getVar("PACKAGE_EXCLUDE").split()
|
||||
inst_pkgs = d.getVar("PACKAGE_INSTALL").split()
|
||||
inst_attempt_pkgs = d.getVar("PACKAGE_INSTALL_ATTEMPTONLY").split()
|
||||
|
||||
d.setVar('PACKAGE_INSTALL_ORIG', ' '.join(inst_pkgs))
|
||||
d.setVar('PACKAGE_INSTALL_ATTEMPTONLY', ' '.join(inst_attempt_pkgs))
|
||||
|
||||
for pkg in excl_pkgs:
|
||||
if pkg in inst_pkgs:
|
||||
bb.warn("Package %s, set to be excluded, is in %s PACKAGE_INSTALL (%s). It will be removed from the list." % (pkg, d.getVar('PN', True), inst_pkgs))
|
||||
bb.warn("Package %s, set to be excluded, is in %s PACKAGE_INSTALL (%s). It will be removed from the list." % (pkg, d.getVar('PN'), inst_pkgs))
|
||||
inst_pkgs.remove(pkg)
|
||||
|
||||
if pkg in inst_attempt_pkgs:
|
||||
bb.warn("Package %s, set to be excluded, is in %s PACKAGE_INSTALL_ATTEMPTONLY (%s). It will be removed from the list." % (pkg, d.getVar('PN', True), inst_pkgs))
|
||||
bb.warn("Package %s, set to be excluded, is in %s PACKAGE_INSTALL_ATTEMPTONLY (%s). It will be removed from the list." % (pkg, d.getVar('PN'), inst_pkgs))
|
||||
inst_attempt_pkgs.remove(pkg)
|
||||
|
||||
d.setVar("PACKAGE_INSTALL", ' '.join(inst_pkgs))
|
||||
@@ -252,7 +252,7 @@ fakeroot python do_rootfs () {
|
||||
# We have to delay the runtime_mapping_rename until just before rootfs runs
|
||||
# otherwise, the multilib renaming could step in and squash any fixups that
|
||||
# may have occurred.
|
||||
pn = d.getVar('PN', True)
|
||||
pn = d.getVar('PN')
|
||||
runtime_mapping_rename("PACKAGE_INSTALL", pn, d)
|
||||
runtime_mapping_rename("PACKAGE_INSTALL_ATTEMPTONLY", pn, d)
|
||||
runtime_mapping_rename("BAD_RECOMMENDATIONS", pn, d)
|
||||
@@ -275,7 +275,7 @@ addtask rootfs before do_build
|
||||
fakeroot python do_image () {
|
||||
from oe.utils import execute_pre_post_process
|
||||
|
||||
pre_process_cmds = d.getVar("IMAGE_PREPROCESS_COMMAND", True)
|
||||
pre_process_cmds = d.getVar("IMAGE_PREPROCESS_COMMAND")
|
||||
|
||||
execute_pre_post_process(d, pre_process_cmds)
|
||||
}
|
||||
@@ -286,7 +286,7 @@ addtask do_image after do_rootfs before do_build
|
||||
fakeroot python do_image_complete () {
|
||||
from oe.utils import execute_pre_post_process
|
||||
|
||||
post_process_cmds = d.getVar("IMAGE_POSTPROCESS_COMMAND", True)
|
||||
post_process_cmds = d.getVar("IMAGE_POSTPROCESS_COMMAND")
|
||||
|
||||
execute_pre_post_process(d, post_process_cmds)
|
||||
}
|
||||
@@ -309,7 +309,7 @@ addtask do_image_complete after do_image before do_build
|
||||
fakeroot python do_image_qa () {
|
||||
from oe.utils import ImageQAFailed
|
||||
|
||||
qa_cmds = (d.getVar('IMAGE_QA_COMMANDS', True) or '').split()
|
||||
qa_cmds = (d.getVar('IMAGE_QA_COMMANDS') or '').split()
|
||||
qamsg = ""
|
||||
|
||||
for cmd in qa_cmds:
|
||||
@@ -324,7 +324,7 @@ fakeroot python do_image_qa () {
|
||||
qamsg = qamsg + '\n'
|
||||
|
||||
if qamsg:
|
||||
imgname = d.getVar('IMAGE_NAME', True)
|
||||
imgname = d.getVar('IMAGE_NAME')
|
||||
bb.fatal("QA errors found whilst validating image: %s\n%s" % (imgname, qamsg))
|
||||
}
|
||||
addtask do_image_qa after do_image_complete before do_build
|
||||
@@ -334,17 +334,17 @@ addtask do_image_qa after do_image_complete before do_build
|
||||
# to tmp/sysroots/<machine>/imgdata/<image>.env
|
||||
#
|
||||
python do_rootfs_wicenv () {
|
||||
wicvars = d.getVar('WICVARS', True)
|
||||
wicvars = d.getVar('WICVARS')
|
||||
if not wicvars:
|
||||
return
|
||||
|
||||
stdir = d.getVar('STAGING_DIR_TARGET', True)
|
||||
stdir = d.getVar('STAGING_DIR_TARGET')
|
||||
outdir = os.path.join(stdir, 'imgdata')
|
||||
bb.utils.mkdirhier(outdir)
|
||||
basename = d.getVar('IMAGE_BASENAME', True)
|
||||
basename = d.getVar('IMAGE_BASENAME')
|
||||
with open(os.path.join(outdir, basename) + '.env', 'w') as envf:
|
||||
for var in wicvars.split():
|
||||
value = d.getVar(var, True)
|
||||
value = d.getVar(var)
|
||||
if value:
|
||||
envf.write('%s="%s"\n' % (var, value.strip()))
|
||||
}
|
||||
@@ -357,7 +357,7 @@ def setup_debugfs_variables(d):
|
||||
d.appendVar('IMAGE_LINK_NAME', '-dbg')
|
||||
d.appendVar('IMAGE_NAME','-dbg')
|
||||
d.setVar('IMAGE_BUILDING_DEBUGFS', 'true')
|
||||
debugfs_image_fstypes = d.getVar('IMAGE_FSTYPES_DEBUGFS', True)
|
||||
debugfs_image_fstypes = d.getVar('IMAGE_FSTYPES_DEBUGFS')
|
||||
if debugfs_image_fstypes:
|
||||
d.setVar('IMAGE_FSTYPES', debugfs_image_fstypes)
|
||||
|
||||
@@ -375,7 +375,7 @@ python () {
|
||||
#
|
||||
# Without de-duplication, gen_conversion_cmds() below
|
||||
# would create the same compression command multiple times.
|
||||
ctypes = set(d.getVar('CONVERSIONTYPES', True).split())
|
||||
ctypes = set(d.getVar('CONVERSIONTYPES').split())
|
||||
old_overrides = d.getVar('OVERRIDES', False)
|
||||
|
||||
def _image_base_type(type):
|
||||
@@ -392,11 +392,11 @@ python () {
|
||||
return basetype
|
||||
|
||||
basetypes = {}
|
||||
alltypes = d.getVar('IMAGE_FSTYPES', True).split()
|
||||
alltypes = d.getVar('IMAGE_FSTYPES').split()
|
||||
typedeps = {}
|
||||
|
||||
if d.getVar('IMAGE_GEN_DEBUGFS', True) == "1":
|
||||
debugfs_fstypes = d.getVar('IMAGE_FSTYPES_DEBUGFS', True).split()
|
||||
if d.getVar('IMAGE_GEN_DEBUGFS') == "1":
|
||||
debugfs_fstypes = d.getVar('IMAGE_FSTYPES_DEBUGFS').split()
|
||||
for t in debugfs_fstypes:
|
||||
alltypes.append("debugfs_" + t)
|
||||
|
||||
@@ -411,7 +411,7 @@ python () {
|
||||
if t.startswith("debugfs_"):
|
||||
t = t[8:]
|
||||
debug = "debugfs_"
|
||||
deps = (d.getVar('IMAGE_TYPEDEP_' + t, True) or "").split()
|
||||
deps = (d.getVar('IMAGE_TYPEDEP_' + t) or "").split()
|
||||
vardeps.add('IMAGE_TYPEDEP_' + t)
|
||||
if baset not in typedeps:
|
||||
typedeps[baset] = set()
|
||||
@@ -431,7 +431,7 @@ python () {
|
||||
|
||||
d.appendVarFlag('do_image', 'vardeps', ' '.join(vardeps))
|
||||
|
||||
maskedtypes = (d.getVar('IMAGE_TYPES_MASKED', True) or "").split()
|
||||
maskedtypes = (d.getVar('IMAGE_TYPES_MASKED') or "").split()
|
||||
maskedtypes = [dbg + t for t in maskedtypes for dbg in ("", "debugfs_")]
|
||||
|
||||
for t in basetypes:
|
||||
@@ -459,7 +459,7 @@ python () {
|
||||
localdata.delVar('DATETIME')
|
||||
localdata.delVar('TMPDIR')
|
||||
|
||||
image_cmd = localdata.getVar("IMAGE_CMD", True)
|
||||
image_cmd = localdata.getVar("IMAGE_CMD")
|
||||
vardeps.add('IMAGE_CMD_' + realt)
|
||||
if image_cmd:
|
||||
cmds.append("\t" + image_cmd)
|
||||
@@ -481,7 +481,7 @@ python () {
|
||||
# Create input image first.
|
||||
gen_conversion_cmds(type)
|
||||
localdata.setVar('type', type)
|
||||
cmd = "\t" + (localdata.getVar("CONVERSION_CMD_" + ctype, True) or localdata.getVar("COMPRESS_CMD_" + ctype, True))
|
||||
cmd = "\t" + (localdata.getVar("CONVERSION_CMD_" + ctype) or localdata.getVar("COMPRESS_CMD_" + ctype))
|
||||
if cmd not in cmds:
|
||||
cmds.append(cmd)
|
||||
vardeps.add('CONVERSION_CMD_' + ctype)
|
||||
@@ -532,17 +532,17 @@ python () {
|
||||
def get_rootfs_size(d):
|
||||
import subprocess
|
||||
|
||||
rootfs_alignment = int(d.getVar('IMAGE_ROOTFS_ALIGNMENT', True))
|
||||
overhead_factor = float(d.getVar('IMAGE_OVERHEAD_FACTOR', True))
|
||||
rootfs_req_size = int(d.getVar('IMAGE_ROOTFS_SIZE', True))
|
||||
rootfs_extra_space = eval(d.getVar('IMAGE_ROOTFS_EXTRA_SPACE', True))
|
||||
rootfs_maxsize = d.getVar('IMAGE_ROOTFS_MAXSIZE', True)
|
||||
image_fstypes = d.getVar('IMAGE_FSTYPES', True) or ''
|
||||
initramfs_fstypes = d.getVar('INITRAMFS_FSTYPES', True) or ''
|
||||
initramfs_maxsize = d.getVar('INITRAMFS_MAXSIZE', True)
|
||||
rootfs_alignment = int(d.getVar('IMAGE_ROOTFS_ALIGNMENT'))
|
||||
overhead_factor = float(d.getVar('IMAGE_OVERHEAD_FACTOR'))
|
||||
rootfs_req_size = int(d.getVar('IMAGE_ROOTFS_SIZE'))
|
||||
rootfs_extra_space = eval(d.getVar('IMAGE_ROOTFS_EXTRA_SPACE'))
|
||||
rootfs_maxsize = d.getVar('IMAGE_ROOTFS_MAXSIZE')
|
||||
image_fstypes = d.getVar('IMAGE_FSTYPES') or ''
|
||||
initramfs_fstypes = d.getVar('INITRAMFS_FSTYPES') or ''
|
||||
initramfs_maxsize = d.getVar('INITRAMFS_MAXSIZE')
|
||||
|
||||
output = subprocess.check_output(['du', '-ks',
|
||||
d.getVar('IMAGE_ROOTFS', True)])
|
||||
d.getVar('IMAGE_ROOTFS')])
|
||||
size_kb = int(output.split()[0])
|
||||
base_size = size_kb * overhead_factor
|
||||
base_size = max(base_size, rootfs_req_size) + rootfs_extra_space
|
||||
@@ -558,7 +558,7 @@ def get_rootfs_size(d):
|
||||
# Do not check image size of the debugfs image. This is not supposed
|
||||
# to be deployed, etc. so it doesn't make sense to limit the size
|
||||
# of the debug.
|
||||
if (d.getVar('IMAGE_BUILDING_DEBUGFS', True) or "") == "true":
|
||||
if (d.getVar('IMAGE_BUILDING_DEBUGFS') or "") == "true":
|
||||
return base_size
|
||||
|
||||
# Check the rootfs size against IMAGE_ROOTFS_MAXSIZE (if set)
|
||||
@@ -589,11 +589,11 @@ python set_image_size () {
|
||||
#
|
||||
python create_symlinks() {
|
||||
|
||||
deploy_dir = d.getVar('IMGDEPLOYDIR', True)
|
||||
img_name = d.getVar('IMAGE_NAME', True)
|
||||
link_name = d.getVar('IMAGE_LINK_NAME', True)
|
||||
manifest_name = d.getVar('IMAGE_MANIFEST', True)
|
||||
taskname = d.getVar("BB_CURRENTTASK", True)
|
||||
deploy_dir = d.getVar('IMGDEPLOYDIR')
|
||||
img_name = d.getVar('IMAGE_NAME')
|
||||
link_name = d.getVar('IMAGE_LINK_NAME')
|
||||
manifest_name = d.getVar('IMAGE_MANIFEST')
|
||||
taskname = d.getVar("BB_CURRENTTASK")
|
||||
subimages = (d.getVarFlag("do_" + taskname, 'subimages', False) or "").split()
|
||||
imgsuffix = d.getVarFlag("do_" + taskname, 'imgsuffix', True) or d.expand("${IMAGE_NAME_SUFFIX}.")
|
||||
|
||||
|
||||
Reference in New Issue
Block a user