mirrors/poky
1
0
Fork 0
mirror of https://git.yoctoproject.org/poky synced 2026-09-15 15:49:32 +02:00
Code Issues Packages Projects Releases Wiki Activity

bitbake: toaster: measure task duration with server-side timestamps

Browse Source 
The buildstats and toaster use separate time markers to measure the
duration of task execution. This causes a mismatch in the time
measured by buildstats class and the time measured in toaster.

The solution implemented here is to timestamp the creation of
every TaskBase event on the bitbake server side and calculate
the execution duration as the difference between creation time
of TaskSucceeded and TaskStarted events.

Based on an original patch by Marius Avram.

[YOCTO #5485]

(Bitbake rev: 7a08282c074c264f414cf7665dc873f51245072c)

Signed-off-by: Marius Avram <marius.avram@intel.com>
Signed-off-by: Alexandru DAMIAN <alexandru.damian@intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
This commit is contained in:
Alexandru DAMIAN
2014-03-17 15:28:46 +00:00
committed by Richard Purdie
parent 888683de7a
commit f191ab0198
2 changed files with 9 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
bitbake/lib/bb/build.py
View File

@@ -30,6 +30,7 @@ import sys
import logging import logging
import shlex import shlex
import glob import glob
import time
import bb import bb
import bb.msg import bb.msg
import bb.process import bb.process
@@ -75,6 +76,7 @@ class TaskBase(event.Event):
self.taskfile = d.getVar("FILE", True) self.taskfile = d.getVar("FILE", True)
self.taskname = self._task self.taskname = self._task
self.logfile = logfile self.logfile = logfile
self.time = time.time()
event.Event.__init__(self) event.Event.__init__(self)
self._message = "recipe %s: task %s: %s" % (d.getVar("PF", True), t, self.getDisplayName()) self._message = "recipe %s: task %s: %s" % (d.getVar("PF", True), t, self.getDisplayName())

11
bitbake/lib/bb/ui/buildinfohelper.py
View File

@@ -133,10 +133,10 @@ class ORMWrapper(object):
elif outcome_task_setscene == Task.OUTCOME_FAILED: elif outcome_task_setscene == Task.OUTCOME_FAILED:
task_object.sstate_result = Task.SSTATE_FAILED task_object.sstate_result = Task.SSTATE_FAILED
# mark down duration if we have a start time # mark down duration if we have a start time and a current time
if 'start_time' in task_information.keys(): if 'start_time' in task_information.keys() and 'time' in vars(event):
duration = datetime.datetime.now() - task_information['start_time'] duration = event.time - task_information['start_time']
task_object.elapsed_time = duration.total_seconds() task_object.elapsed_time = duration
task_object.save() task_object.save()
return task_object return task_object
@@ -717,6 +717,9 @@ class BuildInfoHelper(object):
recipe = self.orm_wrapper.get_update_recipe_object(recipe_information, True) recipe = self.orm_wrapper.get_update_recipe_object(recipe_information, True)
task_information = self._get_task_information(event,recipe) task_information = self._get_task_information(event,recipe)
if 'time' in vars(event) and isinstance(event, bb.build.TaskStarted):
self.internal_state['taskdata'][identifier]['start_time'] = event.time
task_information['start_time'] = self.internal_state['taskdata'][identifier]['start_time'] task_information['start_time'] = self.internal_state['taskdata'][identifier]['start_time']
task_information['outcome'] = self.internal_state['taskdata'][identifier]['outcome'] task_information['outcome'] = self.internal_state['taskdata'][identifier]['outcome']