mirror of
https://git.yoctoproject.org/poky
synced 2026-09-20 03:49:32 +02:00
grub: patch CVE-2025-0690
Cherry-pick patch mentioning this CVE. (From OE-Core rev: d9fb00f71380ad39ea5b61e60c4f458371460862) Signed-off-by: Peter Marko <peter.marko@siemens.com> Signed-off-by: Steve Sakoman <steve@sakoman.com>
This commit is contained in:
committed by
Steve Sakoman
parent
5690f247a4
commit
f3aada6039
73
meta/recipes-bsp/grub/files/CVE-2025-0690.patch
Normal file
73
meta/recipes-bsp/grub/files/CVE-2025-0690.patch
Normal file
@@ -0,0 +1,73 @@
|
|||||||
|
From dad8f502974ed9ad0a70ae6820d17b4b142558fc Mon Sep 17 00:00:00 2001
|
||||||
|
From: Jonathan Bar Or <jonathanbaror@gmail.com>
|
||||||
|
Date: Thu, 23 Jan 2025 19:17:05 +0100
|
||||||
|
Subject: [PATCH] commands/read: Fix an integer overflow when supplying more
|
||||||
|
than 2^31 characters
|
||||||
|
|
||||||
|
The grub_getline() function currently has a signed integer variable "i"
|
||||||
|
that can be overflown when user supplies more than 2^31 characters.
|
||||||
|
It results in a memory corruption of the allocated line buffer as well
|
||||||
|
as supplying large negative values to grub_realloc().
|
||||||
|
|
||||||
|
Fixes: CVE-2025-0690
|
||||||
|
|
||||||
|
Reported-by: Jonathan Bar Or <jonathanbaror@gmail.com>
|
||||||
|
Signed-off-by: Jonathan Bar Or <jonathanbaror@gmail.com>
|
||||||
|
Reviewed-by: Daniel Kiper <daniel.kiper@oracle.com>
|
||||||
|
|
||||||
|
CVE: CVE-2025-0690
|
||||||
|
Upstream-Status: Backport [https://git.savannah.gnu.org/cgit/grub.git/commit/?id=dad8f502974ed9ad0a70ae6820d17b4b142558fc]
|
||||||
|
Signed-off-by: Peter Marko <peter.marko@siemens.com>
|
||||||
|
---
|
||||||
|
grub-core/commands/read.c | 19 +++++++++++++++----
|
||||||
|
1 file changed, 15 insertions(+), 4 deletions(-)
|
||||||
|
|
||||||
|
diff --git a/grub-core/commands/read.c b/grub-core/commands/read.c
|
||||||
|
index 597c90706..8d72e45c9 100644
|
||||||
|
--- a/grub-core/commands/read.c
|
||||||
|
+++ b/grub-core/commands/read.c
|
||||||
|
@@ -25,6 +25,7 @@
|
||||||
|
#include <grub/types.h>
|
||||||
|
#include <grub/extcmd.h>
|
||||||
|
#include <grub/i18n.h>
|
||||||
|
+#include <grub/safemath.h>
|
||||||
|
|
||||||
|
GRUB_MOD_LICENSE ("GPLv3+");
|
||||||
|
|
||||||
|
@@ -37,13 +38,14 @@ static const struct grub_arg_option options[] =
|
||||||
|
static char *
|
||||||
|
grub_getline (int silent)
|
||||||
|
{
|
||||||
|
- int i;
|
||||||
|
+ grub_size_t i;
|
||||||
|
char *line;
|
||||||
|
char *tmp;
|
||||||
|
int c;
|
||||||
|
+ grub_size_t alloc_size;
|
||||||
|
|
||||||
|
i = 0;
|
||||||
|
- line = grub_malloc (1 + i + sizeof('\0'));
|
||||||
|
+ line = grub_malloc (1 + sizeof('\0'));
|
||||||
|
if (! line)
|
||||||
|
return NULL;
|
||||||
|
|
||||||
|
@@ -59,8 +61,17 @@ grub_getline (int silent)
|
||||||
|
line[i] = (char) c;
|
||||||
|
if (!silent)
|
||||||
|
grub_printf ("%c", c);
|
||||||
|
- i++;
|
||||||
|
- tmp = grub_realloc (line, 1 + i + sizeof('\0'));
|
||||||
|
+ if (grub_add (i, 1, &i))
|
||||||
|
+ {
|
||||||
|
+ grub_error (GRUB_ERR_OUT_OF_RANGE, N_("overflow is detected"));
|
||||||
|
+ return NULL;
|
||||||
|
+ }
|
||||||
|
+ if (grub_add (i, 1 + sizeof('\0'), &alloc_size))
|
||||||
|
+ {
|
||||||
|
+ grub_error (GRUB_ERR_OUT_OF_RANGE, N_("overflow is detected"));
|
||||||
|
+ return NULL;
|
||||||
|
+ }
|
||||||
|
+ tmp = grub_realloc (line, alloc_size);
|
||||||
|
if (! tmp)
|
||||||
|
{
|
||||||
|
grub_free (line);
|
||||||
@@ -32,6 +32,7 @@ SRC_URI = "${GNU_MIRROR}/grub/grub-${PV}.tar.gz \
|
|||||||
file://CVE-2025-0622-03.patch \
|
file://CVE-2025-0622-03.patch \
|
||||||
file://CVE-2024-45776.patch \
|
file://CVE-2024-45776.patch \
|
||||||
file://CVE-2024-45777.patch \
|
file://CVE-2024-45777.patch \
|
||||||
|
file://CVE-2025-0690.patch \
|
||||||
"
|
"
|
||||||
|
|
||||||
SRC_URI[sha256sum] = "b30919fa5be280417c17ac561bb1650f60cfb80cc6237fa1e2b6f56154cb9c91"
|
SRC_URI[sha256sum] = "b30919fa5be280417c17ac561bb1650f60cfb80cc6237fa1e2b6f56154cb9c91"
|
||||||
|
|||||||
Reference in New Issue
Block a user