The patch is used for fixing:
| Makefile:3418: *** Recursive variable 'INSTALL' references itself (eventually). Stop.
Now the code and check and set that correctly:
if CROSS_COMPILING
cu_install_program = @INSTALL@
else
cu_install_program = src/ginstall
endif
So just drop the patch.
And also remove the ginstall hack to fix ptest case failure when single-binary
is enabled, I can't find the reason on why it was needed from git log.
Fixed:
install: missing file operand
Try 'install --help' for more information.
* Reproducer:
DISTRO_FEATURES:append = " ptest"
EXTRA_IMAGE_FEATURES:append = " ptest-pkgs"
IMAGE_INSTALL:append = " coreutils"
PACKAGECONFIG:append:pn-coreutils = " single-binary"
$ bitbake core-image-sato
$ runqemu tmp/deploy/images/qemux86-64/ nographic kvm
On target:
$ cd /usr/lib/coreutils/ptest
$ ./run-ptest
============================================================================
Testsuite summary for GNU coreutils 9.6
============================================================================
TOTAL: 655
PASS: 529
SKIP: 126
XFAIL: 0
FAIL: 0
XPASS: 0
ERROR: 0
============================================================================
make[1]: Leaving directory '/usr/lib/coreutils/ptest'
(From OE-Core rev: 8728815f74f73723e86ba25b56a66b3fb46d6596)
Signed-off-by: Robert Yang <liezhi.yang@windriver.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
musl has subtly different type definitions to glibc, which broke cksum
under musl. Backport a patch from upstream to fix this.
(From OE-Core rev: b177a9d5676cf0cfbaca3c589c513d7d89a2035c)
Signed-off-by: Ross Burton <ross.burton@arm.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
One tests needs xz, and the acl and attr tests if enabled need the
corresponding tools.
(From OE-Core rev: 9caa68b9af19fea283ecdd55c4a8afd371fe388a)
Signed-off-by: Ross Burton <ross.burton@arm.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Backport a patch to fix crash for ls --context when enable selinux:
root@qemux86-64:~# ls -Z /home
Segmentation fault (core dumped)
(From OE-Core rev: 414c7767fbfecf3afa4e64e8e3f50d56b6a65310)
Signed-off-by: Yi Zhao <yi.zhao@windriver.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
The bulk of these recipes used acpaths to work around argument list
limits as we passed the full path to every directory. As this behaviour
no longer happens we can remove these workarounds.
(From OE-Core rev: c4336f1b0da981b3ea396b17779b67898bceccef)
Signed-off-by: Ross Burton <ross.burton@arm.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Upgrade coreutils from 9.5 to 9.6.
License-Update: Update copyright year (2024 -> 2025).
Fix do_install_ptest for new version to avoid buildpath QA issue.
(From OE-Core rev: b3de417033fda92956db093cf17a0b5134bd2f88)
Signed-off-by: Chen Qi <Qi.Chen@windriver.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Recipes are much more readable with whitespace around the assignment operators.
Fix various assignments in OE-Core to show this is definitely the preferred
formatting.
(From OE-Core rev: 30ea609d3357fb3de911f2f6a5e6856c151b976a)
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
bash-dev-native does not exist, nor should it. Tweak the recipe so that if/as/when
we fix native ${PN}-XXX handling, this doesn't break. Use variable indirection
as the least worse solution as an override directly will get overwritten with
variable renaming, resulting in a warning.
(From OE-Core rev: 879590563bc43a303e77541cd99979a449d9bfed)
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
The test writes to the disk and means the space used changes. If this
crosses a number boundary, the heading spacing can change causing a test
failure. This was triggered by a recent gcc upgrade.
Add a fix for this which has been shared with upstream.
(From OE-Core rev: ca6f0d81fc7d5e53d216e5131724e826369fd4ae)
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Previously, the noinst_PROGRAM getlimits is put in coreutils-ptest
package in order to execute the ptest. However, this command might
also be needed by other ptest packages. As an example, findutils
4.10.0 ptest pacakge would need this command. So we split it out
into a new package.
(From OE-Core rev: 7bc06eed72ceb55d2c5342e9130e39bd15c04b9a)
Signed-off-by: Chen Qi <Qi.Chen@windriver.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
0001-posixtm-pacify-clang-18.patch
CVE-2024-0684.patch
removed since they're included in 9.5
0001-local.mk-fix-cross-compiling-problem.patch
remove-usr-local-lib-from-m4.patch
refreshed for 9.5
License-Update: Copyright updatedto 2024.
(From OE-Core rev: ac2b8134bed1abdb485aa2826d07b430dc6b5f00)
Signed-off-by: Wang Mingyu <wangmy@fujitsu.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
The upstream maintainer for Error has deprecated it for quite some time [1].
There is no dependency in current coreutils tests for it.
[YOCTO #15461]
[1] https://metacpan.org/pod/Error#WARNING
Using the "Error" module is no longer recommended due to the black-magical
nature of its syntactic sugar, which often tends to break. Its maintainers
have stopped actively writing code that uses it, and discourage people from
doing so.
(From OE-Core rev: 16c8c8de3303805695f58e241245aafa61b3c772)
Signed-off-by: Tim Orling <tim.orling@konsulko.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
bash fails in xmalloc when running these tests. More thorough
investigation may reveal real cause, however, it seems to fail on
other musl distros as well.
(From OE-Core rev: cd31bb507bfb794379950dd0aa38b810ba194d2f)
Signed-off-by: Khem Raj <raj.khem@gmail.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
This is needed by several tests during run on target
Fixes
grep: /usr/lib/coreutils/ptest/lib/config.h: No such file or directory
inotify-race.sh: skipped test: inotify is not supported
More tests are now passing
============================================================================
Testsuite summary for GNU coreutils 9.4
============================================================================
# TOTAL: 643
-# PASS: 509
-# SKIP: 131
+# PASS: 516
+# SKIP: 124
(From OE-Core rev: 66ea2aab453384d4d265969a209ee6b156dd421d)
Signed-off-by: Khem Raj <raj.khem@gmail.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Drop a backport which is already in 9.4
(From OE-Core rev: a51b0456001fbff3443e827aa9465648699ba0ef)
Signed-off-by: Khem Raj <raj.khem@gmail.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
There is a missing comma in an AC_TRY_RUN call which means it has no
fallback for cross-compilation, so if the host doesn't have a French
locale then AC_TRY_RUN fails.
(From OE-Core rev: 06c850f18d4537794b87d1bf53ce5c917f4849d2)
Signed-off-by: Ross Burton <ross.burton@arm.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
License-Update: copyright years
(From OE-Core rev: fe6b74e61eada3ab0c5d71b3f7e6516c9d31cc91)
Signed-off-by: Alexander Kanavin <alex@linutronix.de>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
If gcc is installed in image, ptest result has 4 ERROR.
ERROR: tests/rm/r-root.sh
ERROR: tests/rm/rm-readdir-fail.sh
ERROR: tests/cp/nfs-removal-race.sh
ERROR: tests/ls/getxattr-speedup.sh
r-root.log as an example:
--------------------------
k.c:1:10: fatal error: stdio.h: No such file or directory
1 | #include <stdio.h>
| ^~~~~~~~~
compilation terminated.
r-root.sh: set-up failure: failed to build shared library
ERROR tests/rm/r-root.sh (exit status: 99)
--------------------------
reason:
The run-ptest calls make cmd to run test cases.
In these cases, k.c file is created and compiled by gcc before run.
There is a stdio.h file in /usr/include/ directory.
Normally, gcc has /usr/include as part of its default search path.
But in Makefile, it has the "--sysroot=recipe-sysroot" parameter
which makes it does not work.
solution:
Delete "--sysroot=recipe-sysroot" from Makefile.
other:
If gcc is not installed in image, these cases will be skipped.
(From OE-Core rev: e8ccb880c85ec03d055f195f28ba6a838b4b93c7)
Signed-off-by: Luca Ceresoli <luca.ceresoli@bootlin.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
coreutils-native will pick up openssl on the host if it's GPL
compatible (version >= 3), which causes uninative failures with hosts
that don't have openssl3.
Add a PACKAGECONFIG entry for openssl so it can be enabled, but isn't
by default.
(From OE-Core rev: 9859a8124a0c09ac38d476445e7df7097f41d153)
Signed-off-by: Daniel McGregor <daniel.mcgregor@vecima.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
PACKAGES uses ${PN}-dev so be consistent with the addition to the
variable to avoid weird variable conflicts.
The flags variable used here is messy, key expansion and overrides are
not supported by flags. The plain variable access does happen to work
though, so leave it as is for now and note.
(From OE-Core rev: a5edae117d0d2a59fd3456ccbeeb6cd35dd1951f)
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Drop patches:
fix-selinux-flask.patch
(upstream fixed the issue)
e8b56ebd536e82b15542a00c888109471936bfda.patch
(backport)
0001-uname-report-processor-and-hardware-correctly.patch
(upstream explicitly marks the options as non-portable and unreliable[1];
the patch is difficult to rebase, use case for oe unclear)
[1] https://git.savannah.gnu.org/gitweb/?p=coreutils.git;a=commitdiff;h=v8.24-7-g6d67649
License-Update: copyright years
(From OE-Core rev: c22f81a375b900c71e8ad0f6d13c5aa84b1bdad3)
Signed-off-by: Alexander Kanavin <alex@linutronix.de>
Signed-off-by: Luca Ceresoli <luca.ceresoli@bootlin.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
The statx requires glibc >= 2.28 and linux kernel >= 4.11, but coreutils's
configure only checks glibc compatibility for statx syscall but fail to check
kernel support, e.g.:
RedHat Enterprise Linux Server 7.6 (Maipo)
Host kernel: 3.10.0-1127.8.2.el7.x86_64
Docker OS: Ubuntu 20.04.1 LTS
$ bitbake coreutils-native
find the binary ls and run it as "ls -l ."
The result is something like: "?????????. ? ? ? ? ? foo"
This is because glibc is 2.31 (Ubunut 20.04 in docker) which has statx,
but host's kernel is 3.10.0 (CentOS 7) which doesn't support statx.
Disable statx for native build to fix the problem.
Original from: Davi Poyastro <davi.poyastro@nokia.com>
(From OE-Core rev: 6c120d8856fab044e7b8e09d6de91c2b228a2dd9)
Signed-off-by: Robert Yang <liezhi.yang@windriver.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Three CVEs were meant to be ignored via CVE_WHITELIST, but that wasn't
the correct variable name.
The CPEs for those CVEs mean that they don't get picked up in our report,
so just remove the assignment.
(From OE-Core rev: dea00faf30ec7c19b6b5ed4651b430ba3faf69ff)
Signed-off-by: Ross Burton <ross.burton@arm.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
An automated conversion using scripts/contrib/convert-spdx-licenses.py to
convert to use the standard SPDX license identifiers. Two recipes in meta-selftest
were not converted as they're that way specifically for testing. A change in
linux-firmware was also skipped and may need a more manual tweak.
(From OE-Core rev: ceda3238cdbf1beb216ae9ddb242470d5dfc25e0)
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
This is the result of automated script conversion:
scripts/contrib/convert-overrides.py <oe-core directory>
converting the metadata to use ":" as the override character instead of "_".
(From OE-Core rev: 42344347be29f0997cc2f7636d9603b1fe1875ae)
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
coreutils is using gnulib as a submodule. In the tarball used by the recipe the
gnulib source is included. The patch comes from
gnulib
47bf2cf318
In the next release of coreutils this fix will be included.
It caused ‘find’ and ‘du’ to dump core, and it was useful
only for obsolescent Linux filesystems anyway. Problem reported in:
https://lists.gnu.org/r/bug-gnulib/2020-04/msg00068.html
Quite possibly there is still a serious underlying fts bug with
tight-loop-check and mutating file systems, but if so this patch
should cause the bug to be triggered less often.
* lib/fts.c (enum leaf_optimization): Remove
NOSTAT_LEAF_OPTIMIZATION, as it’s problematic.
(S_MAGIC_REISERFS, S_MAGIC_XFS): Remove; no longer needed.
(leaf_optimization): Remove special cases for ReiserFS and XFS.
(fts_read): Remove NOSTAT_LEAF_OPTIMIZATION code.
* lib/fts_.h (struct _ftsent.fts_n_dirs_remaining):
Remove. All uses removed.
(From OE-Core rev: d5d0f173be8cc27a0d5c475754483e76185b46b8)
Signed-off-by: Anders Wallin <anders.wallin@windriver.com>
Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* busybox 1.33.0 added base32 applet and now do_rootfs for read-only images is failing with:
do_rootfs: busybox.postinst returned 1, marking as unpacked only, configuration required on target.
ERROR: image-devel-1.0-r2 do_rootfs: Postinstall scriptlets of ['busybox'] have failed. If the intention is to defer them to first boot,
then please place them into pkg_postinst_ontarget_${PN} ().
Deferring to first boot via 'exit 1' is no longer supported.
Details of the failure are in image-devel/1.0-r2/temp/log.do_rootfs.
and log.do_rootfs shows:
update-alternatives: Error: not linking image-devel/1.0-r2/rootfs/usr/bin/base32 to /usr/bin/busybox.nosuid since image-devel/1.0-r2/rootfs/usr/bin/base32 exists and is not a link
(From OE-Core rev: d2365442568c206a13165f8c71a7b7a5d0c6ff4e)
Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
When using coreutils nativesdk (e.g. with buildtools-tarball) for
running oe-core builds, a number of recipes/classes/etc. expect xattr
support. This requirement is also expressed by the existing
PACKAGECONFIG_class-native default including xattrs.
(From OE-Core rev: 80d7debffdeed165006b26dcb89cffafaaecca06)
Signed-off-by: Nathan Rossi <nathan@nathanrossi.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
CVE-2013-0221 through -223 are all SUSE-specific, so add them to the
whitelist.
(From OE-Core rev: 59f2120de3b6d53bbfb9db858ffb8b7b20c8d1ce)
Signed-off-by: Ross Burton <ross.burton@arm.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Add perl-modules to the RDEPENDS to avoid having to list all perl
modules that are required, as this package isn't going to be installed
outside of testing builds.
Remove libmodule-build-perl from RDEPENDS, it appears that this isn't
needed anymore. With and without this package the test results on my
image are the same: 619 tests, 462 pass, 154 skip, 3 fail. This
*drastically* reduces the build impact of enabling ptest as
packagegroup-core-build-essential (thus target gcc) is in the dependency
chain.
(From OE-Core rev: 7937da462b588403400755d264db0edde74aa4dc)
Signed-off-by: Ross Burton <ross.burton@arm.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Commit 992cec44 (coreutils: Move stdbuf into an own package
coreutils-stdbuf) breaks package-qa when the single-binary
PACKAGECONFIG is used:
ERROR: coreutils-8.32-r0 do_package_qa: QA Issue: /usr/bin/stdbuf contained in package coreutils-stdbuf requires /usr/bin/coreutils, but no providers found in RDEPENDS_coreutils-stdbuf? [file-rdeps]
ERROR: coreutils-8.32-r0 do_package_qa: QA run found fatal errors. Please consider fixing them.
With that PACKAGECONFIG, /usr/bin/stdbuf is just a simple "script"
containing the single line
#!/usr/bin/coreutils --coreutils-prog-shebang=stdbuf
Since there's no point splitting stdbuf to its own package when all
the functionality is in the single big coreutils binary anyway, fix
this by not creating the separate stdbuf package for the single-binary
case. But also make sure that the coreutils-stdbuf item always exists
so recipes can always RDEPEND on coreutils-stdbuf.
(From OE-Core rev: 74d24b5b895198898944260136d05e991a203c11)
Signed-off-by: Rasmus Villemoes <rasmus.villemoes@prevas.dk>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
License-Update: copyright years, http changed to https
(From OE-Core rev: 6e1052d401da5a9fa7f535786d76e033a39bc30a)
Signed-off-by: Alexander Kanavin <alex.kanavin@gmail.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Add an extra comment about the implications of changing DEPENDS.
(From OE-Core rev: ce20c915019d350bf9663b2f27eccf3cef2e29fc)
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
The new ptest dependencies present some challenges, in particular libmodule-build-perl
which effectively depends on gcc. In multilib images, this results in both
libXX-gcc-symlinks and libYY-gcc-symlinks being installed which conflict. This also
makes little sense.
The easiest way to fix this is to disable the automatic -dev package dependencies
and manually specify the correct ones.
(From OE-Core rev: 5463971d45b21512210cf20f3902baf95eacd4c6)
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
coreutils has a large number of tests, including some added by the
Makefile flags RUN_EXPENSIVE_TESTS and RUN_VERY_EXPENSIVE_TESTS that
significantly increase runtime (and that have been disabled). Note
that the coreutils ptest directory is given blanket permissions at
runtime with chmod -R 777 to ensure that the user created for the
tests will be able to run the test scripts and create the necessary
files in the process.
There is still room to improve the results of this ptest without
the aforementioned additions. Of the tests marked SKIP, there are
30 tests that are currently counted as SKIP because they require
sudo permissions, and another 21 that require membership in
multiple user groups. It is important to know that coreutils has
tests for both root and non-root users. Testing showed that 42
tests are skipped when running as root versus 30 when running as a
non-root user, so the decision was made to run the suite as the
latter. Additionally, gdb, valgrind, and strace could be included
in the RDEPENDS list to increase pass rate, but their total
contribution is 13 tests, so they were omitted to reduce image size.
Finally, note that at least one ptest (misc/head-write-error.sh) is
prone to ERROR on builds of core-image-minimal if extra space is
not provided with IMAGE_ROOTFS_EXTRA_SPACE.
(From OE-Core rev: 9a703f8e05d9e7e609d0e04278be290d4051ec31)
Signed-off-by: Trevor Gamblin <trevor.gamblin@windriver.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
The coreutils implementation of stdbuf uses LD_PRELOAD
to dynamically load libstdbuf which calls setvbuf().
This can't be implemented simply in busybox since it produces
one or two statically linked executables. Therefore, stdbuf
should be packaged separately for people who are using busybox
instead of coreutils for the other tools.
coreutils depends on the new package,
so nothing changes when installing coreutils.
(From OE-Core rev: 992cec44ad2073cfe05cb2c58936032af189748a)
Signed-off-by: Adrian Bunk <bunk@stusta.de>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Should be Backport, not Backported
(From OE-Core rev: 728c6c43deff8a3259a1e0f3aef799bec9983090)
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
ls.c license checksum changed due to modified copyright year.
musl fix was backported from RHEL5 and is musl specific as the patched
file is autogenerated during configure phase.
(From OE-Core rev: 5226ce196ff1edb5d2d9d9c7ed5728df8150c09a)
Signed-off-by: Oleksandr Kravchuk <open.source@oleksandr-kravchuk.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* use base_bindir like busybox does to prevent conflicting u-a configs
(From OE-Core rev: ae947ffd0c1531b6a3df250199bff38cce2f5533)
Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
