Commit db1f1adace disabled 'xattr' from
DISTRO_FEATURES when native packages are built, whereas for target
packages it was retained. This changed eg. mtd-utils-native to build
without extended attributes (capabilities) support from there on.
Thus even setcap was called succesfully for a binary during pkg_postinst
on build host, the capabilities did not exist on target rootfs due to
now xattr-less host-side mkfs utility.
Adding xattr to DISTRO_FEATURES_NATIVE restores previous behaviour,
fixing the discontinuity in capability propagation to target
device rootfs.
(From OE-Core rev: 2ad3b8ae1c56a46bf14fc6bc4c34e4b3a568d741)
Signed-off-by: Niko Mauno <niko.mauno@vaisala.com>
Signed-off-by: Ross Burton <ross.burton@intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
This mitigates following issues during u-boot do_compile() step --
otherwise, if comm is not available, they are quietly ignored:
.../scripts/check-config.sh: line 33: comm: command not found
.../scripts/check-config.sh: line 39: comm: command not found
Since 'comm' is provided by coreutils package, adding it to HOSTTOOLS
was considered a lower impact fix compared to adding coreutils-native
buildtime dependency to u-boot recipe.
(From OE-Core rev: 6dc33687de9edd4269cbaf85e30945771f61f313)
Signed-off-by: Niko Mauno <niko.mauno@vaisala.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
These functions were moved to meta/lib/oe in 2010 and the base_* functions in
utils.bbclass were intended to be a short-term compatibility layer. They're
still used in a few places, so update the callers to use the new functions.
(From OE-Core rev: c97acbd034532895ce57c6717ed1b3ccc7900b0d)
Signed-off-by: Ross Burton <ross.burton@intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
This allows scripts/bitbake-whatchanged to calculate the dependency
changes correctly since it needs to set different STAMPS_DIR during
the comparation.
(From OE-Core rev: 8547f1e29104b75299f1056524da4a058a029940)
Signed-off-by: Ming Liu <liu.ming50@gmail.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
If you have a recipe which does not include SRCPV in PV but does set
SRCREV = "${AUTOREV}" and you run do_fetch, then change the repo to a
new commit then run do_unpack, do_unpack will fail since the new commit
doesn't exist in the repo that was fetched.
The problem is the revision chosen is not represented in the do_fetch
task hash. It if were, the fetch would rerun first and the commit would be
present. It works when PV includes SRCPV since that does contain the chosen
commit from the AUTOREV.
The solution is to include the SRCPV value into the representation of AUTOREV
used for checksum calculation purposes.
Add a selftest for this issue.
(From OE-Core rev: 7b8ee9285a197784d51e339f1603240f49435846)
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Setting IMAGE_FSTYPES_DEBUGFS to the same value as IMAGE_FSTYPES can
lead to creating a large number of DEBUGFS filesystem images, many of
which may not make much sense (or may not even be buildable).
(From OE-Core rev: a41f7cdf0cbc56a283d5c845c36d88a0208bf386)
Signed-off-by: Andre McCurdy <armccurdy@gmail.com>
Signed-off-by: Ross Burton <ross.burton@intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Before we introduced DISTRO_FEATURES_NATIVE on commit:
db1f1adace
ipv6 was enabled by default on DISTRO_FEATURES via DISTRO_FEATURES_LIBC
hence for example python-native was built with ipv6 support.
After this, ipv6 was automatically disabled on DISTRO_FEATURES.
On some packages (python) this may cause errors when they try to download
something on their do_compile stage.
This patch adds ipv6 to DISTRO_FEATURES_NATIVE leaving it as it was
before, to avoid errors like the one mentioned above
[YOCTO #11978]
(From OE-Core rev: a09184bf47323b63d9548d17cc1e4e694cb605a9)
Signed-off-by: Alejandro Hernandez <alejandro.hernandez@linux.intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
We changed to make tools required by testimage to be included conditionally.
This resulted in users who use ssh for git fetching having failures.
Add ssh to HOSTTOOLS_NONFATAL to make things work for the above situation.
[YOCTO #12227]
(From OE-Core rev: 50e7619aebae5351e9a41fe1b909a31b9e383f0a)
Signed-off-by: Chen Qi <Qi.Chen@windriver.com>
Signed-off-by: Ross Burton <ross.burton@intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Add tools required by testimage to HOSTTOOLS only when testimage is
inherited. These tools, as described in the comment, are only required
by the testimage task. So this change should not have negtive effect.
This would also solve build error on hosts which miss some tool such as scp.
(From OE-Core rev: 8ca61a5464743ff85b6d26886112750d6ddd13e0)
Signed-off-by: Chen Qi <Qi.Chen@windriver.com>
Signed-off-by: Ross Burton <ross.burton@intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
The 'id' utility is used in 'rootfs_check_host_user_contaminated'
rootfs-postcommand so it must be available.
(From OE-Core rev: 6c054925d5f80790aea4cce6f8f83edc7da623b9)
Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
Signed-off-by: Ross Burton <ross.burton@intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Search made with the following regex: getVar ?\((.*), True\).
(From OE-Core rev: dbc0eaf478feb3f752ae22fd184984494fc85d0a)
Signed-off-by: Ming Liu <liu.ming50@gmail.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Also update the ASSUME_PROVIDED in bitbake.conf to contain gawk-native
as the dependency is passed in via HOSTTOOLS for native builds.
This allows for recipes to depend on gawk-native, and have the
dependency met if not already provided by the host tools.
(From OE-Core rev: cbc396dd10488990c98bb6fd94c7d10a736d57c1)
Signed-off-by: Nathan Rossi <nathan@nathanrossi.com>
Signed-off-by: Ross Burton <ross.burton@intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
If FILESYSTEM_PERMS_TABLES was not defined, the default was selected by the
packages.bbclass. This made it difficult for a recipe or layer to 'append'
to the default.
Copy the default into the bitbake.conf, allowing future _append and += style
actions.
Default was remove from package.bbclass. If a value is not set, only the
built-in perms fixes will be used.
(From OE-Core rev: b65736e1b7161619a0c5972376d3e713ccf53850)
Signed-off-by: Mark Hatle <mark.hatle@windriver.com>
Signed-off-by: Ross Burton <ross.burton@intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* it's used by bzr fetcher:
meta/conf/bitbake.conf:FETCHCMD_bzr = "/usr/bin/env bzr"
and when it isn't available in PATH do_fetch tasks fail with:
/usr/bin/env: ‘bzr’: No such file or directory
* it was also added in:
https://patchwork.openembedded.org/patch/140107/
but this change wasn't merged (nor rejected AFAIS)
(From OE-Core rev: c7ba7e9e7a7ca2caf453106112dc5a3c855b21d3)
Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
${BUILDSDK_CXXFLAGS} was introduced since
commit 55c83cb239df5faf5e2143fffca47f2f16931cb3
cross.bbclass: override TARGET_* flags
bitbake.conf has definitions for both ${BUILDSDK_CPPFLAGS} and
${BUILDSDK_CFLAGS} but there is none for ${BUILDSDK_CXXFLAGS}.
This was a regression as in the past, CXXFLAGS is the same as
CFLAGS in SDK environment.
Adding definition for ${BUILDSDK_CXXFLAGS} will resolve CXXFLAGS
being set wrongly in SDK environment.
[YOCTO #11769]
(From OE-Core rev: 073ca1cbd1b70d5b36618584a8c88cbba391a259)
Signed-off-by: Chang Rebecca Swee Fun <rebecca.swee.fun.chang@intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Its been highlighted that TARGET_SYS can be changed by MACHINE and DISTRO files
so this doesn't work at all today. build/ configuration files also don't see to
be used. Drop these forms of include files for those reasons and simplfy the code
slightly.
(From OE-Core rev: df61351b625fcd2e86aac7630944cc0403455de6)
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
The default value is "yes" which results in the /var/log being a link
pointing to /var/volatile/log which is on tmpfs.
Setting valid boolean false value ('no', 'n', 'false', 'f', '0') would make
/var/log to be a directory on persistent storage.
[YOCTO #6132]
(From OE-Core rev: 016bafce52f74462dc8f21a1c1b43ba2e6e59442)
Signed-off-by: Chen Qi <Qi.Chen@windriver.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
We don't need to reparse recipes just because BB_SERVER_TIMEOUT changed,
so exclude it from the config hash.
(From OE-Core rev: a686fcabacd49fdb814e646305c1f33fee1d5abf)
Signed-off-by: Paul Eggleton <paul.eggleton@linux.intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
CCACHE_DISABLE was added to bitbake.conf in oe-core dd2bab (June 2012) because
autogen-native exports HOME=/dev/null during the build, which is then used by a
host ccache to construct the path to it's cache (/dev/null/.ccache) and this
fails.
However we now always export CCACHE_DIR to solve the same problem in a more
efficient way so CCACHE_DISABLE can be deleted.
(From OE-Core rev: ef33a3138384667f819688141086102e6e83ec44)
Signed-off-by: Ross Burton <ross.burton@intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
A new configuration variable ${root_prefix} added, which shall be used by all
base_{lib,bin,sbin}dir variables. When usrmerge DISTRO_FEATURE is enabled
${root_prefix} points to ${exec_prefix} otherwise to ${base_prefix}
(From OE-Core rev: 700848c6ebd03bf3105d09a41d758883ab875618)
Signed-off-by: Amarnath Valluri <amarnath.valluri@intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
This reverts commit 3b3ae91a22d6f685e804df4f32cdeebe1bd6bd88.
It turned out that the code which expands DISTRO_FEATURES early during
base config parsing can fail because some entries in DISTRO_FEATURES
might call Python functions like base_conditional() from base.bbclass
which aren't defined yet.
A different solution will be needed.
(From OE-Core rev: 0c6e4a14ba8d9d9701ec16ffe46d618f41633571)
Signed-off-by: Patrick Ohly <patrick.ohly@intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
A long time ago (6 years), this seemed like a good idea. The reality is
that OVERRIDES should not be being added to hashes and if it is, it likely
needs excluding in its own right. This was a nice workaround but we need
to fix the real underlying issues now. In some cases this means excluding
OVERRIDES from the variables dependency using the vardepsexclude flag however
caution is needed to ensure this is safe.
Variable values used to construct hashes are unexpanded but the values used
are computed after the application of OVERRIDES. The important detail is if
the end resulting unexpanded value changes, not the value of the OVERRIDES
used in the construction of that unexpanded value. This is why dependencies
on OVERRIDES itself shouldn't be in the hashes in general.
The recent DISTRO_FEATURES changes adding in override mappings for them
highlighted this issue. We have some good sstate tests which are effective
at highlighting where potential issues arrive with OVERRIDES contamination
(oe-selftest -r sstatetests.SStateTests).
(From OE-Core rev: b227781f9c59a7dfe30f3f1c0dcff87e29a1689b)
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
As discussed in "[Openembedded-architecture] Yocto Compatible 2.0 +
signature changes", changes in .bbappend must depend on some explicit
configuration change, typically selecting a distro feature.
For _append and _remove, adding an override that is set only when the
corresponding entry is in DISTRO_FEATURES achieves that:
In local.conf:
DISTRO_FEATURES_append = " my-distro-feature"
In layer.conf:
DISTRO_FEATURES_OVERRIDES += "my-distro-feature"
In a .bbappend:
do_install_append_df-my-distro-feature () {
...
}
The subset of DISTRO_FEATURES that are made available as overrides
must be configured explicitly because using them this way should
be a conscious decision.
(From OE-Core rev: 3b3ae91a22d6f685e804df4f32cdeebe1bd6bd88)
Signed-off-by: Patrick Ohly <patrick.ohly@intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
If ASSUME_PROVIDES contains libsdl-native, we need to add sdl-config
to HOSTTOOLS to allow access to the host sdl-config.
(From OE-Core rev: eeb248c1a017e07e36b6fbaafe45006e3869f41a)
Signed-off-by: Jonathan Liu <net147@gmail.com>
Signed-off-by: Ross Burton <ross.burton@intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
The path to where to install and find the sysroot components is used
in many places. This warrants it to get its own variable.
(From OE-Core rev: 70a84b525470f72339568409daf84845904e4cab)
Signed-off-by: Peter Kjellerstedt <peter.kjellerstedt@axis.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
The path to where to install and find the tools copied from the host
environment is already used in a couple of places. This warrants it to
get its own variable.
(From OE-Core rev: 8164c466943ffedff399009bf5547dba4f06d6c8)
Signed-off-by: Peter Kjellerstedt <peter.kjellerstedt@axis.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
icedtea-native from meta-java needs sha256sum for checksum validation.
Therefore add sha256sum to HOSTTOOLS (as md5sum is already in there).
Without it the icedtea-native build will fail during configuration at
current master.
(From OE-Core rev: d0d3abdf9e2dec57f3849813faa5e7e3d34b83a4)
Signed-off-by: Richard Leitner <richard.leitner@skidata.com>
Signed-off-by: Ross Burton <ross.burton@intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
There seems to be little advantage to letting distro features affect
native builds. There is a significant disadvantage: a change to
DISTRO_FEATURES will trigger a lot of unnecessary native tasks. In a
test like this:
$ bitbake core-image-minimal
# append " systemd" to DISTRO_FEATURES
$ bitbake core-image-minimal
The latter build takes 44 minutes (28%) of cpu-time less with this
patch (skipping 135 native tasks). Sadly wall clock time was not
affected as glibc remains the bottleneck.
Set native distro features to DISTRO_FEATURES_NATIVE appended with
an intersection of DISTRO_FEATURES and DISTRO_FEATURES_FILTER_NATIVE.
Current default values (baitbake.conf) are
* DISTRO_FEATURES_FILTER_NATIVE ?= "api-documentation" (as gtk-doc-native
has much less dependencies when built without it)
* DISTRO_FEATURES_NATIVE ?= "x11" (to enable native UIs even if target
does not containe them)
Do the variable setting in native_virtclass_handler() because otherwise
it could still be overridden by appends and the feature backfilling.
Shuffle the early returns so DISTRO_FEATURES gets set as long as
the packagename ends with "-native".
Add similar variables for nativesdk.
To make nativesdk work we need to enable the locale options so
nativesdk-glibc-locales can build and to avoid the init manager check
in the nativesdk case so add those fixes.
(From OE-Core rev: 731744d5538e315702be828e6f2bd556309dee07)
Signed-off-by: Jussi Kukkonen <jussi.kukkonen@intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
There are no users of this left after recipe specfic sysroots was implemented,
drop the variable as it no longer makes sense or is useful.
(From OE-Core rev: a2fbf85f68b685c32049fb48aed0248369911c49)
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Users should be able to locally choose DEPLOY_DIR without impacting
the reuse of sstate, this change allows that.
[YOCTO #11110]
(From OE-Core rev: 460f6ca573667dfcbd66f5efcaebf686f1442b36)
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
This adds aws to HOSTTOOLS_NONFATAL in order to get the s3 fetcher
working again.
(From OE-Core rev: 6d6d0737a29bbf3dcd231bfefe13784ed16dd55a)
Signed-off-by: Elizabeth 'pidge' Flanagan <pidge@toganlabs.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Having changes the sdk test to cpio from cvs, we no longer require an
editor to be present. This patch removes vi from the list of required
tools.
(From OE-Core rev: cca2ccb6d77a433e9d7c535344c4fc1e04589bc0)
Signed-off-by: brian avery <brian.avery@intel.com>
Signed-off-by: Ross Burton <ross.burton@intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
runqemu is using sudo to configure tap networking. Without sudo
in HOSTTOOLS_NONFATAL it may cause bitbake -c testimage to fail
with this error:
runqemu - INFO - Setting up tap interface under sudo
/bin/sh: sudo: command not found
(From OE-Core rev: 716e0524cfbcac2eb272be1014280833b74bc5c4)
Signed-off-by: Ed Bartosh <ed.bartosh@linux.intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Now that pip3-native is used by build-appliance, we should no longer
need this host tool.
(From OE-Core rev: 096f943d4b7a7cf5d4c3d45f34be5ddcd2475790)
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
oe-git-proxy depends on socat host tool but it's not
whitelisted and triggers a 'binary not in PATH' error.
Whitelist socat but make it a HOSTTOOLS_NONFATAL since
it's not a hard dependency.
(From OE-Core rev: 97f979ee61a06349139ccc47feaf051bdbcf0e16)
Signed-off-by: Mikko Ylinen <mikko.ylinen@linux.intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
This is used by some of our proxy scripts but isn't required for all
builds so add to HOSTTOOLS_NONFATAL.
(From OE-Core rev: 4837b8cc3248c07f77a91745b80e6129ec3dfa1f)
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
We currently have a determinism problem in that the host tools present
in PATH can influence the build. In particular, the presence of pkg-config
on the build host can mask missing pkgconfig class dependencies.
This adds in a new HOSTTOOLS variable and then uses it to set up a directory
of symlinks to the whitelisted host tools. This directory is placed as PATH
instead of the usual /usr/bin:/bin and so on.
This should improve determinism of builds and avoid the issues which have
been particularly obvious since the introduction of recipe specific sysroots.
If users find there is a tool missing, they can extend HOSTTOOLS from a global
class or global conf file.
Right now the settings should be enough to build everything in OE-Core.
(From OE-Core rev: fa764a403da34bb0ca9fa3767a9e9dba8d685965)
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
USE_LDCONFIG could previously be set to 0 by distros which do not
require ldconfig or ld.so.conf on the target. Since more and more
recipes may need to respect that option, replace the ad-hoc variable
with a distro feature.
Distros which previously set:
USE_LDCONFIG = "0"
Should now instead use:
DISTRO_FEATURES_BACKFILL_CONSIDERED_append = " ldconfig"
(From OE-Core rev: a905df2dd8f43a2febffa64a39b6e508510326a0)
Signed-off-by: Andre McCurdy <armccurdy@gmail.com>
Signed-off-by: Ross Burton <ross.burton@intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
TARGET_SYS is defined in terms of TARGET_ARCH, so it's not valid
until after TUNE_ARCH has been set by the machine config. The
original order of includes resulted in an attempt to include
non-existent files such as:
conf/target/INVALID-oe-linux.conf
(From OE-Core rev: b33e644da0d8b6edb97257b16430b545c289883a)
Signed-off-by: Andre McCurdy <armccurdy@gmail.com>
Signed-off-by: Ross Burton <ross.burton@intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
The extend_recipe_sysroot itself is excluded from the task hashes. This is
because it only ever acts upon the contents of the task dependencies and hence
those checksums accurately relfect what its doing. It does mean sysroots don't
repopulate if this function changes but there are other easy ways to achieve
that if needed.
(From OE-Core rev: cec305150801d43d58e3758e020e714d2e90e10b)
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
