The patch tool will apply patches by default with "fuzz", which is where if the
hunk context isn't present but what is there is close enough, it will force the
patch in.
Whilst this is useful when there's just whitespace changes, when applied to
source it is possible for a patch applied with fuzz to produce broken code which
still compiles (see #10450). This is obviously bad.
We'd like to eventually have do_patch() rejecting any fuzz on these grounds. For
that to be realistic the existing patches with fuzz need to be rebased and
reviewed.
(From OE-Core rev: 9f15e5256eb79c8cfc4b3a4e11617eeb5f38edea)
Signed-off-by: Ross Burton <ross.burton@intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
The result of running dbus-test-ptest was a series of
various segfaults, interpreted as FAILs. This was a direct consequence
of the test suite loading the installed shared library libdbus-1.so, not the
one built along the test suite.
While we normally want to test against the installed libraries, we cannot
do this in this case as the test suite expects a library that is configured/compiled
differently from the installed one. We could configure the installed library
identically as the test suite expects, (and there should be no issues), however
this is not desirable for performance reasons.
Hence we need to use the library built along with the test suite.
Of course, running the test suite against its own library does not
test the installed library, however they are both built from the same
sources so that can give us some kind of indication.
The following changes were made:
1. Configure the test library as close as possible to the installed one,
with some additional configuration options that are needed for testing.
(Use dbus_1.12.2.bb recipe as a template)
2. Include the shared libraries in the package, use LD_LIBRARY_PATH during
testing to load them instead of the installed ones.
3. Add a few more tests. (There are still some additional tests built that
are not used, but they would have to be special-cased).
4. When evaluating the test results, differentiate between "FAIL" and "SKIP"
[YOCTO #10841]
[YOCTO #12277]
(From OE-Core rev: 5d148aa9c3c338fabab1e60e2ca64d09c9b8477f)
(From OE-Core rev: 0828850fd09f738572ae8259384af07eeb81182b)
Signed-off-by: Juro Bystricky <juro.bystricky@intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
1. os-test.patch is removed because current dbus has removed
distro specific init script.
2. Add autoconf-archive to DEPENDS to fix do_configure failure as below.
error: Unexpanded AX_ macro found.
3. Modify FILES variable to fix installed-vs-shipped QA issue.
(From OE-Core rev: 3e1e783f0e18f7be1527280f39b3c74f048e24e6)
Signed-off-by: Chen Qi <Qi.Chen@windriver.com>
Signed-off-by: Ross Burton <ross.burton@intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
The largefile distro feature has been enabled by default in oe-core
for a long time and, more recently, also in poky-tiny. Building
without the largefile distro feature receives little or no testing.
Many packages now enable LFS without exposing a configure option, so
there should be very little expectation that disabling the distro
feature will result in a distro which globally disables LFS.
Respecting the distro feature adds a maintenance over-head and may be
the source of configurations oddities (e.g. dbus-native currently
builds with LFS disabled for no clear reason - fixed by this commit).
Ignore the largefile distro feature more widely, as a first step
towards deprecating and eventually removing it.
(From OE-Core rev: a75ccaea77c8aad8d46e87e8ed4af2e2e0ad5327)
Signed-off-by: Andre McCurdy <armccurdy@gmail.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
configure.ac from dbus uses $PATH to get the location of systemctl.
If it is not found /usr/bin/systemctl is used. It is possible to
override the location by passing SYSTEMCTL=[value] to configure.
The value is used to replace @SYSTEMCTL@ in systemd-user/dbus.socket.in.
dbus.socket sets the environment variable DBUS_SESSION_BUS_ADDRESS
using systemctl.
dbus does not depend on systemd-systemctl-native, so location from
host installation or the default value gets used. Adding
systemd-systemctl to the build would give path from sysroot.
Forcing SYSTEMCTL=${base_bindir}/systemctl for target gives the
correct path there and the environment variable is set after a user
session was opened.
[YOCTO #11002]
(From OE-Core rev: e9471f8da3946439141ccdd8284200aa614df46c)
Signed-off-by: Andy Kling <andreas.kling@peiker-cee.de>
Signed-off-by: Ross Burton <ross.burton@intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
There's no need to cd to the target directory when creating symlinks, so don't.
[ YOCTO #10985 ]
(From OE-Core rev: 64d75438955c39e01187e897e9df47c93ac6c45a)
Signed-off-by: Ross Burton <ross.burton@intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
systemctl is needed if both systemd and sysvinit are in distro
features.
(From OE-Core rev: 39fb37a5143981ae16e722f4ebbbe1b29cbed5a4)
Signed-off-by: Jussi Kukkonen <jussi.kukkonen@intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
0001-configure.ac-support-large-file-for-stat64.patch is removed as it's
a backported patch and is already in the latest codes.
(From OE-Core rev: ba0493391207c5e170548a58c49ca593b4d61e08)
Signed-off-by: Chen Qi <Qi.Chen@windriver.com>
Signed-off-by: Ross Burton <ross.burton@intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
All of the binaries are linked with libtool now, so install the binaries and not
the wrapper scripts.
Also remove dbus-1.init from SRC_URI as dbus-test doesn't use it.
[ YOCTO #9528 ]
(From OE-Core rev: a4b5076b2c06cafff0ce764955d0aa7c334c7a8e)
Signed-off-by: Ross Burton <ross.burton@intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Upstream has accepted this patch, so update the header and revise the patch to
reflect the form that was merged.
(From OE-Core rev: 17cdfcb742f989af9af821d4a4517e7068ae5ad9)
Signed-off-by: Ross Burton <ross.burton@intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Now that systemd doesn't use DBus directly, dbus can --enable-systemd. In fact
this appears to be essential for DBus to work on under modern systemd.
python-config.patch refreshed.
Package dbus-test-tool into PN-dev, and remove obsolete dbus-glib-tool
reference.
Remove obsolete --without-dbus-glib option, and dependency on dbus-glib in
dbus-test.
[ patch originally by Chen, tweaked and message rewritten by RB ]
(From OE-Core rev: 3cd34c673d2f64e310b474036754e1ead5775d66)
Signed-off-by: Chen Qi <Qi.Chen@windriver.com>
Signed-off-by: Ross Burton <ross.burton@intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
While starting dbus-daemon on a 32-bit linux host and it invokes
fstat to load /etc/dbus-1/system.conf through NFS. If system.conf
was created with a large indoe number on 64-bit host. The above
fstat invoking failed. Here is the log of strace:
............
$ ls -i /etc/dbus-1/system.conf
53778558109 /etc/dbus-1/system.conf
$ strace /usr/bin/dbus-daemon --system --address=systemd: --nofork --nopidfile --systemd-activation
|open("/etc/dbus-1/system.conf", O_RDONLY) = 4
|fstat64(4, {st_mode=S_IFREG|0644, st_size=3340, ...}) = 0
|close(4) = 0
|close(3) = 0
|write(2, "Failed to start message bus: Fai"..., 109Failed to start message bus:
Failed to stat "/etc/dbus-1/system.conf": Value too large for defined data type
|) = 109
|exit_group(1) = ?
|+++ exited with 1 +++
............
In this situation, we should support large-file for stat64. Add marco
AC_SYS_LARGEFILE to do the detection at configure time. It can be disabled
by configuring with the `--disable-largefile' option.
[YOCTO: #8863]
(From OE-Core rev: 33a7a9b3efafc35ed1409fdfa8ab8f544f1babc3)
Signed-off-by: Hongxu Jia <hongxu.jia@windriver.com>
Signed-off-by: Ross Burton <ross.burton@intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
In some recipes overly-split -dbg packages were merged into PN-dbg. Unless
there's a very good reason, recipes should have a single -dev and -dbg package.
(From OE-Core rev: a3b000643898d7402b9e57c02e8d10e677cc9722)
Signed-off-by: Ross Burton <ross.burton@intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
With the autodebug package generation logic, specifically setting FILES_${PN}-dbg
isn't needed in most cases, we can remove them.
(From OE-Core rev: 3ab59d49dd7c18e194b58d1248b4b87709b5a738)
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Fix a variety of problems such as typos, bad punctuations, or incorrect
Upstream-Status values.
(From OE-Core rev: bd220fe6ce8c3a0805f13a14706d3130ea872604)
Signed-off-by: Ross Burton <ross.burton@intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Skip the warning for dbus-ptest:
dbus-1.8.18: dbus-ptest rdepends on dbus-test-ptest, but it isn't a build dependency? [build-deps]
We add dbus-test to dbus' DEPENDS to fix the problem usually, but
dbus-test DEPENDS on dbus, so we can't do that, use INSANE_SKIP to fix
the problem.
(From OE-Core rev: 7bf27752cdfcb83a951086d6e5609593c79437c3)
(From OE-Core rev: e26e348d7b6301f0e1cb15018ebadfa0eea4013c)
Signed-off-by: Robert Yang <liezhi.yang@windriver.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
do_install should not access the sysroot directly. Add missing ${D}
reference.
(From OE-Core rev: 9e246629cf72ff240f56abd775d5412dae2af055)
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
For now, we would meet the following QA error if we build dbus-test in
the same build directory with multilib enabled/disabled.
The steps are as follows:
1. Enable multilib and `bitbake dbus-ptest'
2. Disable multilib and `bitbake dbus-ptest'
The error message is as follows:
ERROR: QA Issue: dbus-test: Files/directories were installed but not shipped
/usr/lib64
/usr/lib64/dbus-test
/usr/lib64/dbus-test/ptest
/usr/lib64/dbus-test/ptest/run-ptest
...
The problem is that the ${D} is not cleaned up at the second build while it
should be.
This patch fixes the above problem.
(From OE-Core rev: e76f8c0d79301b3c67029f18e5dd4325a39d4587)
Signed-off-by: Chen Qi <Qi.Chen@windriver.com>
Signed-off-by: Ross Burton <ross.burton@intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
If the system fetches dbus first, everything works and the checksum is
correct there. If dbus-test fetches first, the checksum is incorrect
and wasn't changed with the version upgrade.
Fix the checksum.
(From OE-Core rev: a5fc201961e62cf5d9088b6d66bb2d50aa84109d)
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
As this recipe's ptest support is merely a shim to pull in dbus-test-ptest it
doesn't inherit ptest. This means that PTEST_ENABLED isn't ever set, so check
DISTRO_FEATURES directly.
(From OE-Core rev: 7ee1da8126f1d4957e533cc26696e85c5a6de4bb)
Signed-off-by: Ross Burton <ross.burton@intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Remove obsolete_automake_macros.patch, since upstream has merged it.
(From OE-Core rev: 5873734b21735f9fb598c7d8e67ce8cef9ddb39c)
Signed-off-by: Chong Lu <Chong.Lu@windriver.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
We need use EXTRA_OECONF_append_class-native rather than
EXTRA_OECONF_class-native.
(From OE-Core rev: 5e1560b98680c79c979b8f9325f9f9997f9fd438)
Signed-off-by: Robert Yang <liezhi.yang@windriver.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Found this error on CentOS 5.10, other distros may also has this
problem, I think that we can disable the selinux for dbus-native:
bus/selinux.c:327: error: array type has incomplete element type
[YOCTO #6374]
(From OE-Core rev: 7a2d2d81d8694806060f7bccfbdba42dc356d477)
Signed-off-by: Robert Yang <liezhi.yang@windriver.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
