For reasons I can't explain gettext uses several hundred lines of convoluted m4
to find the paths to a library.
If we don't tell it where to find a library it will hunt around and potentially
have host contamination as /usr/lib on the host is explicitly searched.
If we tell it the prefix to a library then we get bad RPATHs in the binaries
(such as /usr/lib/../lib), and the search assumes that it knows best about what
the library directories are under that prefix (even when it's wrong).
So, replace the lookup where possible with pkg-config calls (libxml2, glib,
libcroco). libunistring doens't have a pkgconfig file so just don't use the
system libunistring: the library is tiny anyway.
(From OE-Core rev: 1ff35fbbdd50660b86f8e254685ae0c8338b6e11)
(From OE-Core rev: e6c0f8eddf8ff4a6132934a69e0f3450d4843ece)
Signed-off-by: Ross Burton <ross.burton@intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
gettext has optional dependencies on libxml2, glib, libcroco and libunistring.
If they're not available then gettext will use internal copies, but it can also
use system libraries.
For gettext-native and nativesdk-gettext continue to use the internal copies to
reduce the dependencies, but for target use the system shared libraries.
Also gettext 0.19.7 onwards swapped expat for libxm2, so remove the build
dependency on expat.
(From OE-Core rev: a82aa376a9229428ec25629e97a1efa56f0afae7)
Signed-off-by: Ross Burton <ross.burton@intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Now that epiphany needs a working msgfmt as well, let's do this trick
where it should be.
(From OE-Core rev: 7c0032b81f56fea5bec33aa0e74d6e28873f72a8)
Signed-off-by: Alexander Kanavin <alexander.kanavin@linux.intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
uclibc support was removed a while ago and musl works much better. Start to
remove the various overrides and patches related to uclibc which are no longer
needed.
uclibc support in a layer would still be possible. I have strong reasons to
believe nobody is still using uclibc since patches are missing and I doubt
the metadata even parses anymore.
(From OE-Core rev: 653704e9cf325cb494eb23facca19e9f05132ffd)
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
These are recipes where the upstream has moved to GPLv3 and these old
versions are the last ones under the GPLv2 license.
There are several reasons for making this move. There is a different
quality of service with these recipes in that they don't get security
fixes and upstream no longer care about them, in fact they're actively
hostile against people using old versions. The recipes tend to need a
different kind of maintenance to work with changes in the wider ecosystem
and there needs to be isolation between changes made in the v3 versions
and those in the v2 versions.
There are probably better ways to handle a "non-GPLv3" system but right
now having these in OE-Core makes them look like a first class citizen
when I believe they have potential for a variety of undesireable issues.
Moving them into a separate layer makes their different needs clearer, it
also makes it clear how many of these there are. Some are probably not
needed (e.g. mc), I also wonder whether some are useful (e.g. gmp)
since most things that use them are GPLv3 only already. Someone could
now more clearly see how to streamline the list of recipes here.
I'm proposing we mmove to this separate layer for 2.3 with its future
maintinership and testing to be determined in 2.4 and beyond.
(From OE-Core rev: 19b7e950346fb1dde6505c45236eba6cd9b33b4b)
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Fixed when compile with "-Wformat -Wformat-security -Werror=format-security":
| gettext-tools/gnulib-lib/libcroco/cr-statement.c: In function 'cr_statement_dump_charset':
| gettext-tools/gnulib-lib/libcroco/cr-statement.c:2661:17: error: format not a string literal and no format arguments [-Werror=format-security]
| fprintf (a_fp, str) ;
And:
gettext-tools/gnulib-lib/libxml/timsort.h:326:80: warning: format '%lu' expects argument of type 'long unsigned int', but argument 3 has type 'unsigned int' [-Wformat=]
fprintf(stderr, "Error allocating temporary storage for tim sort: need %lu bytes", sizeof(SORT_TYPE) * new_size);
[YOCTO #9544]
(From OE-Core rev: 41eb2da1b05515e3803a331686fa6ca763ae2e69)
Signed-off-by: Robert Yang <liezhi.yang@windriver.com>
Signed-off-by: Ross Burton <ross.burton@intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
This further aligns this recipe with the GPLv3 version to make
it easier to spot differences between the two recipes.
(From OE-Core rev: e25a533e8ca2fc1fa897df252830825cb9a5f028)
Signed-off-by: André Draszik <git@andred.net>
Signed-off-by: Ross Burton <ross.burton@intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
It doesn't look like we need any of those features, so
let's disable them explicitly.
(From OE-Core rev: 0a095473eec333f918ef831dea1c2f269a64fc62)
Signed-off-by: André Draszik <git@andred.net>
Signed-off-by: Ross Burton <ross.burton@intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
The option is called --with(out)-lispdir, not --with(out)-lisp
(From OE-Core rev: 422c92d2806f776252c15ec9fe204b204503c4d2)
Signed-off-by: André Draszik <git@andred.net>
Signed-off-by: Ross Burton <ross.burton@intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
gettext uses internal symbols to detect whether the
implementation is compatible with GNU gettext. However,
these symbols don't are not part of the public API, they
are specific to glibc.
While musl implements the GNU gettext *API* version 1 and 2
http://www.openwall.com/lists/musl/2015/04/16/3
it doesn't implement glibc internals. This means that
gettext fails to detect musl's working implementation.
More recent versions of gettext have changed the way
GNU gettext compatibility is done
https://lists.gnu.org/archive/html/bug-gettext/2016-04/msg00000.htmlhttp://git.savannah.gnu.org/cgit/gettext.git/commit/gettext-runtime/m4/gettext.m4?id=b67399b40bc5bf3165b09e6a095ec941d4b30a97
and while we could backport the corresponding patch to
gettext.m4, we avoid doing that so as to avoid any
potential GPL-v3 issues.
So instead we force ./configure to assume that the gettext
implementation of the c-library (musl) is compatible.
As a side-effect, this also reduces image sizes as the
internal gettext implementation isn't built anymore, and
it's otherwise packaged into the main gettext package
which blows up the image as the main gettext package
contains a lot of things.
Similarly, libintl.h isn't generated anymore, as the one
from musl is OK.
(From OE-Core rev: 948f0bd162f0b1b0375db884e99a2338f47e8527)
Signed-off-by: André Draszik <git@andred.net>
Signed-off-by: Ross Burton <ross.burton@intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
How to upgrade gettext-minimal-native:
- Build gettext-native
- Copy gettext-runtime/po/Makefile.in.in, build-aux/config.rpath and
gettext-runtime/po/remove-potcdate.sin from gettext-native.
- Update COPYING when needed (usually update the year), do not copy
the whole COPYING file from gettext-native.
- Go to gettext-native's ${S}/gettext-runtime/m4:
> Remove lt*.m4 and libtool.m4
> copy lib-ld.m4 lib-link.m4 lib-prefix.m4 from ${S}/gettext-runtime/gnulib-m4/
> tar czvf /path/to/aclocal.tgz *.m4
(From OE-Core rev: 2b82c24a6b0148d1cc548605eab9be85f356ab6d)
Signed-off-by: Robert Yang <liezhi.yang@windriver.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Do as the 0.19.6 version do, remove these files to avoid sysroot conflicts
with gettext-native-minimal.
[YOCTO #9890]
(From OE-Core rev: 65eb9b78e9e57a12db4f0053e35ad555a4c33029)
Signed-off-by: Chen Qi <Qi.Chen@windriver.com>
Signed-off-by: Ross Burton <ross.burton@intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Make gettext-native in 0.16.1 recipe provides virtual/gettext-native like
what gettext-native in 0.19.6 recipe does. Otherwise we would fail to start
to do a world build if gettext and gettext-native are set to the low version.
Error message is like below.
ERROR: Multiple versions of gettext-native are due to be built
(From OE-Core rev: a0bdbd8f38d8d2ca0687f4353b715087f946247a)
Signed-off-by: Chen Qi <Qi.Chen@windriver.com>
Signed-off-by: Ross Burton <ross.burton@intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Enforce the correct tag names across all of oe-core for consistency.
(From OE-Core rev: 606a43dc38a00cc243f933722db657aea4129f8e)
Signed-off-by: Ross Burton <ross.burton@intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
gettext installs a libtool .la file for non-glibc systems
since it builds libintl for them unlike glibc where it finds that using
libc's gettext implementation is just fine. Same is not true for
musl even though musl provides itw own gettext implementation much on
then lines of glibc.
ideally gettetxt should be fixed to behave on musl, but at this time its
not clear if APIs are same and complete.
Deleting .la file helps compiling packages like util-linux when using
fstack-protections since it does not alter the order of libc on linker
cmdline
Moved src_uri checksums just below the SRC_URI as matter of formatting
(From OE-Core rev: 83d31c874c58c9e98f1f99cbad1a583e65ed72e6)
Signed-off-by: Khem Raj <raj.khem@gmail.com>
Signed-off-by: Ross Burton <ross.burton@intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
This issue was triggered by buildpaths QA Warning.
...
|gettext-0.19.6: File work/core2-64-poky-linux/gettext/0.19.6-r0/
packages-split/gettext/usr/bin/msgcmp in package contained
reference to tmpdir
...
Previously, variable BISON_LOCALEDIR was assigned only by the
output of 'bison --print-localedir' which provided by native bison
that has buildpaths in it.
For target compile, we add option --with-bisonlocaledir to set
BISON_LOCALEDIR with "/usr/share/locale" to fix the QA issue.
The variable BISON_LOCALEDIR is used for internationalization of
the bison parser’s runtime output. Here is the introduction:
http://www.gnu.org/software/bison/manual/html_node/Internationalization.html
[YOCTO #7058]
(From OE-Core rev: aafb300a1f144b9ebda61a02fedd124fe0e1a83a)
Signed-off-by: Hongxu Jia <hongxu.jia@windriver.com>
Signed-off-by: Ross Burton <ross.burton@intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
libintl.h is already provided by musl and charset.alias is regenerated
by packages themselves
(From OE-Core rev: 25f91036e14392638e549d3d0b2914e93e6f4596)
Signed-off-by: Khem Raj <raj.khem@gmail.com>
Signed-off-by: Ross Burton <ross.burton@intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
gettext-error_print_progname.patch was originally created for gettext
v0.14.6 and does not apply cleanly to gettext v0.16.1.
Since the original issue addressed by the patch isn't documented and
because gettext v0.16.1 seems to be build OK for uclibc without the
patch, assume the patch is obsolete and no longer required.
(From OE-Core rev: d95d92a1f867caaa428685b72839a555c0ef83b4)
Signed-off-by: Andre McCurdy <armccurdy@gmail.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
The Makefile.in.in provided by gettext-minimal-native will be copied
to many packages that need gettext to produce multi-lingual messages.
Replace mkdir_p with MKDIR_P to fix below errors from those packages'
install logs:
/bin/sh: 6: @mkdir_p@: not found
/usr/bin/install: cannot create regular file 'xxx'
As automake manual:
From Automake 1.8 to 1.9.6 AM_PROG_MKDIR_P used to define the output
variable mkdir_p to one of mkdir -p, install-sh -d, or mkinstalldirs.
Nowadays Autoconf provides a similar functionality with AC_PROG_MKDIR_P,
it will set output variable MKDIR_P.
Automake manual advises to switch ASAP to the more modern Autoconf-provided
interface instead; both the macro and the variable have been removed from
Automake 1.12.1 and later releases.
Signe-off-by: Wenzong Fan <wenzong.fan@windriver.com>
(From OE-Core rev: f374ed441627ac833aab62c1189a16ea26a4933b)
Signed-off-by: Ross Burton <ross.burton@intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Disable the test "Test against HP-UX 11.11 bug: No converter from EUC-JP
to UTF-8 is provided" since we don't support HP-UX and if the euc-jp is
not installed on the host, the dependence will be built without iconv
support and will cause guile-native building fail.
The patch is similar as 0470bd7a9658d3[libunistring: remove the test to
convert euc-jp in configure]
(From OE-Core rev: c4a386556afaaab3fcbb7e96274ff36e5bdb4b62)
Signed-off-by: Roy Li <rongqing.li@windriver.com>
Signed-off-by: Ross Burton <ross.burton@intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* gettext:
- Update parallel.patch, we only need a part of it.
* gettext-minimal-native:
- Update related files from gettext-native.
- Remove Makevars.template, we didn't use it.
- Remove iconv-m4-remove-the-test-to-convert-euc-jp.patch (can be
reverse applied).
- Update the COPYING (1995 - 2014).
* About upgrade gettext-minimal-native (for future's upgrade):
- Build gettext-native
- Copy gettext-runtime/po/Makefile.in.in, build-aux/config.rpath and
gettext-runtime/po/remove-potcdate.sin from gettext-native.
- Update COPYING when needed (usually update the year), do not copy
the whole COPYING file from gettext-native.
- Go to gettext-native's ${S}/gettext-runtime/m4:
> Remove lt*.m4 and libtool.m4
> copy lib-ld.m4 lib-link.m4 lib-prefix.m4 from ${S}/gettext-runtime/m4/
> tar czvf /path/to/aclocal.tgz *.m4
(From OE-Core rev: cd91b748e83bd5c040538aecf76823549662b3c7)
Signed-off-by: Robert Yang <liezhi.yang@windriver.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
The class itself currently does nothing. The idea is to mark all recipes that
make use of the texinfo utilities. In the future, this class could be used to
suppress the generation/formatting of documentation for performance,
explicitly track dependencies on these utilities, and eliminate Yocto's
current dependency on the host system's texinfo utilities.
(From OE-Core rev: e6fb2f9afe2ba6b676c46d1eb297ca9cc532d405)
Signed-off-by: Max Eliaser <max.eliaser@intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Ever since the change to how aclocal files are copied (based on dependencies),
target m4 macros seem to more reliably be used in preference to native (which
they should), but in a non-gplv3 build, gettext is 0.16 while gettext-native is
0.18, causing a 0.16 po.m4 to be used with our 0.18 po/Makefile.in.in files,
causing at least some failed builds, including e2fsprogs.
Anyone inheriting gettext will have both gettext-native and gettext available,
and we don't want to use older macros from the target gettext in a non-gplv3
build, so kill them and let dependent recipes rely on gettext-native.
[YOCTO #5964]
(From OE-Core rev: f43139adceaf8039d5347dea0a116dc5923b24c1)
Signed-off-by: Christopher Larson <kergoth@gmail.com>
Signed-off-by: Saul Wold <sgw@linux.intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Remove the test "Test against HP-UX 11.11 bug: No converter from
EUC-JP to UTF-8 is provided" since we don't support HP-UX and it
causes guile-native compile failure if the euc-jp is not installed
on the host.
(From OE-Core rev: ac902d0fdf44beda2d0954cc477a4e2b177a2f2a)
Signed-off-by: Jackie Huang <jackie.huang@windriver.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Remove all PR = "r0" from all .bb files in oe-core. This was done
with the command sed -e '/^PR.*=.*r0\"/d' recipes*/*/*.bb -i
We've switching to the PR server, PR bumps are no longer needed and
this saves people either accidentally bumping them or forgetting to
remove the lines (r0 is the default anyway).
(From OE-Core rev: 58ae94f1b06d0e6234413dbf9869bde85f154c85)
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
According to the documentation, the only reason for needing ncurses is
to support colour output from msgcat. Make this optional so that
ncurses doesn't need to be built if colour output is not required.
(From OE-Core rev: a4040ad83984ee27fa9dc16d276c699d24b03b4e)
Signed-off-by: Phil Blundell <philb@gnu.org>
Signed-off-by: Saul Wold <sgw@linux.intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
uclibc specific patches are not needed now as they are
available in 0.18.2 gettext now
(From OE-Core rev: ab692ed618f83df2ce452769165314e70b867345)
Signed-off-by: Khem Raj <raj.khem@gmail.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
remove_gets.patch dropped as upstream now contains
fix for the problem.
(From OE-Core rev: 9e936c390006602c27df4c42ea2d9055881db098)
Signed-off-by: Marko Lindqvist <cazfi74@gmail.com>
Signed-off-by: Saul Wold <sgw@linux.intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
* now autotools.bbclass are copying not only Makefile.in.in but also
remove-potcdate.sin which is used by Makefile.in.in, so we need to
provide this file already in gettext-minimal-native otherwise build
can fail, when autotools.bbclass is used before gettext-native (full)
is built.
(From OE-Core rev: e60612a9fed96d92c5119ab3b26a355d152db1b8)
Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
Signed-off-by: Saul Wold <sgw@linux.intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
The overrides virtclass-native and virtclass-nativesdk are deprecated,
which should be replaced by class-native and class-nativesdk.
[YOCTO #3297]
(From OE-Core rev: 5193485a42dfb3396d0f12aaa7732c5db29d7338)
Signed-off-by: Robert Yang <liezhi.yang@windriver.com>
Signed-off-by: Saul Wold <sgw@linux.intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
We need gettext-minimal-native to be able to install config.rpath and
Makefile.in.in so that we don't get version mismatch errors when subsequently
using the reconfigured software.
This patch moves the two files to be provided by minimal-native so
that we can better 'gettextize' software without needing the full
gettext-native when using --disable-nls.
(From OE-Core rev: 6b12d4cd39bacb087654b59e25f5052a4e839b26)
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
These were added in aae5021101224344a2b1a3af5becf74291fbbfe5, ostensibly to resolve
some sort of "host contamination" issue. However, that commit contains no information
about what contamination was being observed or how the dependencies help.
gettext-native is being configured --with-included-libxml so it shouldn't be using
libxml2 from either the host or the sysroot, in which case the dependency would seem
to be useless. Using the included copy of libxml2 is in any case preferable to adding
a dependency on libxml2-native because the latter brings quite a large stack of other
dependencies with it.
(From OE-Core rev: 132d329638ae32b98c36b9498c470cf0ffdcedb3)
Signed-off-by: Phil Blundell <pb@pbcl.net>
Signed-off-by: Saul Wold <sgw@linux.intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
gettext 0.16.1 is a GPLv2 version of gettext. Making that extend native and
nativesdk makes sure we use the same version of gettext for compiling internally
as well as in our toolchain.
(From OE-Core rev: 6322a1b3680d2480c96433fde5a913b3bf2d09ea)
Signed-off-by: Martin Ertsaas <mertsas@cisco.com>
Signed-off-by: Saul Wold <sgw@linux.intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Erroneous paths being added to gettext by libtool were fixed, but the
fix in libtool did not trigger a recompile of gettext, so if you are
already in the situation where you are receiving the QA error, you are
stuck. Bump PR to force a recompile.
(From OE-Core rev: f9659be1eb65b36192af8e59c683be118b0e2f8d)
Signed-off-by: Paul Eggleton <paul.eggleton@linux.intel.com>
Signed-off-by: Saul Wold <sgw@linux.intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
gettext-0.18 gets a new option for acl, but we do not place acl
into DEPENDS.
So, explicitly disable acl for deterministic builds.
(From OE-Core rev: 96f5ea19f2b8ba396f92377b93a763af7b6109b6)
Signed-off-by: Xin Ouyang <Xin.Ouyang@windriver.com>
Signed-off-by: Saul Wold <sgw@linux.intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
These recipes use gnulib which needs this change to use gets
when its defined and not otherwise. Until that change goes into
gnulib and then all these package upgrade gnulib in their sourcebase
we patch them
(From OE-Core rev: 3148460575b65cb681065e5850b8afb96056d712)
Signed-off-by: Khem Raj <raj.khem@gmail.com>
Signed-off-by: Saul Wold <sgw@linux.intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
