Commit Graph

13 Commits

Author SHA1 Message Date
Joe Slater
5f0c4c785d rng-tools: modify 'read error' message
Expand messages output if entropy data cannot
be read.

(From OE-Core rev: 23cf9be2065d6ea01f6d10cbed64a590c31e5bfc)

Signed-off-by: Joe Slater <joe.slater@windriver.com>
Signed-off-by: Ross Burton <ross.burton@intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2018-02-06 11:06:27 +00:00
Richard Purdie
b3b7ee4097 rng-tools: Fix crazy defaults
Feeding the output of /dev/urandom into /dev/random is pretty much insane
and not something we should encourage.

I can't really imagine a scenario where this would be a sensible idea since
/dev/urandom if effectively derived from /dev/random.

This changes the tool to default to /dev/hwrng which makes much more sense,
feeding hardware entropy into the random pool. In the QEMU case, this will
feed entropy from the host into the guests which is also what we want.

Yes, this change will cause rngd not to start if /dev/hwrng isn't present,
but it isn't needed if that isn't so I don't see this as a bad thing.

(https://wiki.archlinux.org/index.php/Rng-tools has a section in red which
agrees with the above, "this is a really bad idea, since you are simple
filling the kernel entropy pool with entropy coming from the kernel itself!")

(From OE-Core rev: f1dc9ac46710814c27cae2d22e79c84a9522993a)

Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2017-11-05 13:40:33 +00:00
Dengke Du
b5fc88b3d3 rng-tools: add systemd service file
Add systemd service file for rng-tools.

(From OE-Core rev: d374897100ae756df72677d47c9c70c7fefca192)

Signed-off-by: Dengke Du <dengke.du@windriver.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2017-08-27 22:30:06 +01:00
Richard Purdie
a5bf271c7c meta: Add/fix missing Upstream-Status to patches
This adds or fixes the Upstream-Status for all remaining patches missing it
in OE-Core.

(From OE-Core rev: 563cab8e823c3fde8ae4785ceaf4d68a5d3e25df)

Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2017-06-27 10:38:43 +01:00
Ross Burton
81f9abc256 meta: Fix malformed Upstream-Status tags
Fix a variety of spelling and format mistakes to improve the ease of reading the
tags programatically.

(From OE-Core rev: 6e1aaf80b0d951b48cd25cb7161ec19448295094)

Signed-off-by: Ross Burton <ross.burton@intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2017-06-27 10:38:43 +01:00
Richard Purdie
eb40fcf627 meta: Drop remnants of uclibc support
uclibc support was removed a while ago and musl works much better. Start to
remove the various overrides and patches related to uclibc which are no longer
needed.

uclibc support in a layer would still be possible. I have strong reasons to
believe nobody is still using uclibc since patches are missing and I doubt
the metadata even parses anymore.

(From OE-Core rev: 653704e9cf325cb494eb23facca19e9f05132ffd)

Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2017-06-22 09:16:00 +01:00
Khem Raj
b28034878a rng-tools: Fix textrels on 32bit x86
When testing core-image-sato with hardening flags, it fails with
SIGSEGV in libc.so during relocation time

This is due to relocations in .text [textrel]
build QA points it out clearly during qemux86 build as well

AssertionError: 2 != 0 : Log: /mnt/a/oe/build/tmp/work/qemux86-bec-linux-musl/core-image-sato/1.0-r0/dmesg_output.log
-----------------------
Central error: [   19.043597] rngd[525]: segfault at 80098bb7 ip b77b14fc sp bfe9b380 error 7 in libc.so[b774c000+97000]

(From OE-Core rev: 5770cd5bee1c9ad3025435426361f0e407d43ef8)

Signed-off-by: Khem Raj <raj.khem@gmail.com>
Signed-off-by: Ross Burton <ross.burton@intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2017-06-12 15:08:31 +01:00
Alexander Kanavin
5fcb74f7d9 rng-tools: use SOURCEFORGE_MIRROR in SRC_URI
This also fixes upstream version check.

(From OE-Core rev: 60732e6b916c1371fe02a27a4959808ce3828d83)

Signed-off-by: Alexander Kanavin <alexander.kanavin@linux.intel.com>
Signed-off-by: Ross Burton <ross.burton@intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2016-11-30 15:48:09 +00:00
Aníbal Limón
d492aec2c2 recipes-support/rng-tools: Change runlevel start from S to 2, 3, 4, 5.
When using systemd as init rng-tools is causing a circular dependency
between units,

	[    7.706250] systemd[1]: basic.target: Found ordering cycle on
	basic.target/start
	[    7.706934] systemd[1]: basic.target: Found dependency on
	sysinit.target/start
	[    7.707795] systemd[1]: basic.target: Found dependency on
	rng-tools.service/start
	[    7.708692] systemd[1]: basic.target: Found dependency on
	basic.target/start
	[    7.709461] systemd[1]: basic.target: Breaking ordering cycle by
	deleting job rng-tools.service/start
	[    7.710404] systemd[1]: rng-tools.service: Job rng-tools.service/start
	deleted to break ordering cycle starting with basic.target/start

The problem is related to systemd running sysvinit scripts by default
add dependency of basic.target for sysvinit script so when sysvscript
is at rcS is added also as dependency of sysinit.target causing a
cirular dependency in this case: basic.target -> sysinit.target ->
rng-tools.service -> basic.target.

(From OE-Core rev: e3fc8ef152494e9b7cff8de110a784150295f17e)

Signed-off-by: Aníbal Limón <anibal.limon@linux.intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2016-03-31 09:15:05 +01:00
Maxin B. John
6c8abead0f uclibc support for rng-tools
Uclibc has its own argp implemented as libuargp. So, we add a new
option --enable-uclibc to select it.

(From OE-Core rev: 0bbbc0b377e4fd9a788f5aa7688afa5516e263dd)

Signed-off-by: Maxin B. John <maxin.john@intel.com>
Signed-off-by: Ross Burton <ross.burton@intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2016-02-28 11:33:06 +00:00
Richard Purdie
683ea31ac7 rng-tools: Fix underquoted m4 and libgcrypt floating dependency
The underquoted m4 caused build failures if libgcrypt wasn't present. The floating
dependency on libgcrypt was just plain incorrect, particularly given the incorrect
libgcrypt RDEPENDS. Change to use PACKAGECONFIG an default to on.

(From OE-Core rev: 17b3044d7508a921916da4979ff8bfbab1e206ce)

Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2016-02-16 23:50:48 +00:00
Christopher Larson
11359e9d5d rng-tools: fix the build with musl
musl doesn't provide argp, so we need argp-standalone, as we do for uclibc.
Rather than passing in -largp via the recipe, patch the configure script to
provide an argument for the libargp usage and check for it when needed, and
use PACKAGECONFIG. The initial patch to check for libargp and use it if
available came from Gentoo. The patches are kept separate despite the second
modifying what the first does, in order to keep the history/origin clear.

(From OE-Core rev: 94ecc846f9b33fcec039936643c49728eedfefb7)

Signed-off-by: Christopher Larson <chris_larson@mentor.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2016-02-16 11:15:49 +00:00
Saul Wold
ce3df21122 rng-tools: Import recipe from meta-openembedded
Adding this recipe to oe-core will allow it to be used by qemu to
provide a way to generate additional entropy needed to fix hangs
with getrandom().

Additional kernel config options have already been added to the
default qemu kernel configs.

[YOCTO #8681]
[YOCOT #8816]

(From OE-Core rev: 030bc0b2f9636f5cacef29c939b323569cd5673f)

Signed-off-by: Saul Wold <sgw@linux.intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2016-02-15 16:28:43 +00:00