Changelog:
aea9f42 ptest_list_remove: Fix pointer adjustment of prev and next
(From OE-Core rev: edb7968fe272e6afd89b01471f7949ccf730f295)
Signed-off-by: Jörg Sommer <joerg.sommer@navimatix.de>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
(cherry picked from commit f70ec9bcd379b5fc4c85d7479d42789c2e22f4a9)
Signed-off-by: Steve Sakoman <steve@sakoman.com>
Pull small fixed related to secure builds, handling of rc in every ptest
and better tests output when timeout.
Changes,
92c1b97 Do not reset error counter before each test
7de7e2b utils: run_child fix security flags build
6a9fba2 utils.c: get_available_ptests fix security flags compilation
5b8ad9a tests: Ensure that timeouts still print ERROR
d939217 SECURITY.md: Add file
(From OE-Core rev: 1d8a8487d300332c796a7555644bb370fc858f6f)
Signed-off-by: Anibal Limon <anibal@limonsoftware.com>
Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Now that SRCPV isn't needed we can simplify things in a few places...
(From OE-Core rev: 843f82a246a535c353e08072f252d1dc78217872)
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Pull in the commits:
Flush stdout and stderr after test
Remove _child_reader singleton
Report test failure on timeout
Only collect system state on timeout
Revert "Change test timeout to be total elapsed time"
Change test timeout to be total elapsed time
Report if child dies from a signal
Recreate pipe for each test
Revert "runner: Correctly handle running parallel tests"
runner: Correctly handle running parallel tests
(From OE-Core rev: 8de47e5f3837a9c87c3cbf8dc45f9e90110eda1e)
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
This fix simplifies the code to drop the pthread and mutexs which should
address some of the buffering issues we were seeing in some test case
failures.
(From OE-Core rev: bffa6d381d7ea0a6aad19d61cd973c82aadef070)
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Currently the code can race as there is a read/write thread handling the stdio but
there is no guarantee that when the process exits, the thread has handled all the
data. This results in output where "END:" isn't actually at the end of the logs
but somewhere in the middle of the output.
Update to a revision with this fix.
(From OE-Core rev: 6608ee551ed7e8864cdeabfb09832621313d3191)
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Pulls in:
utils: Ensure buffers are flushed after child exits
We currently wait for the child to exit but we don't flush the buffers.
This can mean the output ends up out of sync and the END: line isn't at
the end of the logs.
We've recently seen a lot of issues related to this on the autobuilder.
Add in a flush call for all fds to ensure buffers are in sync. This
does appear to improve warnings on the autobuilder now we started detecting
the issue.
(From OE-Core rev: f051de5d5da7e9a2f4137013e24589b594ff6d35)
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
The recommendation from server maintainers is that the https protocol
is both faster and more reliable than the dedicated git protocol at this point.
Switch to it where possible.
(From OE-Core rev: 139102a73d4151f4748b4a861bd4ab28dda7dab7)
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Some tests really don't want to be run as root, either because they
expect to get "permission denied" errors occasionally, or have explicit
checks.
Instead of numerous recipes re-inventing user creation in run-ptest,
create a user in the ptest-runner recipe that they can all use.
(From OE-Core rev: d58cf08421e0f89840820370dd3c5b6e153efcbb)
Signed-off-by: Ross Burton <ross.burton@arm.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
An automated conversion using scripts/contrib/convert-spdx-licenses.py to
convert to use the standard SPDX license identifiers. Two recipes in meta-selftest
were not converted as they're that way specifically for testing. A change in
linux-firmware was also skipped and may need a more manual tweak.
(From OE-Core rev: ceda3238cdbf1beb216ae9ddb242470d5dfc25e0)
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
There is uncertainty about the default branch name in git going forward.
To try and cover the different possible outcomes, add branch names to all
git:// and gitsm:// SRC_URI entries.
This update was made with the script added to contrib in this patch which
aims to help others convert other layers.
(From OE-Core rev: b51c405faf6f8c0365f7533bfaf470d79152a463)
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
When ptest-runner times out or otherwise fails, it tries to
call ptest-runner-collect-system-data, so install the script.
The script currently calls dmesg, df, free (which are provided
by busybox, etc.) and pstree (which is a sub-package of psmisc).
Add pstree as an RDEPENDS.
(From OE-Core rev: 4e6be3fb521b23cfc175d0c09725bcc3ebbc73b2)
Signed-off-by: Tim Orling <timothy.t.orling@intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Changes,
bcb8280 utils.c: add system data collection when a test gets stuck.
c29240c utils.c: handle test timeouts directly with poll()
d6f509f tests/utils.c: fix a memory corruption in find_word
c10e747 main: Do not return number of failed tests when calling ptest-runner
4958988 utils.c: fix memory leak in run_ptests()
fcfa6a1 clang: clean-ups to avoid -Weverything warnings.
215e52d Makefile: allow using CC env var to pick compiler
fdd233d mem: Simplify memory management
e5e218a mem: Fix memleak for ptest_opts
0dc42eb git: Extend the gitignore
(From OE-Core rev: 710fa373375beb977af704e17a925ed41c9a858d)
Signed-off-by: Aníbal Limón <anibal.limon@linaro.org>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
This is the result of automated script conversion:
scripts/contrib/convert-overrides.py <oe-core directory>
converting the metadata to use ":" as the override character instead of "_".
(From OE-Core rev: 42344347be29f0997cc2f7636d9603b1fe1875ae)
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
This only affects glibc systems and have been
found on runqemu core-image-minimal with gstreamer ptest-runner
STOP: ptest-runner
libgcc_s.so.1 must be installed for pthread_cancel to work
Aborted
(From OE-Core rev: 1cb679e6a4528a2cef16f65342d5e65adb14cb16)
Signed-off-by: Jose Quaresma <quaresma.jose@gmail.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Changes:
cce0edb utils.c: wait_child reimplement timeout using alarm
acbba90 utils.c: Use a thread to read from child
cb2840a utils.c: Fix exit status of a child
77bc79e utils.c: get_available_ptests allow to specify relative directories
d27e242 README.md: Small fix mtrace call
c5d5831 tests/utils.c: Add braces in START_TEST/END_TEST now required in check 0.15.x
(From OE-Core rev: e3fd8f17dfb41173dbe037c25087a69f90b1346f)
Signed-off-by: Aníbal Limón <anibal.limon@linaro.org>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
The license headers are clear that the code is "or later", fix LICENSE
to match.
(From OE-Core rev: 5f0b5cdfcb104ac50222a47652e090ad8770e49f)
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Add support for un ptests in multiple directories, useful in multilib
builds.
Changes,
1e9a845 Add support to specify multiple folder for ptest-runner
287ba30 Makefile: Fix TEST_LDFLAGS gcc cmdline position
[YOCTO #12604]
(From OE-Core rev: 1203ee86e3cf4d73f6ba513452717f1c4f78c501)
Signed-off-by: Aníbal Limón <anibal.limon@linaro.org>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
All local patches are now upstream so they have been dropped.
Other upstream commits make ptest-runner build using: clang -Weverything
$ git log --oneline b73bd54..7015e91
7015e91 (HEAD -> oe-core-master, tag: v2.3.2, origin/master, origin/HEAD, master) Fix additional warnings when using clang
dd1daa8 tests: fix clang warnings.
15fd131 main code: fix clang warnings
59381a6 utils: ensure child can be session leader
5fe2c0a utils: Ensure pipes are read after exit
79a9c27 use process groups when spawning
b73bd54 utils: Ensure stdout/stderr are flushed
(From OE-Core rev: 9a80a352a9d0c4ea09de7bb370267672c32771f2)
Signed-off-by: Randy MacLeod <Randy.MacLeod@windriver.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
When running the run-execscript bash ptest as a user rather than root, a warning:
bash: cannot set terminal process group (16036): Inappropriate ioctl for device
bash: no job control in this shell
contaminates the bash log files causing the test to fail. This happens only
when run under ptest-runner and not when interactively testing!
The changes made to fix this include:
1. Get the process group id (pgid) before forking,
2. Set the pgid in both the parent and child to avoid a race,
3. Find, open and set permission on the child tty, and
4. Allow the child to attach to controlling tty.
(From OE-Core rev: 83795a83505a311058130c662ff3342b0e39e67f)
Signed-off-by: Randy MacLeod <Randy.MacLeod@windriver.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
63d097c Add SPDX-License-Identifier: GPL-2.0-or-later in source files (HEAD)
fb93c99 utils.c: close all file descriptors after completing a ptest
(From OE-Core rev: 4115805fb4ff47fc794651ca59c858f91fe26fc7)
Signed-off-by: Sakib Sajal <sakib.sajal@windriver.com>
Signed-off-by: Randy Macleod <randy.macleod@windriver.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
This change adds three patches to improve the handling of stdout/stderr and child
processes to try and improve logging reliability in ptest-runner.
(From OE-Core rev: 1c0fffc401cdb581a93d16d225f53c83359ff209)
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Changeset,
05b112b utils.c: Print DURATION after ERROR
acb5efb utils.c: run_child redirect stderr to stdout
e1062f7 ptest-runner: make DEFAULT_DIRECTORY be able to be defined when compiling
(From OE-Core rev: f0b3fa049e0395ffc56237404f79975852ce4e4e)
Signed-off-by: Aníbal Limón <anibal.limon@linaro.org>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Ptest data are installed to PTEST_PATH ?= "${libdir}/${BPN}/ptest".
When libdir isn't "/usr/lib", it will cause "No ptests found" error
when running "ptest-runner" command. Here pass libdir to
DEFAULT_DIRECTORY when compiling to avoid that error.
Need update ptest-runner source code to get the new commit:
<ptest-runner: make DEFAULT_DIRECTORY be able to be defined when compiling>
(From OE-Core rev: 1447afd62035f42344a32a487bec408e6563d5f6)
Signed-off-by: Li Zhou <li.zhou@windriver.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
The new version contains an option to exclude certain tests to
run, example:
$ ptest-runner -e "perl"
(From OE-Core rev: e529b8a68741992a21be874b62c0ea37f51d6a19)
Signed-off-by: Aníbal Limón <anibal.limon@linaro.org>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
The ptest-runner would segfault with -t option:
root@qemux86-64:~# ptest-runner -d /usr/lib test_pkg -t 5
[ 237.234112] ptest-runner[810]: segfault at 0 ip 000000382e638060 sp
00007fff9130f400 error 4 in libc-2.26.so[382e600000+1a7000]
It is safe to bump SRCREV to latest upstream commit to fix this issue
because there is only one commit since the last update:
commit 8a93832dad621535e90aa8e1fb74ae5ba743fc3e
Author: Anders Wallin <wallinux@gmail.com>
Date: Sun May 28 11:47:00 2017 +0200
timeout option missing the argument option ":" to getopt
ptest-runner -t xx gives segfault
Signed-off-by: Anders Wallin <wallinux@gmail.com>
Signed-off-by: Aníbal Limón <anibal.limon@linux.intel.com>
(From OE-Core rev: 503ce98bb89dfa019faff872121c8911e6465b05)
Signed-off-by: Yi Zhao <yi.zhao@windriver.com>
Signed-off-by: Ross Burton <ross.burton@intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
To fix a problem when print ERROR after a ptest timeout, this
causes the user confusion about if a test ends or not.
[YOCTO #10842]
(From OE-Core rev: 210c518ba8f8d6ec6e9d34e0df8b963a3b2e0593)
Signed-off-by: Aníbal Limón <anibal.limon@linux.intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
A minor fix has been published regarding the need of a user
of being noticed when some run-ptest script fails.
Also Found modifications to ptest unit test stuff
* removed unnecessary code from unit test run_timeout_ptest
* added test case for run_ptest failure
Finally..
New content within contributions section of README.md.
[YOCTO #9752]
(From OE-Core rev: 94030ce3322b51d20c7d4a35381c053a4d765ae0)
Signed-off-by: Edwin Plauchu <edwin.plauchu.camacho@linux.intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
The ${WORKDIR}/git refers to the source folder S which is different in
the case of an external source build.
(From OE-Core rev: fd4f4264a99cb0f8d20e3d87f66102d99cb5b6ad)
Signed-off-by: Christian Schuler <schuler.christian@siemens.com>
Signed-off-by: Pascal Bach <pascal.bach@siemens.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Since ptest-runner is a Yocto Project tool is better to have hosted
into git.yoctoproject.org.
(From OE-Core rev: 2fa1e9b3ebf3abb2b0b49ba1404e4f18483695d9)
Signed-off-by: Aníbal Limón <anibal.limon@linux.intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
This recipe currently relies on EXTRA_OEMAKE having been set to
"-e MAKEFLAGS=" in bitbake.conf to operate. It is necessary to make this
explicit so that the default in bitbake.conf can be changed.
(From OE-Core rev: 8092aa8ff63d9b2016bff138ec05ceb0d0155869)
Signed-off-by: Mike Crowe <mac@mcrowe.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
The ptest-runner 2.0 is C written program for run ptests of
Yocto/Openembedded, is fully compatible with previous version of
ptest-runner that was a shell script that runs ptests sequencially.
The mainly reason for the new ptest-runner in C is because is designed
for run in tiny systems also the old shell script version have problems
when certain ptest hang it becomes blocked indefinitely.
Now the ptest-runner 2.0 support the next features:
- Specify the directory for search ptests.
- List available ptests.
- Specify the timeout for avoid blocking indefinetly.
- Only run certain ptests.
Proposed features:
- Adds support for per ptest output file.
- Adds support for run ptests in parallel (review possible
colisions in ptests).
[YOCTO #8021]
(From OE-Core rev: 2a6746cb5e60c9c5477d1df062bb2657d2fe4780)
Signed-off-by: Aníbal Limón <anibal.limon@linux.intel.com>
Signed-off-by: Ross Burton <ross.burton@intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
By default ptest-runner executes all ptests found in a system.
With this change, ptest-runner can be given a list of ptest
package names to run (the default is still available).
For example, to run only the zlib and rt-tests ptests:
"ptest-runner zlib rt-tests"
(From OE-Core rev: a13333c3e9ab601a11c10aba2a0a55c7fdea2e24)
Signed-off-by: Ioan-Adrian Ratiu <adrian.ratiu@ni.com>
Signed-off-by: Ross Burton <ross.burton@intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
After removal of auto-creating S we must ensure that all recipes are
using a proper value for S.
Fix all recipes that only need to set S equals to WORKDIR.
[YOCTO #5627]
(From OE-Core rev: 9d220b1bfe4589736604dd5a7129e3699377d830)
Signed-off-by: Petter Mabäcker <petter@technux.se>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
It is better to know this information from the exit code rather than parsing
test specific outputs.
(From OE-Core rev: d6b1c9e7e29aaa8d71ccb485b7a88863a117a8b1)
Signed-off-by: Laszlo Papp <lpapp@kde.org>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Do not use pushd, busybox does not support it if system only has busybox;
Replace find command with ls to avoid some busybox's find unsupported options;
(From OE-Core rev: 1f059654bc81e55896c96c7c8e32e09f8925a761)
Signed-off-by: Roy Li <rongqing.li@windriver.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
1. ptest files may be installed under /usr/lib64/ for 64bit filesystem
or under /usr/lib/ for 64bit multilib filesystem, so we should check both
directories
2. If a soft link is linking to a directory under the same directory, we
only run once.
[YOCTO #5125]
[YOCTO #5126]
(From OE-Core rev: 51c43e08b388ed15520c66977bbb49df18e5f124)
Signed-off-by: Roy Li <rongqing.li@windriver.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
This package contains a simple shell script which searches for all installed
ptests on the rootfs and runs each test in sequence.
(From OE-Core rev: da25002a0968c12f16719f9fed21c76b9321aeb5)
Signed-off-by: Björn Stenberg <bjst@enea.com>
Signed-off-by: Saul Wold <sgw@linux.intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
