Commit Graph

17 Commits

Author SHA1 Message Date
Adrian Freihofer
ea119eaa46 expect: fix native build with GCC 15
This does not work for native builds:
  CFLAGS += "-std=gnu17"
The line from native.bbclass gets priority:
  CFLAGS = "${BUILD_CFLAGS}"

From bitbake-getvar -r expect-native CFLAGS
  ...
  append ...poky/meta/recipes-devtools/expect/expect_5.45.4.bb:44
     "-std=gnu17"
  set ...poky/meta/classes-recipe/native.bbclass:44
     "${BUILD_CFLAGS}"
  ...

(From OE-Core rev: 2696c50af9946f425ccaf7d0e7e0eb3fd87c36bb)

Signed-off-by: Adrian Freihofer <adrian.freihofer@siemens.com>
Signed-off-by: Steve Sakoman <steve@sakoman.com>
2025-10-09 12:16:46 -07:00
Khem Raj
ddda72f2bd expect: Fix build with GCC 15
Stick to C17 standard as GCC 15 switches to C23

(From OE-Core rev: a1ac756f2f55c4f27a95cb8b1e63ee2db06dd327)

Signed-off-by: Khem Raj <raj.khem@gmail.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Signed-off-by: Steve Sakoman <steve@sakoman.com>
2025-10-09 12:16:46 -07:00
Ross Burton
b95695a302 expect: cleanup do_install
Clean up the do_install append, and remove a long-standing unused
variable that appears to be intending to not install the scripts but
would have never actually done that as the relevant override since 2008
has been task-install.  As we've been installing the scripts, keep
instaling them.

(From OE-Core rev: 10a501b3bfe8f73ce2eb15673900df71e547b54d)

Signed-off-by: Ross Burton <ross.burton@arm.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Signed-off-by: Steve Sakoman <steve@sakoman.com>
2025-10-09 12:16:46 -07:00
Ross Burton
e49d690cf1 expect: don't run aclocal in do_configure
expect has a hand-maintained aclocal.m4 so don't run aclocal, which has the
side effect of not deleting the aclocal.m4 file which pulls in macros.

The build works without this change more through luck and a combination
of behaviours than design.

(From OE-Core rev: 61dbfd66210b090ec8abfbf1f4688e5691299d68)

Signed-off-by: Ross Burton <ross.burton@arm.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Signed-off-by: Steve Sakoman <steve@sakoman.com>
2025-10-09 12:16:46 -07:00
Ross Burton
357a4beab6 expect: update code for Tcl channel implementation
Tcl 8.4.0 changed the channel implementation, take a patch submitted
upstream to update the code for the new interface and remove the silencing
of the incompatible assignment error which was due to this issue.

(From OE-Core rev: 20cadf7b66f30e8a3b409b4a96eced614ac21013)

Signed-off-by: Ross Burton <ross.burton@arm.com>
Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Signed-off-by: Steve Sakoman <steve@sakoman.com>
2025-10-09 12:16:46 -07:00
Adrian Freihofer
c8a81cd75f expect: Revert "expect-native: fix do_compile failure with gcc-14"
In the meantime there is a cleaner fix on the master branch and we also
need to back-port more patches to support gcc-15 as well.

This reverts commit 8bfdb53247 which is
not in the master branch as a preparation for cherry-picking the newer
fixes from there.

(From OE-Core rev: 4ea89ba363228aa5e16412f85644608f4c645d5f)

Signed-off-by: Adrian Freihofer <adrian.freihofer@siemens.com>
Signed-off-by: Steve Sakoman <steve@sakoman.com>
2025-10-09 12:16:45 -07:00
Changqing Li
8bfdb53247 expect-native: fix do_compile failure with gcc-14
In native.bbclass, CFLAGS is overrided by 'CFLAGS = "${BUILD_CFLAGS}"',
this make "CFLAGS +=" not work for expect-native, use append to make it
also work for native.

(From OE-Core rev: 6974c6548cae62529d96d4ceb3a296707d4adae5)

Signed-off-by: Changqing Li <changqing.li@windriver.com>
Signed-off-by: Steve Sakoman <steve@sakoman.com>
2024-09-03 05:39:12 -07:00
Ross Burton
3b11fd8602 expect: fix configure with GCC 14
The configure script has many fragments that fail to compile with GCC 14,
take a patch submitted upstream to fix these issues.

(From OE-Core rev: 5c6630e61ad85a4bf9eecd94005e14f0e34df463)

Signed-off-by: Ross Burton <ross.burton@arm.com>
Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
(cherry picked from commit 5c21ca789c288662aa3d307b30813cd03cc8c158)
Signed-off-by: Steve Sakoman <steve@sakoman.com>
2024-07-03 06:28:37 -07:00
Martin Jansa
59c0bbcdb9 expect: ignore various issues now fatal with gcc-14
(From OE-Core rev: 454c48eac61f8e690b148e1c598aeb25912b1ec9)

Signed-off-by: Martin Jansa <martin.jansa@gmail.com>
Signed-off-by: Khem Raj <raj.khem@gmail.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
(cherry picked from commit 83e9790fe27c310a4f5a66fedb29b232d23a22e5)
Signed-off-by: Steve Sakoman <steve@sakoman.com>
2024-06-20 06:29:43 -07:00
Chi Xu
a0998bf22b expect: Add ptest support
Test results:
root@qemux86-64:~# ptest-runner expect
START: ptest-runner
2023-05-17T01:25
BEGIN: /usr/lib64/expect/ptest
via send_stdout
PASS: cat-1.1
PASS: expect-1.1
PASS: expect-1.2
PASS: expect-1.3
PASS: expect-1.4
PASS: expect-1.5
PASS: expect-1.6
PASS: expect-1.7
PASS: expect-1.10
PASS: expect-1.11
PASS: expect-1.12
PASS: expect-1.13
PASS: expect-1.8
PASS: expect-1.8b
PASS: expect-1.9
PASS: logfile-1.1
PASS: pid-1.2
PASS: pid-1.3
PASS: pid-1.4
PASS: pid-1.5
PASS: send-1.1
PASS: send-1.2
PASS: spawn-1.1
PASS: spawn-1.2
PASS: spawn-1.3
PASS: spawn-1.4
PASS: spawn-1.5
PASS: stty-1.1
PASS: stty-1.2
DURATION: 17
END: /usr/lib64/expect/ptest
2023-05-17T01:26
STOP: ptest-runner
TOTAL: 1 FAIL: 0

(From OE-Core rev: 13711656b1470e9d440bcf83e9fc9dc7ab2292f9)

Signed-off-by: Chi Xu <chi.xu@windriver.com>
Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2023-05-22 10:53:49 +01:00
Khem Raj
7dc5a703fb expect: Fix implicit-function-declaration warnings
(From OE-Core rev: 06ca0b74e5856890a55be15b5061280cbab43d79)

Signed-off-by: Khem Raj <raj.khem@gmail.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2022-08-17 19:57:32 +01:00
Joe Slater
7f736a56e9 expect: modify fixline1 script
fixline1 needs to be processed by fixline1, but we
short-circuit that.  Enter the multi-line shebang which
I am a bit queasy about, but expect loves it.

(From OE-Core rev: 0829d4f2947be2b095e7e713b5100f4e41218bec)

Signed-off-by: Joe Slater <joe.slater@windriver.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2022-03-16 13:39:12 +00:00
Alexander Kanavin
e7ab3d8c82 expect: do not install examples, drop related patch
There is really no reason to install them; this was done
in the original recipe submission for unexplained reasons.

(From OE-Core rev: 34f07b88167e0ee6499efbc53142ba0a8dcc3117)

Signed-off-by: Alexander Kanavin <alex@linutronix.de>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2021-11-21 11:05:02 +00:00
Richard Purdie
bb6ddc3691 Convert to new override syntax
This is the result of automated script conversion:

scripts/contrib/convert-overrides.py <oe-core directory>

converting the metadata to use ":" as the override character instead of "_".

(From OE-Core rev: 42344347be29f0997cc2f7636d9603b1fe1875ae)

Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2021-08-02 15:44:10 +01:00
Robert Yang
b6e5346f46 expect: Fix buffer overflow error when build in long path
Fixed when built the project in a long path (len(TMPDIR) > 200):
$ bitbake dejagnu-native
[snip]
checking Tcl version 8.5 or greater... *** buffer overflow detected ***:
TOPDIR/tmp-glibc/work/x86_64-linux/dejagnu-native/1.6.2-r0/recipe-sysroot-native/usr/bin/expect terminated
[snip]

(From OE-Core rev: c8d0bf3411846bb3852bffaf59193801d9c7530a)

Signed-off-by: Robert Yang <liezhi.yang@windriver.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2019-09-27 13:02:16 +01:00
Robert Yang
fe8d87e083 expect: Fix configure error for nativesdk
Fixed:
$ bitbake nativesdk-expect
checking for Tcl public headers... configure: error: tcl.h not found.  Please specify its location with --with-tclinclude

(From OE-Core rev: bd8ba628b0ff1ad3603b08981467edf5e36ec024)

Signed-off-by: Robert Yang <liezhi.yang@windriver.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2019-09-27 13:02:16 +01:00
Alexander Kanavin
26227695b3 expect: upgrade 5.45.3 -> 5.45.4
(From OE-Core rev: 064900f87a179a1e5b37dfc9313baab6351e7875)

Signed-off-by: Alexander Kanavin <alexander.kanavin@linux.intel.com>
Signed-off-by: Ross Burton <ross.burton@intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
2018-03-06 06:43:10 -08:00