Every selftest run is currently polluting the autobuilder DL_DIR. Avoid
this by using a temporary directory for the test which is cleaned up.
(From OE-Core rev: 002d321e02b3ce4f34c8a54211b109a5416c8a0e)
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
This bug has plagued the autobuilder for a couple of years and we've
struggled to reproduce/debug it.
The problem is the "lib" directory in meta-poky used during the load_plugin
tests for recipetool and devtool can race and one can delete the files
from the other leading to test failures.
Deleting the lib directory only if empty will avoid this.
[YOCTO #13070]
(From OE-Core rev: d603e2fd589e1edbc67c8c2fefb6337e728b9d01)
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
list-packageconfig-flags.py determines the whitespace numbers according
to the longest package name. This is reasonable for the tool as it's
trying to generate pretty output.
However, in this selftest case, the output is hardcoded. This results in
"pinentry gtk2 libcap ncurses qt secret" not recognized
as correct as the expected line is:
"pinentry gtk2 libcap ncurses qt secret".
The difference is only about whitespaces. So we should ignore the whitespaces
when comparing lines.
(From OE-Core rev: 17c89ad1596dbc7cefdd2c01dcd95aa9e93c5dc6)
Signed-off-by: Chen Qi <Qi.Chen@windriver.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
If oe-selftest is run without -j, the separate build directory "build-st"
isn't cleaned up afterwards. Mirror the behaviour of the -j option to
handle this the same way, only preserve upon failure.
To do this, the remove function needs to be moved to the selftest
context module so that it can be accessed without requiring the
testtools and subunit modules the -j option requires.
A dummy wrapper class is used to wrap the tests and clean up afterwards.
[YOCTO #13953]
(From OE-Core rev: 1b376ade430d40d3cfe9c18f200c764d622710e5)
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
We'd like to use buildhistory more during patch review however its
proving hard, particularly where whole subtrees of files move,
such as a kernel version upgrade, or where a software module moves
include directory.
This adds file rename matching which covers our common case of library
moves, kernel upgrades and more.
A new test case is also added so that someone in the future can change
the code and test the logic is still doing the expected things.
(From OE-Core rev: 791ce304f5e066759874beac0feef5ee62a1c255)
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
467f84e12b ("wic: Add --offset argument for partitions") broke the
--extra-space argument handling in wic. Fix the option and add a unit
test for the argument.
(From OE-Core rev: 87722a92c18f94917c8f70afc8cd0763462a5c25)
Signed-off-by: Joshua Watt <JPEWhacker@gmail.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
When running tests locally without the advantage of a populated sstate
cache, the archiver tests can take an unnecessarily long time. Using
different target recipes can speed things up a lot by reducing the
number of dependencies that are built.
For the test case test_archiver_srpm_mode we can still test the
conditions described in bug #11121 by using a target recipe that is
known to inherit the nopackages class as well as a more normal recipe,
instead of having to compute all the depepndencies of core-image-sato.
Before:
archiver.Archiver.test_archiver_allows_to_filter_on_recipe_name: PASSED (20.50s)
archiver.Archiver.test_archiver_filters_by_type: PASSED (14.16s)
archiver.Archiver.test_archiver_filters_by_type_and_name: PASSED (79.08s)
archiver.Archiver.test_archiver_mode_configured: PASSED (558.19s)
archiver.Archiver.test_archiver_mode_diff: PASSED (14.59s)
archiver.Archiver.test_archiver_mode_dumpdata: PASSED (14.41s)
archiver.Archiver.test_archiver_mode_mirror: PASSED (14.02s)
archiver.Archiver.test_archiver_mode_mirror_combined: PASSED (19.99s)
archiver.Archiver.test_archiver_mode_mirror_excludes: PASSED (14.24s)
archiver.Archiver.test_archiver_mode_mirror_gitsm: PASSED (13.47s)
archiver.Archiver.test_archiver_mode_mirror_gitsm_shallow: PASSED (22.15s)
archiver.Archiver.test_archiver_mode_original: PASSED (14.15s)
archiver.Archiver.test_archiver_mode_patched: PASSED (14.57s)
archiver.Archiver.test_archiver_mode_recipe: PASSED (14.56s)
archiver.Archiver.test_archiver_srpm_mode: PASSED (83.03s)
oe-selftest () - Ran 15 tests in 911.905s
After:
archiver.Archiver.test_archiver_allows_to_filter_on_recipe_name: PASSED (23.66s)
archiver.Archiver.test_archiver_filters_by_type: PASSED (15.16s)
archiver.Archiver.test_archiver_filters_by_type_and_name: PASSED (15.33s)
archiver.Archiver.test_archiver_mode_configured: PASSED (15.94s)
archiver.Archiver.test_archiver_mode_diff: PASSED (15.79s)
archiver.Archiver.test_archiver_mode_dumpdata: PASSED (15.39s)
archiver.Archiver.test_archiver_mode_mirror: PASSED (15.28s)
archiver.Archiver.test_archiver_mode_mirror_combined: PASSED (21.22s)
archiver.Archiver.test_archiver_mode_mirror_excludes: PASSED (15.11s)
archiver.Archiver.test_archiver_mode_mirror_gitsm: PASSED (13.61s)
archiver.Archiver.test_archiver_mode_mirror_gitsm_shallow: PASSED (23.21s)
archiver.Archiver.test_archiver_mode_original: PASSED (14.87s)
archiver.Archiver.test_archiver_mode_patched: PASSED (15.50s)
archiver.Archiver.test_archiver_mode_recipe: PASSED (15.62s)
archiver.Archiver.test_archiver_srpm_mode: PASSED (20.66s)
oe-selftest () - Ran 15 tests in 257.170s
(From OE-Core rev: 04b4e6e271c2c3e02b105edb3b0d8aae39dd3d7c)
Signed-off-by: Paul Barker <pbarker@konsulko.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Using the new Fetch.expanded_urldata() function we can get URL data for
all git submodules.
(From OE-Core rev: d908ca51b72f4ba417e7573ae3d953535f53286c)
Signed-off-by: Paul Barker <pbarker@konsulko.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
This ensures that builddir is updated correctly to point to the new
selftest build directory when we're given a list of test suites instead
of a list of test cases.
(From OE-Core rev: 56e211d0f3c6cb84f5982e5de00faeeed69c1912)
Signed-off-by: Paul Barker <pbarker@konsulko.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
This may be useful if the parent directory of the original builddir is
not writable, on a lower performance drive, etc.
(From OE-Core rev: dab719e5f1964fd48e9a35e6b9db1508b5414540)
Signed-off-by: Paul Barker <pbarker@konsulko.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
We can't assume that rpm packaging will always be enabled when running
oe-selftest. In particular when using nodistro instead of poky this is
not enabled by default.
(From OE-Core rev: 23df3024664ec56dbbe8865ef3953d2c33a7a2cb)
Signed-off-by: Paul Barker <pbarker@konsulko.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Add support for an --offset argument when defining a partition. Many
SoCs require that boot partitions be located at specific offsets. Prior
to this argument, most WKS files were using the --align attribute to
specify the location of these fixed partitions but this is not ideal
because in the event that the partition couldn't be placed in the
specified location, wic would move it to the next sector with that
alignment, often preventing the device from booting. Unlike the --align
argument, wic will fail if a partition cannot be placed at the exact
offset specified with --offset.
Changes in V2:
* Fixed a small typo that prevented test_fixed_size_error from passing
(From OE-Core rev: 467f84e12b96bc977d57575023517dd6f8ef7f29)
Signed-off-by: Joshua Watt <JPEWhacker@gmail.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
I took the opportunity to rewrite the recipe from scratch; there was just too much baggage in it.
(From OE-Core rev: f058272de9cba188d96940c8c921cf31727fe4d1)
Signed-off-by: Alexander Kanavin <alex.kanavin@gmail.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Note that to actually use accelerated GL passthrough, there are two options
1) a suitable frontend need to be also enabled - gtk+ and SDL both seem to work well.
Previously I struggled to make SDL work, but now it seems fine.
2) it is also possible to render off-screen with -display egl-headless option,
and see the output with a VNC viewer (for which, qemu needs to be started
with a VNC server):
$ runqemu kvm egl-headless publicvnc
(From OE-Core rev: 662c688e635f4490aac0d6d34ce7a7b31d73f5c5)
Signed-off-by: Alexander Kanavin <alex.kanavin@gmail.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Declare images in wic.zst format as supported, as bmaptool now supports
zstd:
1b8437d584
Given the very fast decompression speed of zstd over, for example, gzip,
writing images with bmaptool can provide big write speed improvements
when decompression speed is the limiting factor (especially with very
sparse images).
(From OE-Core rev: 704b01f33196cfdeaa57e2f2602ff2d52b25ab93)
Signed-off-by: Diego Rondini <diego.rondini@kynetics.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Add new testcase to check IMAGE_GEN_DEBUGFS. Test makes
sure that debug filesystem is created accordingly. Test also check
for debug symbols for some packages as suggested by Ross Burton.
[YOCTO #10906]
(From OE-Core rev: 727e8819df17f0f959b602e6f7b6af15993fc466)
Signed-off-by: Humberto Ibarra <humberto.ibarra.lopez@intel.com>
Signed-off-by: Yeoh Ee Peng <ee.peng.yeoh@intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Debian 9 has an older version of mesa, where dri drivers do not link
against glapi explicitly, which causes problems when they are loaded
by newer mesa-native:
pokybuild@debian9-ty-2:~$ ldd -d /usr/lib/x86_64-linux-gnu/dri/swrast_dri.so |grep undefined
undefined symbol: _glapi_tls_Dispatch (/usr/lib/x86_64-linux-gnu/dri/swrast_dri.so)
undefined symbol: _glapi_tls_Context (/usr/lib/x86_64-linux-gnu/dri/swrast_dri.so)
compared to Debian 10:
pokybuild@debian10-ty-2:~$ ldd -d /usr/lib/x86_64-linux-gnu/dri/swrast_dri.so|grep undefined
pokybuild@debian10-ty-2:~$
(From OE-Core rev: e604e9d23478a4ea8e5afa63306dd481a34c68d1)
Signed-off-by: Alexander Kanavin <alex.kanavin@gmail.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Make sure permissions are respected.
Add new test for orig/destination option.
Cc: Paul Barker <pbarker@konsulko.com>
(From OE-Core rev: 33785be3c7eb4d5684cded08f955412a0c008929)
Signed-off-by: Ricardo Ribalda Delgado <ricardo@ribalda.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Make sure that the permissions and username are respected when using all
the rootfs modifiers.
Add tests for change-directory command
Cc: Paul Barker <pbarker@konsulko.com>
(From OE-Core rev: 4aad9531df44d1b0637bd559161702ad86861b46)
Signed-off-by: Ricardo Ribalda Delgado <ricardo@ribalda.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
sysroot-test depends on virtual/sysroot-test which we build for one machine,
switch machine, switch provider of virtual/sysroot-test and check that the
sysroot is correctly cleaned up. The files in the two providers overlap
so can cause errors if the sysroot code doesn't function correctly.
Yes, sysroot-test should be machine specific really to avoid this, however
the sysroot cleanup should also work.
This adds a test for bug:
[YOCTO #13702]
(From OE-Core rev: 24ca62b3c1fd404b67d549b29aeeacf913e6dc86)
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Yocto Bug: https://bugzilla.yoctoproject.org/show_bug.cgi?id=13806
Add test_preserve_ownership to selftest/package.
This test creates a file, a directory and a symbolic link and changes ownership,
then compares with them installed in rootfs to ensure ownership is preserved.
[Test without a commit 'bitbake: lib/bb/utils.py: Preserve ownership of symlink']
| 2020-03-14 10:01:14,519 - oe-selftest - INFO - test_preserve_ownership (package.PackageTests)
| 2020-03-14 10:56:44,612 - oe-selftest - INFO - Check ownership of /etc/selftest-chown/file
| 2020-03-14 10:56:44,770 - oe-selftest - INFO - Check ownership of /etc/selftest-chown/dir
| 2020-03-14 10:56:44,822 - oe-selftest - INFO - Check ownership of /etc/selftest-chown/symlink
| 2020-03-14 10:56:44,879 - oe-selftest - ERROR - Incrrect ownership /etc/selftest-chown/symlink [root:root]
| 2020-03-14 10:56:45,884 - oe-selftest - INFO - ... FAIL
[Test with a commit 'bitbake: lib/bb/utils.py: Preserve ownership of symlink']
| 2020-03-14 10:58:49,599 - oe-selftest - INFO - test_preserve_ownership (package.PackageTests)
| 2020-03-14 11:51:39,947 - oe-selftest - INFO - Check ownership of /etc/selftest-chown/file
| 2020-03-14 11:51:40,013 - oe-selftest - INFO - Check ownership of /etc/selftest-chown/dir
| 2020-03-14 11:51:40,063 - oe-selftest - INFO - Check ownership of /etc/selftest-chown/symlink
| 2020-03-14 11:51:41,118 - oe-selftest - INFO - ... ok
(From OE-Core rev: 88c1824468109d0f78d5fee7b71baa1f3944db7f)
Signed-off-by: Daisuke Yamane <daisuke.yamane@cybertrust.co.jp>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
bitbake dropped support for this piece of functionality (the test was
the only user), drop the test too.
(From OE-Core rev: 9ba0708e34eb038dc3ea5a877a5837c534cf165f)
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
This avoids the seeing broken replacements like:
oe-selftest-centos/build/build-st-926tools/sysroots/x86_64-pokysdk-linux/etc/ssl/certs/ca-certificates.crt
which understandably break builds.
(From OE-Core rev: 04ee0e8b95cd8ed890374e0007f976684206b630)
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Now selftest is using its own copied build directory, we can stop worrying about
copying files around as backup, and drop the SIGTERM handler to try and restore
them, simplifying the code.
(From OE-Core rev: b8ea8a910267fee4bb9e57f24ba829064e22d016)
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Currently oe-selftest reuses the current build directory and the concurrent
version run with -j does not.
Standardise and use a separate new build directory in both cases. This will lead
to simpler code and more reliable user run tests.
(From OE-Core rev: 50238b0717b04e0a1fa69d618e8c8aa8445a80b0)
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
We can see tracebacks where the SIGTERM handler catches things
it shouldn't. Avoid exit(1) unless we're the process that
it was intended for.
[YOCTO #13664]
(From OE-Core rev: d9c62ffac611310efd47ed6397d31dccb72fe868)
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Yocto Bug: https://bugzilla.yoctoproject.org/show_bug.cgi?id=13663
Prior to this fix, the try/except block in OEScriptTests' setUpClass
did both the import and the raise unittest.SkipTest for the
subsequent OEPybootchartguyTests. The consequence of the this meant
that, when cairo was not available on the test host, the raise was
counted only once as a class setup issue, instead of once for each
of the tests to be run, resulting in incorrect skip counts in the
test results.
Instead of raising unittest.SkipTest in setUpClass, the more
proper method is to use the unittest.skipUnless method along with
importlib.util.find_spec to check for the presence of the
python3-cairo module. This allows the entire class to be skipped
if cairo is not present, while also correctly passing along the
skip state for each of the class's tests, and avoiding the UNKNOWN
results to appear in cases where the -j option was provided to
oe-selftest, but the tests were still skipped.
(From OE-Core rev: 10c2216cb6fb61c74babd8bd17cb3481754b7475)
Signed-off-by: Trevor Gamblin <trevor.gamblin@windriver.com>
Signed-off-by: Ross Burton <ross.burton@intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Includes jquery in the output directory to make the diffoscope output
easier to navigate
(From OE-Core rev: ff7c386455848e497ef40f9fee2be87d5171e203)
Signed-off-by: Joshua Watt <JPEWhacker@gmail.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Corrections:
- environment
- accommodate
- conversion
- compatible
(From OE-Core rev: 9797d3b45b4e1b9d77f0f2ee299c17b48d8d3cf6)
Signed-off-by: Robert P. J. Day <rpjday@crashcourse.ca>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
The APPEND is an optional variable, so add it to the optional variables
list to make the wic selftest happy.
(From OE-Core rev: 7c8b3a1b920fd4cc1598357985eef0e5e0e0ac79)
Signed-off-by: Kevin Hao <kexin.hao@windriver.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
If there are differing packages and they are being saved for review,
automatically run diffoscope on them and include the output in the saved
output. The output is currently done in HTML format since these are
typically published on a webpage by the autobuilder.
(From OE-Core rev: 6e1d5e8b58f0940ba6dfd99536159dd974e6f24c)
Signed-off-by: Joshua Watt <JPEWhacker@gmail.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
cpio 2.12 was released in 2015 and might have used older autotools
which could result in errors like
https://bugzilla.yoctoproject.org/show_bug.cgi?id=13779
Bumping to 2.13 will help in matching the tool versions
A good change on top would be to run
aclocal -I .; autoheader; autoconf; automake --add-missing -c
before running configure step perhaps
[YOCTO #13779]
(From OE-Core rev: 84eb1dc4fe8a11cd2d05b703070a6fb6de05b873)
Signed-off-by: Khem Raj <raj.khem@gmail.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Adding newline characters between the packages in the failure output
massively improves readability.
Also ensure to output ipk failures when there are deb failures by
calling self.fail() at the end, else sometimes only partial differences
are returned.
(From OE-Core rev: 6e2e0480852177db75a6108d77c99c92c4e9950f)
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Do not strip packages when testing reproducible builds. In some cases,
stripped data differs between builds, but then gets removed. However,
the contents affect the generation of the GCC build-id, which then
differs in the resulting ELF files, even though the data that caused
this is no longer there. Inhibit stripping so that their causes can be
evaluated.
(From OE-Core rev: 0e23c6faf8169a333ae29064553705b5d7d6b589)
Signed-off-by: Joshua Watt <JPEWhacker@gmail.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
If OEQA_DEBUGGING_SAVED_OUTPUT is set in the environment, use this location
to store reproducibile build failure output. This aids debugging on the
YP autobuilder in particular.
Use a date in the directory name to make it easier to find failure output.
Also clean up empty directories as they're unnecessary distracting noise.
(From OE-Core rev: 138ed4aa96ec5069f9f7fd02994a42452dbccc2d)
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Currently the test depends on which DISTRO_FEATURES and targets are selected.
Similar to SOURCE_MIRROR_FETCH, add PARSE_ALL_RECIPES to allow the test to see
a much wider range of them. This avoids issues added by the new ucontext musl
specific recipe and allows the current whitelist to be cleared out a bit (more
cleanup can follow).
(From OE-Core rev: c139e058bb2df48c79784cf3fd701e51bbc68427)
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
This commit adds a devtool build test for npm recipe:
- devtool.DevtoolAddTests.test_devtool_add_npm
(From OE-Core rev: af299817c2fe9fa504762c54bd0593f3163399fb)
Signed-off-by: Jean-Marie LEMETAYER <jean-marie.lemetayer@savoirfairelinux.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
This commit adds a recipetool creation test for npm recipe:
- recipetool.RecipetoolTests.test_recipetool_create_npm
(From OE-Core rev: 61cabc2ccaa6a972b799d19fda8964926cc7ecec)
Signed-off-by: Jean-Marie LEMETAYER <jean-marie.lemetayer@savoirfairelinux.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Previous refactoring broke the case where save_dir was set. Fix this.
(From OE-Core rev: 9bfa04aa1f1a0b38ffa51f0211f3a46a90e17b0a)
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
A typo was preventing the extra data about the reproducible build from
being reported in the test results
(From OE-Core rev: 7c653337360dd5e49809b930f22a999c1d6e09ee)
Signed-off-by: Joshua Watt <JPEWhacker@gmail.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Adds a flag to control if the reproducible QA test should allow building
from sstate or not. Building from sstate may not be reproducible
depending on how the sstate is populated.
(From OE-Core rev: c24b71e9ec2e518bd24da20ddbb1406910b1b92e)
Signed-off-by: Joshua Watt <JPEWhacker@gmail.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Also remove a couple of entries found by the test :)
(From OE-Core rev: 749f44b3735e4ae3657255b373fa55c357501cc5)
Signed-off-by: Alexander Kanavin <alex.kanavin@gmail.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
We define a new method of populating a source mirror using the archiver
bbclass instead of simply copying the contents of the downloads
directory. This allows the archiver features such as copyleft license
filtering and recipe type filtering to be used when preparing a source
mirror.
This new archiver mode is selected by setting `ARCHIVE_MODE[src]` to
'mirror'.
The source mirror mode can either be 'split' (default) or 'combined',
controlled by `ARCHIVER_MODE[mirror]`. Additionally, sources can be
excluded as needed by setting `ARCHIVER_MIRROR_EXCLUDE` to a list of
URI prefixes. These options are described in more detail in the new
entries in the header of archiver.bbclass.
New oeqa selftest cases are added to cover the mirror archiver mode.
(From OE-Core rev: 2c8b31ae0ab95a8b100e8bade23f51574e273c9a)
Signed-off-by: Paul Barker <pbarker@konsulko.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
