From 9907b76dad0777ee300de236dad4b559e07596ab Mon Sep 17 00:00:00 2001 From: Hiroshi SHIBATA Date: Fri, 21 Feb 2025 16:01:17 +0900 Subject: [PATCH] Use String#concat instead of String#+ for reducing cpu usage Co-authored-by: "Yusuke Endoh" Upstream-Status: Backport [https://github.com/ruby/cgi/commit/9907b76dad0777ee300de236dad4b559e07596ab] CVE: CVE-2025-27219 Signed-off-by: Ashish Sharma lib/cgi/cookie.rb | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/lib/cgi/cookie.rb b/lib/cgi/cookie.rb index 9498e2f..1c4ef6a 100644 --- a/lib/cgi/cookie.rb +++ b/lib/cgi/cookie.rb @@ -190,9 +190,10 @@ def self.parse(raw_cookie) values ||= "" values = values.split('&').collect{|v| CGI.unescape(v,@@accept_charset) } if cookies.has_key?(name) - values = cookies[name].value + values + cookies[name].concat(values) + else + cookies[name] = Cookie.new(name, *values) end - cookies[name] = Cookie.new(name, *values) end cookies