mirror of
https://git.yoctoproject.org/poky
synced 2026-09-24 22:36:21 +02:00
memory corruption when processing malformed terminfo data entries loaded by setuid/setgid programs CVE-2023-29491.patch change the --disable-root-environ configure option behavior. set --disable-root-environ in configuration options. --disable-root-environ option with a few additional changes to the code allows us to mitigate CVE-2023-29491 and avoid other issues that involve the possibility of malicious use of environment variables through setuid applications, and, therefore, it was the fix chosen in order to resolve this vulnerability. Reference: https://ubuntu.com/security/CVE-2023-29491 https://launchpad.net/ubuntu/+source/ncurses/6.2-0ubuntu2.1 (From OE-Core rev: 041433f0767ae9112f6a74a7d7c93ce9b411792c) Signed-off-by: virendra thakur <virendrak@kpit.com> Signed-off-by: Steve Sakoman <steve@sakoman.com>
46 lines
1.4 KiB
Diff
46 lines
1.4 KiB
Diff
Backport of:
|
|
|
|
Author: Sven Joachim <svenjoac@gmx.de>
|
|
Description: Change the --disable-root-environ configure option behavior
|
|
By default, the --disable-root-environ option forbids program run by
|
|
the superuser to load custom terminfo entries. This patch changes
|
|
that to only restrict programs running with elevated privileges,
|
|
matching the behavior of the --disable-setuid-environ option
|
|
introduced in the 20230423 upstream patchlevel.
|
|
Bug-Debian: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1034372#29
|
|
Bug: https://lists.gnu.org/archive/html/bug-ncurses/2023-04/msg00018.html
|
|
Forwarded: not-needed
|
|
Last-Update: 2023-05-01
|
|
|
|
Upstream-Status: Backport [https://launchpad.net/ubuntu/+archive/primary/+sourcefiles/ncurses/6.2-0ubuntu2.1/ncurses_6.2-0ubuntu2.1.debian.tar.xz]
|
|
CVE: CVE-2023-29491
|
|
Signed-off-by: Virendra Thakur <virendrak@kpit.com>
|
|
|
|
---
|
|
ncurses/tinfo/access.c | 2 --
|
|
1 file changed, 2 deletions(-)
|
|
|
|
--- a/ncurses/tinfo/access.c
|
|
+++ b/ncurses/tinfo/access.c
|
|
@@ -178,15 +178,16 @@ _nc_is_file_path(const char *path)
|
|
NCURSES_EXPORT(int)
|
|
_nc_env_access(void)
|
|
{
|
|
+ int result = TRUE;
|
|
+
|
|
#if HAVE_ISSETUGID
|
|
if (issetugid())
|
|
- return FALSE;
|
|
+ result = FALSE;
|
|
#elif HAVE_GETEUID && HAVE_GETEGID
|
|
if (getuid() != geteuid()
|
|
|| getgid() != getegid())
|
|
- return FALSE;
|
|
+ result = FALSE;
|
|
#endif
|
|
- /* ...finally, disallow root */
|
|
- return (getuid() != ROOT_UID) && (geteuid() != ROOT_UID);
|
|
+ return result;
|
|
}
|
|
#endif
|