mirror of
https://git.yoctoproject.org/poky
synced 2026-09-24 22:36:21 +02:00
The patch tool will apply patches by default with "fuzz", which is where if the hunk context isn't present but what is there is close enough, it will force the patch in. Whilst this is useful when there's just whitespace changes, when applied to source it is possible for a patch applied with fuzz to produce broken code which still compiles (see #10450). This is obviously bad. We'd like to eventually have do_patch() rejecting any fuzz on these grounds. For that to be realistic the existing patches with fuzz need to be rebased and reviewed. (From OE-Core rev: 856a70cf6ca9137d5c07c2aa9ef447032589504d) Signed-off-by: Ross Burton <ross.burton@intel.com> Signed-off-by: Alexander Kanavin <alexander.kanavin@linux.intel.com> Signed-off-by: Ross Burton <ross.burton@intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
59 lines
1.9 KiB
Diff
59 lines
1.9 KiB
Diff
From 7461a3de38b66edbe2f5593f9bdab9f2704d32bc Mon Sep 17 00:00:00 2001
|
|
From: Hongxu Jia <hongxu.jia@windriver.com>
|
|
Date: Wed, 17 Aug 2016 04:06:34 -0400
|
|
Subject: [PATCH] grub module explicitly keeps symbole .module_license
|
|
|
|
While using oe-core toolchain to strip grub module 'all_video.mod',
|
|
it stripped symbol table:
|
|
--------------
|
|
root@localhost:~# objdump -t all_video.mod
|
|
|
|
all_video.mod: file format elf64-x86-64
|
|
|
|
SYMBOL TABLE:
|
|
no symbols
|
|
--------------
|
|
|
|
It caused grub to load module all_video failed.
|
|
--------------
|
|
grub> insmod all_video
|
|
error: no symbol table.
|
|
--------------
|
|
|
|
Tweak strip option to keep symbol .module_license could workaround
|
|
the issue.
|
|
--------------
|
|
root@localhost:~# objdump -t all_video.mod
|
|
|
|
all_video.mod: file format elf64-x86-64
|
|
|
|
SYMBOL TABLE:
|
|
0000000000000000 l d .text 0000000000000000 .text
|
|
0000000000000000 l d .data 0000000000000000 .data
|
|
0000000000000000 l d .module_license 0000000000000000 .module_license
|
|
0000000000000000 l d .bss 0000000000000000 .bss
|
|
0000000000000000 l d .moddeps 0000000000000000 .moddeps
|
|
0000000000000000 l d .modname 0000000000000000 .modname
|
|
--------------
|
|
|
|
Upstream-Status: Pending
|
|
|
|
Signed-off-by: Hongxu Jia <hongxu.jia@windriver.com>
|
|
---
|
|
grub-core/genmod.sh.in | 2 +-
|
|
1 file changed, 1 insertion(+), 1 deletion(-)
|
|
|
|
Index: grub-2.02/grub-core/genmod.sh.in
|
|
===================================================================
|
|
--- grub-2.02.orig/grub-core/genmod.sh.in
|
|
+++ grub-2.02/grub-core/genmod.sh.in
|
|
@@ -56,7 +56,7 @@ if test x@TARGET_APPLE_LINKER@ != x1; th
|
|
if test x@platform@ != xemu; then
|
|
@TARGET_STRIP@ --strip-unneeded \
|
|
-K grub_mod_init -K grub_mod_fini \
|
|
- -K _grub_mod_init -K _grub_mod_fini \
|
|
+ -K _grub_mod_init -K _grub_mod_fini -K .module_license \
|
|
-R .note.gnu.gold-version -R .note.GNU-stack \
|
|
-R .note -R .comment -R .ARM.exidx $tmpfile || exit 1
|
|
fi
|