mirror of
https://git.yoctoproject.org/poky
synced 2026-03-09 16:59:40 +01:00
2aebe10959
A path traversal vulnerability exists in rsync. It stems from behavior enabled by the `--inc-recursive` option, a default-enabled option for many client options and can be enabled by the server even if not explicitly enabled by the client. When using the `--inc-recursive` option, a lack of proper symlink verification coupled with deduplication checks occurring on a per-file-list basis could allow a server to write files outside of the client's intended destination directory. A malicious server could write malicious files to arbitrary locations named after valid directories/paths on the client. (From OE-Core rev: 12328df8dfcdc73ef70af299e9ebdc1d8ae73f37) Signed-off-by: Archana Polampalli <archana.polampalli@windriver.com> Signed-off-by: Steve Sakoman <steve@sakoman.com>
32 lines
1.0 KiB
Diff
32 lines
1.0 KiB
Diff
From 344327385fa47fa5bb67a32c237735e6240cfb93 Mon Sep 17 00:00:00 2001
|
|
From: Andrew Tridgell <andrew@tridgell.net>
|
|
Date: Tue, 26 Nov 2024 16:12:45 +1100
|
|
Subject: [PATCH] range check dir_ndx before use
|
|
|
|
CVE: CVE-2024-12087
|
|
|
|
Upstream-Status: Backport [https://git.samba.org/?p=rsync.git;a=commit;h=344327385fa47fa5bb67a32c237735e6240cfb93]
|
|
|
|
Signed-off-by: Archana Polampalli <archana.polampalli@windriver.com>
|
|
---
|
|
flist.c | 4 ++++
|
|
1 file changed, 4 insertions(+)
|
|
|
|
diff --git a/flist.c b/flist.c
|
|
index 847b1054..087f9da6 100644
|
|
--- a/flist.c
|
|
+++ b/flist.c
|
|
@@ -2585,6 +2585,10 @@ struct file_list *recv_file_list(int f, int dir_ndx)
|
|
#endif
|
|
|
|
if (inc_recurse && dir_ndx >= 0) {
|
|
+ if (dir_ndx >= dir_flist->used) {
|
|
+ rprintf(FERROR_XFER, "rsync: refusing invalid dir_ndx %u >= %u\n", dir_ndx, dir_flist->used);
|
|
+ exit_cleanup(RERR_PROTOCOL);
|
|
+ }
|
|
struct file_struct *file = dir_flist->files[dir_ndx];
|
|
if (file->flags & FLAG_GOT_DIR_FLIST) {
|
|
rprintf(FERROR_XFER, "rsync: refusing malicious duplicate flist for dir %d\n", dir_ndx);
|
|
--
|
|
2.40.0
|