mirror of
https://git.yoctoproject.org/poky
synced 2026-02-24 18:39:40 +01:00
226c2fd1f7
Source: git://sourceware.org/git/binutils-gdb.git
MR: 74166
Type: Security Fix
Disposition: Backport from binutils-2_29
ChangeID: d614742d33a55da6cafede60cd171766afb0aa1d
Description:
PR 21414, null pointer deref of _bfd_elf_large_com_section sym
PR 21414
* section.c (GLOBAL_SYM_INIT): Make available in bfd.h.
* elf.c (lcomm_sym): New.
(_bfd_elf_large_com_section): Use lcomm_sym section symbol.
* bfd-in2.h: Regenerate.
Affects: <= 2.29
Author: Alan Modra <amodra@gmail.com>
(From OE-Core rev: 0d6e08ffc4760947653ad9368d594074d506f697)
Signed-off-by: Thiruvadi Rajaraman <trajaraman@mvista.com>
Reviewed-by: Armin Kuster <akuster@mvista.com>
Signed-off-by: Armin Kuster <akuster@mvista.com>
Signed-off-by: Armin Kuster <akuster808@gmail.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
81 lines
3.3 KiB
Diff
81 lines
3.3 KiB
Diff
commit 821e6ff6299aa39e841ca50e1ae8a98e3554fd5f
|
|
Author: Alan Modra <amodra@gmail.com>
|
|
Date: Wed Oct 12 09:41:33 2016 +1030
|
|
|
|
BFD_FAKE_SECTION macro params
|
|
|
|
Order NAME, IDX, FLAGS as per STD_SECTION macro.
|
|
|
|
* section.c (BFD_FAKE_SECTION): Reorder parameters. Formatting.
|
|
(STD_SECTION): Adjust to suit.
|
|
* elf.c (_bfd_elf_large_com_section): Likewise.
|
|
* bfd-in2.h: Regenerate.
|
|
|
|
Upstream-Status: Backport
|
|
|
|
CVE: CVE-2017-8394
|
|
Signed-off-by: Thiruvadi Rajaraman <trajaraman@mvista.com>
|
|
|
|
|
|
Index: git/bfd/bfd-in2.h
|
|
===================================================================
|
|
--- git.orig/bfd/bfd-in2.h 2017-09-20 12:54:42.423465338 +0530
|
|
+++ git/bfd/bfd-in2.h 2017-09-20 13:02:48.000000000 +0530
|
|
@@ -1767,9 +1767,9 @@
|
|
#define bfd_section_removed_from_list(ABFD, S) \
|
|
((S)->next == NULL ? (ABFD)->section_last != (S) : (S)->next->prev != (S))
|
|
|
|
-#define BFD_FAKE_SECTION(SEC, FLAGS, SYM, NAME, IDX) \
|
|
+#define BFD_FAKE_SECTION(SEC, SYM, NAME, IDX, FLAGS) \
|
|
/* name, id, index, next, prev, flags, user_set_vma, */ \
|
|
- { NAME, IDX, 0, NULL, NULL, FLAGS, 0, \
|
|
+ { NAME, IDX, 0, NULL, NULL, FLAGS, 0, \
|
|
\
|
|
/* linker_mark, linker_has_input, gc_mark, decompress_status, */ \
|
|
0, 0, 1, 0, \
|
|
Index: git/bfd/elf.c
|
|
===================================================================
|
|
--- git.orig/bfd/elf.c 2017-09-20 12:54:44.503474440 +0530
|
|
+++ git/bfd/elf.c 2017-09-20 13:02:48.000000000 +0530
|
|
@@ -10984,10 +10984,12 @@
|
|
return n;
|
|
}
|
|
|
|
-/* It is only used by x86-64 so far. */
|
|
+/* It is only used by x86-64 so far.
|
|
+ ??? This repeats *COM* id of zero. sec->id is supposed to be unique,
|
|
+ but current usage would allow all of _bfd_std_section to be zero. t*/
|
|
asection _bfd_elf_large_com_section
|
|
- = BFD_FAKE_SECTION (_bfd_elf_large_com_section,
|
|
- SEC_IS_COMMON, NULL, "LARGE_COMMON", 0);
|
|
+ = BFD_FAKE_SECTION (_bfd_elf_large_com_section, NULL,
|
|
+ "LARGE_COMMON", 0, SEC_IS_COMMON);
|
|
|
|
void
|
|
_bfd_elf_post_process_headers (bfd * abfd,
|
|
Index: git/bfd/section.c
|
|
===================================================================
|
|
--- git.orig/bfd/section.c 2017-09-20 12:54:43.815471454 +0530
|
|
+++ git/bfd/section.c 2017-09-20 13:02:48.000000000 +0530
|
|
@@ -700,9 +700,9 @@
|
|
.#define bfd_section_removed_from_list(ABFD, S) \
|
|
. ((S)->next == NULL ? (ABFD)->section_last != (S) : (S)->next->prev != (S))
|
|
.
|
|
-.#define BFD_FAKE_SECTION(SEC, FLAGS, SYM, NAME, IDX) \
|
|
+.#define BFD_FAKE_SECTION(SEC, SYM, NAME, IDX, FLAGS) \
|
|
. {* name, id, index, next, prev, flags, user_set_vma, *} \
|
|
-. { NAME, IDX, 0, NULL, NULL, FLAGS, 0, \
|
|
+. { NAME, IDX, 0, NULL, NULL, FLAGS, 0, \
|
|
. \
|
|
. {* linker_mark, linker_has_input, gc_mark, decompress_status, *} \
|
|
. 0, 0, 1, 0, \
|
|
@@ -764,7 +764,7 @@
|
|
};
|
|
|
|
#define STD_SECTION(NAME, IDX, FLAGS) \
|
|
- BFD_FAKE_SECTION(_bfd_std_section[IDX], FLAGS, &global_syms[IDX], NAME, IDX)
|
|
+ BFD_FAKE_SECTION(_bfd_std_section[IDX], &global_syms[IDX], NAME, IDX, FLAGS)
|
|
|
|
asection _bfd_std_section[] = {
|
|
STD_SECTION (BFD_COM_SECTION_NAME, 0, SEC_IS_COMMON),
|