mirror of
https://git.yoctoproject.org/poky
synced 2026-04-07 23:02:22 +02:00
target/ssh: Ensure exit code set for commands
As spotted by Joshua Watt, the returncode isn't set until .poll() or .wait() is called so we need to call this after the .kill() call. This fixes return code reporting so that timeouts for example now return an exit code when they didn't before. (From OE-Core rev: 3924e94214b5135369be2551d54fb92097d35e95) Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
This commit is contained in:
@@ -265,6 +265,7 @@ def SSHCall(command, logger, timeout=None, **opts):
|
||||
time.sleep(5)
|
||||
try:
|
||||
process.kill()
|
||||
process.wait()
|
||||
except OSError:
|
||||
logger.debug('OSError when killing process')
|
||||
pass
|
||||
@@ -287,6 +288,7 @@ def SSHCall(command, logger, timeout=None, **opts):
|
||||
except TimeoutExpired:
|
||||
try:
|
||||
process.kill()
|
||||
process.wait()
|
||||
except OSError:
|
||||
logger.debug('OSError')
|
||||
pass
|
||||
@@ -316,6 +318,7 @@ def SSHCall(command, logger, timeout=None, **opts):
|
||||
# whilst running and ensure we don't leave a process behind.
|
||||
if process.poll() is None:
|
||||
process.kill()
|
||||
process.wait()
|
||||
logger.debug('Something went wrong, killing SSH process')
|
||||
raise
|
||||
|
||||
|
||||
Reference in New Issue
Block a user