mirror of
https://git.yoctoproject.org/poky
synced 2026-04-18 21:32:12 +02:00
insane.bbclass: make sure to close .patch files
* fixes:
DEBUG: Executing python function do_qa_patch
/OE/build/oe-core/openembedded-core/meta/classes/insane.bbclass:1189: ResourceWarning: unclosed file <_io.TextIOWrapper name='/OE/build/oe-core/openembedded-core/meta/recipes-bsp/keymaps/files/GPLv2.patch' mode='r' encoding='utf-8'>
content = open(fullpath, encoding='utf-8', errors='ignore').read()
ResourceWarning: Enable tracemalloc to get the object allocation traceback
DEBUG: Python function do_qa_patch finished
(From OE-Core rev: 61be3668d866834adfff688620aee7e29f6d8c44)
Signed-off-by: Martin Jansa <Martin.Jansa@gmail.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
This commit is contained in:
committed by
Richard Purdie
parent
faefe4f7c6
commit
2dda445879
@@ -1201,18 +1201,20 @@ python do_qa_patch() {
|
||||
if '/meta/' not in fullpath:
|
||||
continue
|
||||
|
||||
content = open(fullpath, encoding='utf-8', errors='ignore').read()
|
||||
kinda_status_re = re.compile(r"^.*upstream.*status.*$", re.IGNORECASE | re.MULTILINE)
|
||||
strict_status_re = re.compile(r"^Upstream-Status: (Pending|Submitted|Denied|Accepted|Inappropriate|Backport|Inactive-Upstream)( .+)?$", re.MULTILINE)
|
||||
match_kinda = kinda_status_re.search(content)
|
||||
match_strict = strict_status_re.search(content)
|
||||
guidelines = "https://www.openembedded.org/wiki/Commit_Patch_Message_Guidelines#Patch_Header_Recommendations:_Upstream-Status"
|
||||
|
||||
if not match_strict:
|
||||
if match_kinda:
|
||||
bb.error("Malformed Upstream-Status in patch\n%s\nPlease correct according to %s :\n%s" % (fullpath, guidelines, match_kinda.group(0)))
|
||||
else:
|
||||
bb.error("Missing Upstream-Status in patch\n%s\nPlease add according to %s ." % (fullpath, guidelines))
|
||||
with open(fullpath, encoding='utf-8', errors='ignore') as f:
|
||||
file_content = f.read()
|
||||
match_kinda = kinda_status_re.search(file_content)
|
||||
match_strict = strict_status_re.search(file_content)
|
||||
|
||||
if not match_strict:
|
||||
if match_kinda:
|
||||
bb.error("Malformed Upstream-Status in patch\n%s\nPlease correct according to %s :\n%s" % (fullpath, guidelines, match_kinda.group(0)))
|
||||
else:
|
||||
bb.error("Missing Upstream-Status in patch\n%s\nPlease add according to %s ." % (fullpath, guidelines))
|
||||
}
|
||||
|
||||
python do_qa_configure() {
|
||||
|
||||
Reference in New Issue
Block a user