oeqa/runtime/ping: don't bother trying to ping localhost

If SLIRP is being used instead of TAP for networking to the guest then
the target IP will be localhost.  There's no point in pinging localhost
to see if the target is up but whilst you'd think it is harmless, in
some containers ping doesn't actually have enough rights to work:

  ping: socktype: SOCK_RAW
  ping: socket: Operation not permitted
  ping: => missing cap_net_raw+p capability or setuid?

Look at the target address and if it's localhost or 127.0.0.* return
immediately.

(From OE-Core rev: a06ef43d2a50e16c32bd6edbdc7b32c3528687d5)

Signed-off-by: Ross Burton <ross.burton@arm.com>
Signed-off-by: Mathieu Dubois-Briand <mathieu.dubois-briand@bootlin.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
This commit is contained in:
Ross Burton
2024-11-14 17:43:36 +00:00
committed by Richard Purdie
parent d6642fce37
commit 3975cc6f4f

View File

@@ -18,6 +18,13 @@ class PingTest(OERuntimeTestCase):
output = ''
count = 0
self.assertNotEqual(len(self.target.ip), 0, msg="No target IP address set")
# If the target IP is localhost (because user-space networking is being used),
# then there's no point in pinging it.
if self.target.ip.startswith("127.0.0.") or self.target.ip in ("localhost", "::1"):
print("runtime/ping: localhost detected, not pinging")
return
try:
while count < 5:
cmd = 'ping -c 1 %s' % self.target.ip