mirrors/poky
1
0
Fork 0
mirror of https://git.yoctoproject.org/poky synced 2026-03-06 23:39:40 +01:00
Code Issues Packages Projects Releases Wiki Activity

oe-selftest: add a test for recipes without maintainers

Browse Source 
'bitbake -c checkpkg world' is moved to class initializer to avoid
it being run twice in a row.

The no-maintainers test checks only oe-core recipes, as other layers
may be be configured, and assigning maintainership to specific people via
maintainers.inc is known to be used only in oe-core.

(From OE-Core rev: ac6a72aab19e04adb2fa2b9932a9427d1b6fbb46)

Signed-off-by: Alexander Kanavin <alexander.kanavin@linux.intel.com>
Signed-off-by: Ross Burton <ross.burton@intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
This commit is contained in:
Alexander Kanavin
2018-02-12 13:05:21 +02:00
committed by Richard Purdie
parent 6bb3595ec5
commit 3bbf10c364
1 changed files with 62 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

67
meta/lib/oeqa/selftest/cases/distrodata.py
View File

@@ -9,6 +9,11 @@ class Distrodata(OESelftestTestCase):
@classmethod
def setUpClass(cls):
super(Distrodata, cls).setUpClass()
feature = 'INHERIT += "distrodata"\n'
feature += 'LICENSE_FLAGS_WHITELIST += " commercial"\n'
cls.write_config(cls, feature)
bitbake('-c checkpkg world')
@OETestID(1902)
def test_checkpkg(self):
@@ -18,11 +23,6 @@ class Distrodata(OESelftestTestCase):
Product: oe-core
Author: Alexander Kanavin <alexander.kanavin@intel.com>
"""
feature = 'INHERIT += "distrodata"\n'
feature += 'LICENSE_FLAGS_WHITELIST += " commercial"\n'
self.write_config(feature)
bitbake('-c checkpkg world')
checkpkg_result = open(os.path.join(get_bb_var("LOG_DIR"), "checkpkg.csv")).readlines()[1:]
regressed_failures = [pkg_data[0] for pkg_data in [pkg_line.split('\t') for pkg_line in checkpkg_result] if pkg_data[11] == 'UNKNOWN_BROKEN']
regressed_successes = [pkg_data[0] for pkg_data in [pkg_line.split('\t') for pkg_line in checkpkg_result] if pkg_data[11] == 'KNOWN_BROKEN']
@@ -40,3 +40,60 @@ The following packages have been checked successfully for upstream versions,
but their recipes claim otherwise by setting UPSTREAM_VERSION_UNKNOWN. Please remove that line from the recipes.
""" + "\n".join(regressed_successes)
self.assertTrue(len(regressed_failures) == 0 and len(regressed_successes) == 0, msg)
def test_maintainers(self):
"""
Summary: Test that oe-core recipes have a maintainer
Expected: All oe-core recipes (except a few special static/testing ones) should have a maintainer listed in maintainers.inc file.
Product: oe-core
Author: Alexander Kanavin <alexander.kanavin@intel.com>
"""
def is_exception(pkg):
exceptions = ["packagegroup-", "initramfs-", "systemd-machine-units", "target-sdk-provides-dummy"]
for i in exceptions:
if i in pkg:
return True
return False
def is_in_oe_core(recipe, recipes):
self.assertTrue(recipe in recipes.keys(), "Recipe %s was not in 'bitbake-layers show-recipes' output" %(recipe))
self.assertTrue(len(recipes[recipe]) > 0, "'bitbake-layers show-recipes' could not determine what layer(s) a recipe %s is in" %(recipe))
try:
recipes[recipe].index('meta')
return True
except ValueError:
return False
def get_recipe_layers():
import re
recipes = {}
recipe_regex = re.compile('^(?P<name>.*):$')
layer_regex = re.compile('^ (?P<name>\S*) +')
output = runCmd('bitbake-layers show-recipes').output
for line in output.split('\n'):
recipe_name_obj = recipe_regex.search(line)
if recipe_name_obj:
recipe_name = recipe_name_obj.group('name')
recipes[recipe_name] = []
recipe_layer_obj = layer_regex.search(line)
if recipe_layer_obj:
layer_name = recipe_layer_obj.group('name')
recipes[recipe_name].append(layer_name)
return recipes
checkpkg_result = open(os.path.join(get_bb_var("LOG_DIR"), "checkpkg.csv")).readlines()[1:]
recipes_layers = get_recipe_layers()
no_maintainer_list = [pkg_data[0] for pkg_data in [pkg_line.split('\t') for pkg_line in checkpkg_result] \
if pkg_data[14] == '' and is_in_oe_core(pkg_data[0], recipes_layers) and not is_exception(pkg_data[0])]
msg = """
The following packages do not have a maintainer assigned to them. Please add an entry to meta/conf/distro/include/maintainers.inc file.
""" + "\n".join(no_maintainer_list)
self.assertTrue(len(no_maintainer_list) == 0, msg)
with_maintainer_list = [pkg_data[0] for pkg_data in [pkg_line.split('\t') for pkg_line in checkpkg_result] \
if pkg_data[14] != '' and is_in_oe_core(pkg_data[0], recipes_layers) and not is_exception(pkg_data[0])]
msg = """
The list of oe-core packages with maintainers is empty. This may indicate that the test has regressed and needs fixing.
"""
self.assertTrue(len(with_maintainer_list) > 0, msg)