puzzles: fix uninitialized variable compiler error

In tree234.c, change a while() loop to a for() loop so
that the compiler will realize we loop at least once.

(From OE-Core rev: 631cd6f9144fa5dd3a36480905d6edc9b5e81520)

Signed-off-by: Joe Slater <joe.slater@windriver.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
This commit is contained in:
Joe Slater
2019-03-14 12:19:24 -07:00
committed by Richard Purdie
parent 9d6a429f58
commit 418021ce9d
2 changed files with 26 additions and 0 deletions

View File

@@ -0,0 +1,25 @@
puzzles: avoid compiler unitialized variable error
The compiler does not realize that we must go through the while()
loop at least once, so we replace it with a for() loop.
Upstream-Status: Pending
Signed-off-by: Joe Slater <joe.slater@windriver.com>
--- a/tree234.c
+++ b/tree234.c
@@ -326,8 +326,11 @@ static void *add234_internal(tree234 *t,
return orig_e;
}
- n = t->root;
- while (n) {
+ /*
+ * We know t->root is not NULL. The logic
+ * to break out of this is at the end of the loop.
+ */
+ for (n = t->root;;) {
LOG((" node %p: %p/%d \"%s\" %p/%d \"%s\" %p/%d \"%s\" %p/%d\n",
n,
n->kids[0], n->counts[0], n->elems[0],

View File

@@ -14,6 +14,7 @@ SRC_URI = "git://git.tartarus.org/simon/puzzles.git \
file://0001-palisade-Fix-warnings-with-clang-on-arm.patch \
file://0001-Use-Wno-error-format-overflow-if-the-compiler-suppor.patch \
file://0001-pattern.c-Change-string-lenght-parameter-to-be-size_.patch \
file://fix-ki-uninitialized.patch \
"
UPSTREAM_CHECK_COMMITS = "1"