mirror of
https://git.yoctoproject.org/poky
synced 2026-01-29 21:08:42 +01:00
buildhistory_analysis.py: Check if RPROVIDES changed order
Instead of assuming order has changed if no package has been added or removed, loop through packages to check if order has changed. This will prevent the script from falsely reporting "changed order" if a version has increased. Fixes [YOCTO #12334] (From OE-Core rev: 77d701c5fb5961bd818810a4d4cb3a9bd2432fae) Signed-off-by: Amanda Brindle <amanda.r.brindle@intel.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
This commit is contained in:
committed by
Richard Purdie
parent
5b68f72e59
commit
4cbd560eca
@@ -117,6 +117,7 @@ class ChangeRecord:
|
||||
|
||||
if self.fieldname in list_fields or self.fieldname in list_order_fields:
|
||||
renamed_dirs = []
|
||||
changed_order = False
|
||||
if self.fieldname in ['RPROVIDES', 'RDEPENDS', 'RRECOMMENDS', 'RSUGGESTS', 'RREPLACES', 'RCONFLICTS']:
|
||||
(depvera, depverb) = compare_pkg_lists(self.oldvalue, self.newvalue)
|
||||
aitems = pkglist_combine(depvera)
|
||||
@@ -130,6 +131,14 @@ class ChangeRecord:
|
||||
removed = list(set(aitems) - set(bitems))
|
||||
added = list(set(bitems) - set(aitems))
|
||||
|
||||
if not removed and not added:
|
||||
depvera = bb.utils.explode_dep_versions2(self.oldvalue, sort=False)
|
||||
depverb = bb.utils.explode_dep_versions2(self.newvalue, sort=False)
|
||||
for i, j in zip(depvera.items(), depverb.items()):
|
||||
if i[0] != j[0]:
|
||||
changed_order = True
|
||||
break
|
||||
|
||||
lines = []
|
||||
if renamed_dirs:
|
||||
for dfrom, dto in renamed_dirs:
|
||||
@@ -145,7 +154,10 @@ class ChangeRecord:
|
||||
else:
|
||||
lines.append('changed order')
|
||||
|
||||
out = '%s: %s' % (self.fieldname, ', '.join(lines))
|
||||
if not (removed or added or changed_order):
|
||||
out = ''
|
||||
else:
|
||||
out = '%s: %s' % (self.fieldname, ', '.join(lines))
|
||||
|
||||
elif self.fieldname in numeric_fields:
|
||||
aval = int(self.oldvalue or 0)
|
||||
|
||||
Reference in New Issue
Block a user