binutils: Fix build with clang

(From OE-Core rev: 208dadb8f1864aca88c69766f3bfb37a2ef4953c)

Signed-off-by: Khem Raj <raj.khem@gmail.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
This commit is contained in:
Khem Raj
2018-12-06 19:12:33 -08:00
committed by Richard Purdie
parent 78037fd610
commit 665ff32609
2 changed files with 33 additions and 0 deletions

View File

@@ -41,6 +41,7 @@ SRC_URI = "\
file://0019-Improved-robustness.-Return-FALSE-in-case-of-NULL-po.patch \
file://0020-Make-sure-global-symbol-is-not-an-indirect-or-warnin.patch \
file://0021-PLT-information-was-still-being-generated-when-symbo.patch \
file://clang-bfd-fix.patch \
file://CVE-2018-17358.patch \
file://CVE-2018-17360.patch \
file://CVE-2018-18309.patch \

View File

@@ -0,0 +1,32 @@
Fix compiler error seen with clang, The return value of this
function is not checked anywhere so in a way its useless but
still technically correct to return a value here
Fixes
../../bfd/reloc.c:1638:7: error: non-void function '_bfd_clear_contents' should return a value [-Wreturn-type]
return;
^
1 error generated.
It has been fixed in master along with a larger cleanup and fix for relocations
https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;a=commit;h=1dc9e2d63e37839ff1768346b2e3f52e338baba5
Upstream-Status: Backport [Fixes differently]
Signed-off-by: Khem Raj <raj.khem@gmail.com>
Index: git/bfd/reloc.c
===================================================================
--- git.orig/bfd/reloc.c
+++ git/bfd/reloc.c
@@ -1635,7 +1635,7 @@ _bfd_clear_contents (reloc_howto_type *h
default:
abort ();
case 0:
- return;
+ return 0;
case 1:
x = bfd_get_8 (input_bfd, location);
break;