mirrors/poky
1
0
Fork 0
mirror of https://git.yoctoproject.org/poky synced 2026-04-21 21:32:12 +02:00
Code Issues Packages Projects Releases Wiki Activity

oeqa/selftest/recipetool: Make test_recipetool_load_plugin more resilient

Browse Source 
* Avoid trying to write to read-only directories and file systems.
* Support symbolic links in BBPATH.

(From OE-Core rev: 9a8b621c4d26ff349de88658e6ea21aee6ba6767)

Signed-off-by: Peter Kjellerstedt <peter.kjellerstedt@axis.com>
Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
This commit is contained in:
Peter Kjellerstedt
2023-12-06 21:55:26 +01:00
committed by Richard Purdie
parent 99bc21953a
commit 7481f8e916
1 changed files with 20 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

25
meta/lib/oeqa/selftest/cases/recipetool.py
View File

@@ -4,6 +4,7 @@
# SPDX-License-Identifier: MIT
#
import errno
import os
import shutil
import tempfile
@@ -914,7 +915,15 @@ class RecipetoolTests(RecipetoolBase):
for p in paths:
dstdir = os.path.join(dstdir, p)
if not os.path.exists(dstdir):
os.makedirs(dstdir)
try:
os.makedirs(dstdir)
except PermissionError:
return False
except OSError as e:
if e.errno == errno.EROFS:
return False
else:
raise e
if p == "lib":
# Can race with other tests
self.add_command_to_tearDown('rmdir --ignore-fail-on-non-empty %s' % dstdir)
@@ -922,8 +931,12 @@ class RecipetoolTests(RecipetoolBase):
self.track_for_cleanup(dstdir)
dstfile = os.path.join(dstdir, os.path.basename(srcfile))
if srcfile != dstfile:
shutil.copy(srcfile, dstfile)
try:
shutil.copy(srcfile, dstfile)
except PermissionError:
return False
self.track_for_cleanup(dstfile)
return True
def test_recipetool_load_plugin(self):
"""Test that recipetool loads only the first found plugin in BBPATH."""
@@ -937,15 +950,17 @@ class RecipetoolTests(RecipetoolBase):
plugincontent = fh.readlines()
try:
self.assertIn('meta-selftest', srcfile, 'wrong bbpath plugin found')
for path in searchpath:
self._copy_file_with_cleanup(srcfile, path, 'lib', 'recipetool')
searchpath = [
path for path in searchpath
if self._copy_file_with_cleanup(srcfile, path, 'lib', 'recipetool')
]
result = runCmd("recipetool --quiet count")
self.assertEqual(result.output, '1')
result = runCmd("recipetool --quiet multiloaded")
self.assertEqual(result.output, "no")
for path in searchpath:
result = runCmd("recipetool --quiet bbdir")
self.assertEqual(result.output, path)
self.assertEqual(os.path.realpath(result.output), os.path.realpath(path))
os.unlink(os.path.join(result.output, 'lib', 'recipetool', 'bbpath.py'))
finally:
with open(srcfile, 'w') as fh: