mirrors/poky
1
0
Fork 0
mirror of https://git.yoctoproject.org/poky synced 2026-01-29 21:08:42 +01:00
Code Issues Packages Projects Releases Wiki Activity

gstreamer1.0: improve test reliability

Browse Source 
First, libcheck has the ability to increase all test timeouts by an arbitrary
multiplier. Because we run our tests on loaded build machines,
increase all timeouts by 10x to reduce the chance of load causing failures.

Second, use GST_CHECKS_IGNORE to list test cases that should be skipped.

Drop skip-aggregator-test.patch as this is now redundant, and also skip
gstnetclientclock.c:test_functioning as this is very sensitive to load.

[ YOCTO #14808 ]

(From OE-Core rev: 669d0df81f651f7c033c8cb7872cac5bfe670a4f)

Signed-off-by: Ross Burton <ross.burton@arm.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
This commit is contained in:
Ross Burton
2024-03-15 14:37:38 +00:00
committed by Richard Purdie
parent b2191bb7a7
commit 78e48090b2
3 changed files with 15 additions and 37 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
meta/recipes-multimedia/gstreamer/gstreamer1.0/run-ptest
View File

@@ -1,2 +1,16 @@
#!/usr/bin/env sh
#! /bin/sh
# Multiply all timeouts by ten so they're more likely to work
# on a loaded system.
export CK_TIMEOUT_MULTIPLIER=5
# Skip some tests that we know are problematic
export GST_CHECKS_IGNORE=""
# gstnetclientclock.c:test_functioning is very sensitive to load
GST_CHECKS_IGNORE="$GST_CHECKS_IGNORE,test_functioning"
# aggregator.c:test_infinite_seek_50_src_live is known to be flaky
# https://gitlab.freedesktop.org/gstreamer/gstreamer/-/issues/410
GST_CHECKS_IGNORE="$GST_CHECKS_IGNORE,test_infinite_seek_50_src_live"
gnome-desktop-testing-runner gstreamer

35
meta/recipes-multimedia/gstreamer/gstreamer1.0/skip-aggregator-test.patch
View File

@@ -1,35 +0,0 @@
From 9b72aa7cdbc2a81cffc6f855933afe90c81046d5 Mon Sep 17 00:00:00 2001
From: Ross Burton <ross.burton@arm.com>
Date: Wed, 28 Feb 2024 12:40:34 +0000
Subject: [PATCH] Skip aggregator test
This test case is known to be flaky upstream[1] and often fails on the
autobuilder[2], so skip it until this has been resolved upstream.
[1] https://gitlab.freedesktop.org/gstreamer/gstreamer/-/issues/410
[2] https://bugzilla.yoctoproject.org/show_bug.cgi?id=15054
Upstream-Status: Inappropriate
Signed-off-by: Ross Burton <ross.burton@arm.com>
---
tests/check/libs/aggregator.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/tests/check/libs/aggregator.c b/tests/check/libs/aggregator.c
index 1f2c5b4..27b3ac7 100644
--- a/tests/check/libs/aggregator.c
+++ b/tests/check/libs/aggregator.c
@@ -1475,7 +1475,9 @@ gst_aggregator_suite (void)
tcase_add_test (general, test_flushing_seek);
tcase_add_test (general, test_infinite_seek);
tcase_add_test (general, test_infinite_seek_50_src);
- tcase_add_test (general, test_infinite_seek_50_src_live);
+ // This test case is known to be flaky, remove it until resolved:
+ // https://gitlab.freedesktop.org/gstreamer/gstreamer/-/issues/410
+ // tcase_add_test (general, test_infinite_seek_50_src_live);
tcase_add_test (general, test_linear_pipeline);
tcase_add_test (general, test_two_src_pipeline);
tcase_add_test (general, test_timeout_pipeline);
--
2.34.1

1
meta/recipes-multimedia/gstreamer/gstreamer1.0_1.22.10.bb
View File

@@ -21,7 +21,6 @@ SRC_URI = "https://gstreamer.freedesktop.org/src/gstreamer/gstreamer-${PV}.tar.x
file://0002-tests-add-support-for-install-the-tests.patch \
file://0003-tests-use-a-dictionaries-for-environment.patch \
file://0004-tests-add-helper-script-to-run-the-installed_tests.patch \
file://skip-aggregator-test.patch \
"
SRC_URI[sha256sum] = "969aaef396f252ce925132a4be2aa004e0320f5c1baf0acaaae09c544a6759f4"