mirrors/poky
1
0
Fork 0
mirror of https://git.yoctoproject.org/poky synced 2026-04-20 18:32:12 +02:00
Code Issues Packages Projects Releases Wiki Activity

oeqa/selftest/debuginfod: improve selftest

Browse Source 
This test was occasionally failing for no obvious reason, so refactor
and improve:

- While waiting for the daemon, check that it is still running and
  explicitly timeout after 10s when making the HTTP call.

- While waiting for the daemon to be ready, log the current state of the
  daemon so we can tell if we're timing out as it is still scanning.

- This was in fact the cause of the intermittant failures, because the
  TMPDIR is reused between tests and may contain a large number of
  packages. Do the tests in an isolated TMPDIR to hopefully mitigate this
  issue and increase the timeout to two minutes.

- Decorate the test using runqemu as such so that can be skipped in
  environments without runqemu

- Add a second test that doesn't use runqemu or images, which is faster
  but less realistic.

(From OE-Core rev: 88b660aaae2527736b6eccec4c952eee969e20a2)

Signed-off-by: Ross Burton <ross.burton@arm.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
This commit is contained in:
Ross Burton
2023-11-21 13:19:24 +00:00
committed by Richard Purdie
parent cbdc226a99
commit c15a717aa0
1 changed files with 89 additions and 37 deletions
Download Patch File Download Diff File Expand all files Collapse all files

126
meta/lib/oeqa/selftest/cases/debuginfod.py
View File

@@ -6,7 +6,11 @@
import os
import socketserver
import subprocess
import time
import urllib
import pathlib
from oeqa.core.decorator import OETestTag
from oeqa.selftest.case import OESelftestTestCase
from oeqa.utils.commands import bitbake, get_bb_var, runqemu
@@ -21,39 +25,54 @@ class Debuginfod(OESelftestTestCase):
Request the metrics endpoint periodically and wait for there to be no
busy scanning threads.
Returns True if debuginfod is ready, False if we timed out
Returns if debuginfod is ready, raises an exception if not within the
timeout.
"""
import time, urllib
# Wait a minute
countdown = 6
delay = 10
# Wait two minutes
countdown = 24
delay = 5
latest = None
while countdown:
self.logger.info("waiting...")
time.sleep(delay)
self.logger.info("polling server")
if self.debuginfod.poll():
self.logger.info("server dead")
self.debuginfod.communicate()
self.fail("debuginfod terminated unexpectedly")
self.logger.info("server alive")
try:
with urllib.request.urlopen("http://localhost:%d/metrics" % port) as f:
lines = f.read().decode("ascii").splitlines()
if "thread_busy{role=\"scan\"} 0" in lines:
return True
with urllib.request.urlopen("http://localhost:%d/metrics" % port, timeout=10) as f:
for line in f.read().decode("ascii").splitlines():
key, value = line.rsplit(" ", 1)
if key == "thread_busy{role=\"scan\"}":
latest = int(value)
self.logger.info("Waiting for %d scan jobs to finish" % latest)
if latest == 0:
return
except urllib.error.URLError as e:
# TODO: how to catch just timeouts?
self.logger.error(e)
countdown -= 1
return False
raise TimeoutError("Cannot connect debuginfod, still %d scan jobs running" % latest)
def test_debuginfod(self):
self.write_config(
"""
DISTRO_FEATURES:append = " debuginfod"
CORE_IMAGE_EXTRA_INSTALL += "elfutils"
"""
)
bitbake("core-image-minimal elfutils-native:do_addto_recipe_sysroot")
def start_debuginfod(self):
# We assume that the caller has already bitbake'd elfutils-native:do_addto_recipe_sysroot
# Save some useful paths for later
native_sysroot = pathlib.Path(get_bb_var("RECIPE_SYSROOT_NATIVE", "elfutils-native"))
native_bindir = native_sysroot / "usr" / "bin"
self.debuginfod = native_bindir / "debuginfod"
self.debuginfod_find = native_bindir / "debuginfod-find"
native_sysroot = get_bb_var("RECIPE_SYSROOT_NATIVE", "elfutils-native")
cmd = [
os.path.join(native_sysroot, "usr", "bin", "debuginfod"),
self.debuginfod,
"--verbose",
# In-memory database, this is a one-shot test
"--database=:memory:",
@@ -76,31 +95,64 @@ CORE_IMAGE_EXTRA_INSTALL += "elfutils"
else:
self.fail("Unknown package class %s" % format)
# Find a free port
# Find a free port. Racey but the window is small.
with socketserver.TCPServer(("localhost", 0), None) as s:
port = s.server_address[1]
cmd.append("--port=%d" % port)
self.port = s.server_address[1]
cmd.append("--port=%d" % self.port)
self.logger.info(f"Starting server {cmd}")
self.debuginfod = subprocess.Popen(cmd, env={})
self.wait_for_debuginfod(self.port)
def test_debuginfod_native(self):
"""
Test debuginfod outside of qemu, by building a package and looking up a
binary's debuginfo using elfutils-native.
"""
self.write_config("""
TMPDIR = "${TOPDIR}/tmp-debuginfod"
DISTRO_FEATURES:append = " debuginfod"
""")
bitbake("elfutils-native:do_addto_recipe_sysroot xz xz:do_package")
try:
# Remove DEBUGINFOD_URLS from the environment so we don't try
# looking in the distro debuginfod
env = os.environ.copy()
if "DEBUGINFOD_URLS" in env:
del env["DEBUGINFOD_URLS"]
self.start_debuginfod()
self.logger.info(f"Starting server {cmd}")
debuginfod = subprocess.Popen(cmd, env=env)
env = os.environ.copy()
env["DEBUGINFOD_URLS"] = "http://localhost:%d/" % self.port
pkgs = pathlib.Path(get_bb_var("PKGDEST", "xz"))
cmd = (self.debuginfod_find, "debuginfo", pkgs / "xz" / "usr" / "bin" / "xz.xz")
self.logger.info(f"Starting client {cmd}")
output = subprocess.check_output(cmd, env=env, text=True)
# This should be more comprehensive
self.assertIn("/.cache/debuginfod_client/", output)
finally:
self.debuginfod.kill()
@OETestTag("runqemu")
def test_debuginfod_qemu(self):
"""
Test debuginfod-find inside a qemu, talking to a debuginfod on the host.
"""
self.write_config("""
TMPDIR = "${TOPDIR}/tmp-debuginfod"
DISTRO_FEATURES:append = " debuginfod"
CORE_IMAGE_EXTRA_INSTALL += "elfutils xz"
""")
bitbake("core-image-minimal elfutils-native:do_addto_recipe_sysroot")
try:
self.start_debuginfod()
with runqemu("core-image-minimal", runqemuparams="nographic") as qemu:
self.assertTrue(self.wait_for_debuginfod(port))
cmd = (
"DEBUGINFOD_URLS=http://%s:%d/ debuginfod-find debuginfo /usr/bin/debuginfod"
% (qemu.server_ip, port)
)
cmd = "DEBUGINFOD_URLS=http://%s:%d/ debuginfod-find debuginfo /usr/bin/xz" % (qemu.server_ip, self.port)
self.logger.info(f"Starting client {cmd}")
status, output = qemu.run_serial(cmd)
# This should be more comprehensive
self.assertIn("/.cache/debuginfod_client/", output)
finally:
debuginfod.kill()
self.debuginfod.kill()