insane: Error for S == WORKDIR

Where a recipe uses WORKDIR as S, exit with a fatal error since the
code is no longer safe for this layout.

(From OE-Core rev: 32cba1cc916ad530c5e6630a927e74ca6f06289b)

Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
This commit is contained in:
Richard Purdie
2024-04-25 17:00:20 +01:00
parent 569f8e09f0
commit c174208db9

View File

@@ -1602,6 +1602,11 @@ python () {
if prog.search(pn):
oe.qa.handle_error("uppercase-pn", 'PN: %s is upper case, this can result in unexpected behavior.' % pn, d)
sourcedir = d.getVar("S")
workdir = d.getVar("WORKDIR")
if sourcedir == workdir:
bb.fatal("Using S = ${WORKDIR} is no longer supported")
# Some people mistakenly use DEPENDS:${PN} instead of DEPENDS and wonder
# why it doesn't work.
if (d.getVar(d.expand('DEPENDS:${PN}'))):