bitbake: runqueue: Drop deadlock breaking force fail

I'm 99% certain this failing of a scenequeue task corrupts runqueue and
causes all kinds of breakage. I'd rather runqueue deadlocked than corrupted
and did weird things so drop this code.

We've seen builds where the deadlock triggers and it then tries to run tasks
where the SQ task already ran with very confusing failures. It is likely it
is this code causing it.

(Bitbake rev: 8efced47fcb47851a370fd6786df6fb377f99963)

Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
This commit is contained in:
Richard Purdie
2022-08-05 11:25:19 +01:00
parent 645aa39512
commit c58fca98e4

View File

@@ -2240,9 +2240,6 @@ class RunQueueExecute:
deferred_tid = list(self.sq_deferred.keys())[0]
blocking_tid = self.sq_deferred.pop(deferred_tid)
logger.warning("Runqeueue deadlocked on deferred tasks, forcing task %s blocked by %s" % (deferred_tid, blocking_tid))
if blocking_tid not in self.runq_complete:
logger.warning("Failing blocking task %s" % (blocking_tid))
self.sq_task_failoutright(blocking_tid)
return True
if self.failed_tids: