mirror of
https://git.yoctoproject.org/poky
synced 2026-04-18 12:32:12 +02:00
insane: Add QA check for 32 bit time and file offset functions
Check for known symbols that should have been redirected to 64bit variants when -D_FILE_OFFSET_BITS=64 and -D_TIME_BITS=64 are set. (From OE-Core rev: 8e2af04f24443fad2040bb32e6033d49e3120517) Signed-off-by: Ola x Nilsson <olani@axis.com> Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
This commit is contained in:
Ola x Nilsson
committed by
Richard Purdie
Richard Purdie
parent
d7a10cf6f9
commit
c7b64446cb
@@ -506,6 +506,134 @@ def package_qa_check_symlink_to_sysroot(path, name, d, elf, messages):
|
||||
trimmed = path.replace(os.path.join (d.getVar("PKGDEST"), name), "")
|
||||
oe.qa.add_message(messages, "symlink-to-sysroot", "Symlink %s in %s points to TMPDIR" % (trimmed, name))
|
||||
|
||||
QAPATHTEST[32bit-time] = "check_32bit_symbols"
|
||||
def check_32bit_symbols(path, packagename, d, elf, messages):
|
||||
"""
|
||||
Check that ELF files do not use any 32 bit time APIs from glibc.
|
||||
"""
|
||||
import re
|
||||
# This list is manually constructed by searching the image folder of the
|
||||
# glibc recipe for __USE_TIME_BITS64. There is no good way to do this
|
||||
# automatically.
|
||||
api32 = {
|
||||
# /usr/include/time.h
|
||||
"clock_getres", "clock_gettime", "clock_nanosleep", "clock_settime",
|
||||
"ctime", "ctime_r", "difftime", "gmtime", "gmtime_r", "localtime",
|
||||
"localtime_r", "mktime", "nanosleep", "time", "timegm", "timelocal",
|
||||
"timer_gettime", "timer_settime", "timespec_get", "timespec_getres",
|
||||
# /usr/include/bits/time.h
|
||||
"clock_adjtime",
|
||||
# /usr/include/signal.h
|
||||
"sigtimedwait",
|
||||
# /usr/include/sys/time.h
|
||||
"futimes", "futimesat", "getitimer", "gettimeofday", "lutimes",
|
||||
"setitimer", "settimeofday", "utimes",
|
||||
# /usr/include/sys/timex.h
|
||||
"adjtimex", "ntp_adjtime", "ntp_gettime", "ntp_gettimex",
|
||||
# /usr/include/sys/wait.h
|
||||
"wait3", "wait4",
|
||||
# /usr/include/sys/stat.h
|
||||
"fstat", "fstat64", "fstatat", "fstatat64", "futimens", "lstat",
|
||||
"lstat64", "stat", "stat64", "utimensat",
|
||||
# /usr/include/sys/poll.h
|
||||
"ppoll",
|
||||
# /usr/include/sys/resource.h
|
||||
"getrusage",
|
||||
# /usr/include/sys/ioctl.h
|
||||
"ioctl",
|
||||
# /usr/include/sys/select.h
|
||||
"select", "pselect",
|
||||
# /usr/include/sys/prctl.h
|
||||
"prctl",
|
||||
# /usr/include/sys/epoll.h
|
||||
"epoll_pwait2",
|
||||
# /usr/include/sys/timerfd.h
|
||||
"timerfd_gettime", "timerfd_settime",
|
||||
# /usr/include/sys/socket.h
|
||||
"getsockopt", "recvmmsg", "recvmsg", "sendmmsg", "sendmsg",
|
||||
"setsockopt",
|
||||
# /usr/include/sys/msg.h
|
||||
"msgctl",
|
||||
# /usr/include/sys/sem.h
|
||||
"semctl", "semtimedop",
|
||||
# /usr/include/sys/shm.h
|
||||
"shmctl",
|
||||
# /usr/include/pthread.h
|
||||
"pthread_clockjoin_np", "pthread_cond_clockwait",
|
||||
"pthread_cond_timedwait", "pthread_mutex_clocklock",
|
||||
"pthread_mutex_timedlock", "pthread_rwlock_clockrdlock",
|
||||
"pthread_rwlock_clockwrlock", "pthread_rwlock_timedrdlock",
|
||||
"pthread_rwlock_timedwrlock", "pthread_timedjoin_np",
|
||||
# /usr/include/semaphore.h
|
||||
"sem_clockwait", "sem_timedwait",
|
||||
# /usr/include/threads.h
|
||||
"cnd_timedwait", "mtx_timedlock", "thrd_sleep",
|
||||
# /usr/include/aio.h
|
||||
"aio_cancel", "aio_error", "aio_read", "aio_return", "aio_suspend",
|
||||
"aio_write", "lio_listio",
|
||||
# /usr/include/mqueue.h
|
||||
"mq_timedreceive", "mq_timedsend",
|
||||
# /usr/include/glob.h
|
||||
"glob", "glob64", "globfree", "globfree64",
|
||||
# /usr/include/sched.h
|
||||
"sched_rr_get_interval",
|
||||
# /usr/include/fcntl.h
|
||||
"fcntl", "fcntl64",
|
||||
# /usr/include/utime.h
|
||||
"utime",
|
||||
# /usr/include/ftw.h
|
||||
"ftw", "ftw64", "nftw", "nftw64",
|
||||
# /usr/include/fts.h
|
||||
"fts64_children", "fts64_close", "fts64_open", "fts64_read",
|
||||
"fts64_set", "fts_children", "fts_close", "fts_open", "fts_read",
|
||||
"fts_set",
|
||||
# /usr/include/netdb.h
|
||||
"gai_suspend",
|
||||
}
|
||||
|
||||
ptrn = re.compile(
|
||||
r'''
|
||||
(?P<value>[\da-fA-F]+) \s+
|
||||
(?P<flags>[lgu! ][w ][C ][W ][Ii ][dD ]F) \s+
|
||||
(?P<section>\*UND\*) \s+
|
||||
(?P<alignment>(?P<size>[\da-fA-F]+)) \s+
|
||||
(?P<symbol>
|
||||
''' +
|
||||
r'(?P<notag>' + r'|'.join(sorted(api32)) + r')' +
|
||||
r'''
|
||||
(@+(?P<tag>GLIBC_\d+\.\d+\S*)))
|
||||
''', re.VERBOSE
|
||||
)
|
||||
|
||||
# elf is a oe.qa.ELFFile object
|
||||
if elf is not None:
|
||||
phdrs = elf.run_objdump("-tw", d)
|
||||
syms = re.finditer(ptrn, phdrs)
|
||||
usedapis = {sym.group('notag') for sym in syms}
|
||||
if usedapis:
|
||||
elfpath = package_qa_clean_path(path, d, packagename)
|
||||
# Remove any .debug dir, heuristic that probably works
|
||||
# At this point, any symbol information is stripped into the debug
|
||||
# package, so that is the only place we will find them.
|
||||
elfpath = elfpath.replace('.debug/', '')
|
||||
allowed = (
|
||||
d.getVarFlag(
|
||||
'INSANE_SKIP:' + d.getVar('PN'), elfpath.replace('/', '_')
|
||||
) or ''
|
||||
).split()
|
||||
usedapis -= set(allowed)
|
||||
if usedapis:
|
||||
msgformat = elfpath + " uses 32-bit api '%s'"
|
||||
for sym in usedapis:
|
||||
oe.qa.add_message(messages, '32bit-time', msgformat % sym)
|
||||
oe.qa.add_message(
|
||||
messages, '32bit-time',
|
||||
'Suppress with INSANE_SKIP:%s[%s] = "%s"' % (
|
||||
d.getVar('PN'), elfpath.replace('/', '_'),
|
||||
' '.join(usedapis)
|
||||
)
|
||||
)
|
||||
|
||||
# Check license variables
|
||||
do_populate_lic[postfuncs] += "populate_lic_qa_checksum"
|
||||
python populate_lic_qa_checksum() {
|
||||
|
||||
Reference in New Issue
Block a user