mirror of
https://git.yoctoproject.org/poky
synced 2026-04-26 09:32:14 +02:00
testsdk: fix skipped testcase output "UNKNOWN" status while multiprocess execution
Usually skipped testcase output "SKIPPED" [snip serial execution] |RESULTS - buildgalculator.GalculatorTest.test_galculator - Testcase -1: SKIPPED (0.01s) |RESULTS - python.PythonTest.test_python3 - Testcase -1: SKIPPED (0.01s) [snip serial execution] But if enable multiprocess execution, skipped testcase output "UNKNOWN" status [snip enable multiprocess execution] |RESULTS - buildgalculator.GalculatorTest.test_galculator - Testcase -1: UNKNOWN |RESULTS - python.PythonTest.test_python3 - Testcase -1: UNKNOWN [snip enable multiprocess execution] Here is my investigation: There is a class pairs TestProtocolClient and TestProtocolServer provided by python3-subunit. The TestProtocolClient generates a subunit stream of TestResult from a test run, and TestProtocolServer parses the stream of subunit TestResult. The class ProtocolTestCase is a unittest.TestCase adapter and it uses TestProtocolServer to parse the stream of subunit TestResult. In Yocto testsdk, it forks multiple processes to execute testcases and use TestProtocolClient to generate TestResult stream; and then it creates multiple threads to use ProtocolTestCase to parse stream of subunit TestResult through pipe; finally it passes multiple ProtocolTestCase as TestCase instance to main process and output status result. The problem point is TestProtocolServer parses `skip:' directive after reading a `test:' directive. Without `test:' directive, `skip:' directive will be ignored. All above requires SkipTest should be raised inside a test method rather than setUpClass method. Throwing SkipTest inside setUp works correctly (From OE-Core rev: 4828a88556d59e4d06933164c2ebeb9361b7450e) Signed-off-by: Hongxu Jia <hongxu.jia@windriver.com> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
This commit is contained in:
committed by
Richard Purdie
parent
6b7227b68a
commit
d40767ac83
@@ -12,8 +12,7 @@ class BuildAssimp(OESDKTestCase):
|
||||
|
||||
td_vars = ['DATETIME', 'TARGET_OS', 'TARGET_ARCH']
|
||||
|
||||
@classmethod
|
||||
def setUpClass(self):
|
||||
def setUp(self):
|
||||
if not (self.tc.hasHostPackage("nativesdk-cmake") or
|
||||
self.tc.hasHostPackage("cmake-native")):
|
||||
raise unittest.SkipTest("Needs cmake")
|
||||
|
||||
@@ -14,6 +14,7 @@ class BuildCpioTest(OESDKTestCase):
|
||||
self.tc.sdk_dir, self.td['DATETIME'], dl_dir=dl_dir)
|
||||
self.project.download_archive()
|
||||
|
||||
def setUp(self):
|
||||
machine = self.td.get("MACHINE")
|
||||
if not self.tc.hasHostPackage("packagegroup-cross-canadian-%s" % machine):
|
||||
raise unittest.SkipTest("SDK doesn't contain a cross-canadian toolchain")
|
||||
|
||||
@@ -6,8 +6,7 @@ from oeqa.sdk.utils.sdkbuildproject import SDKBuildProject
|
||||
class GalculatorTest(OESDKTestCase):
|
||||
td_vars = ['DATETIME']
|
||||
|
||||
@classmethod
|
||||
def setUpClass(self):
|
||||
def setUp(self):
|
||||
if not (self.tc.hasTargetPackage("gtk+3", multilib=True) or \
|
||||
self.tc.hasTargetPackage("libgtk-3.0", multilib=True)):
|
||||
raise unittest.SkipTest("GalculatorTest class: SDK don't support gtk+3")
|
||||
|
||||
@@ -15,6 +15,7 @@ class BuildLzipTest(OESDKTestCase):
|
||||
self.tc.sdk_dir, self.td['DATETIME'], dl_dir=dl_dir)
|
||||
self.project.download_archive()
|
||||
|
||||
def setUp(self):
|
||||
machine = self.td.get("MACHINE")
|
||||
|
||||
if not (self.tc.hasHostPackage("packagegroup-cross-canadian-%s" % machine) or
|
||||
|
||||
@@ -2,8 +2,7 @@ import unittest
|
||||
from oeqa.sdk.case import OESDKTestCase
|
||||
|
||||
class PerlTest(OESDKTestCase):
|
||||
@classmethod
|
||||
def setUpClass(self):
|
||||
def setUp(self):
|
||||
if not (self.tc.hasHostPackage("nativesdk-perl") or
|
||||
self.tc.hasHostPackage("perl-native")):
|
||||
raise unittest.SkipTest("No perl package in the SDK")
|
||||
|
||||
@@ -2,8 +2,7 @@ import subprocess, unittest
|
||||
from oeqa.sdk.case import OESDKTestCase
|
||||
|
||||
class PythonTest(OESDKTestCase):
|
||||
@classmethod
|
||||
def setUpClass(self):
|
||||
def setUp(self):
|
||||
if not (self.tc.hasHostPackage("nativesdk-python3") or
|
||||
self.tc.hasHostPackage("python3-native")):
|
||||
raise unittest.SkipTest("No python package in the SDK")
|
||||
|
||||
Reference in New Issue
Block a user