mirrors/poky
1
0
Fork 0
mirror of https://git.yoctoproject.org/poky synced 2026-02-09 02:03:04 +01:00
Code Issues Packages Projects Releases Wiki Activity

bash: memleak bug fix for builtin command read

Browse Source 
Built in command "read" with "-e" use Readline to obtain the line
in an interactive shell. In this process, a string "rlbuf" is
just allocated without free operation thus cause memory leak.

This patch had been submitted to upstream:
http://lists.gnu.org/archive/html/bug-bash/2017-02/msg00061.html

(From OE-Core rev: a2b278a6eaa9e9b48d858e3be6712267c0122598)

Signed-off-by: Zhang Xiao <xiao.zhang@windriver.com>
Signed-off-by: Yi Zhao <yi.zhao@windriver.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
This commit is contained in:
Zhang Xiao
2017-08-25 08:42:38 +08:00
committed by Richard Purdie
parent 2f84fb232f
commit e4881a3d22
2 changed files with 36 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

35
meta/recipes-extended/bash/bash/bash-memleak-bug-fix-for-builtin-command-read.patch Normal file
View File

@@ -0,0 +1,35 @@
From d3b6303a6853f612a56848ee4e59eaa0b0ab9489 Mon Sep 17 00:00:00 2001
From: Zhang Xiao <xiao.zhang@windriver.com>
Date: Tue, 21 Feb 2017 11:30:14 +0800
Subject: [PATCH] bash: memleak bug fix for builtin command read
Built in command "read" with "-e" use Readline to obtain the line
in an interactive shell. In this process, a string "rlbuf" is
just allocated without free operation thus cause memory leak. Fix it.
Upstream-Status: Submitted [http://lists.gnu.org/archive/html/bug-bash/2017-02/msg00061.html]
Signed-off-by: Zhang Xiao <xiao.zhang@windriver.com>
---
builtins/read.def | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/builtins/read.def b/builtins/read.def
index 4397154..ee0c5a6 100644
--- a/builtins/read.def
+++ b/builtins/read.def
@@ -674,6 +674,11 @@ add_char:
input_string[i] = '\0';
CHECK_ALRM;
+#if defined (READLINE)
+ if (edit)
+ xfree (rlbuf);
+#endif
+
if (retval < 0)
{
t_errno = errno;
--
1.9.1

1
meta/recipes-extended/bash/bash_4.4.bb
View File

@@ -25,6 +25,7 @@ SRC_URI = "${GNU_MIRROR}/bash/${BP}.tar.gz;name=tarball \
file://run-ptest \
file://fix-run-builtins.patch \
file://0001-help-fix-printf-format-security-warning.patch \
file://bash-memleak-bug-fix-for-builtin-command-read.patch \
"
SRC_URI[tarball.md5sum] = "148888a7c95ac23705559b6f477dfe25"