mirrors/poky
1
0
Fork 0
mirror of https://git.yoctoproject.org/poky synced 2026-07-01 23:13:38 +02:00
Code Issues Packages Projects Releases Wiki Activity

bitbake: fetch2/wget: limit auth on checkstatus redirects

Browse Source 
FixedHTTPRedirectHandler copies request headers when checkstatus()
follows a redirect, including Authorization from SRC_URI or .netrc.

Keep same-origin redirects unchanged, but drop Authorization and Cookie
for different-origin targets (scheme, host and effective port), following
RFC 9110 redirect guidance for resource-specific headers. This only
affects the Python checkstatus() path; normal wget downloads are
unchanged.

(Bitbake rev: 348edecf9e663c3b432c6cf76c3f911354e83487)

Signed-off-by: Anders Heimer <anders.heimer@est.tech>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
(cherry picked from commit 1019d5a5c42c672ea673ae9d22363d626b57ccb9)
Signed-off-by: Jeremy Rosen <jeremy.rosen@smile.fr>
Signed-off-by: Paul Barker <paul@pbarker.dev>
This commit is contained in:
Anders Heimer
2026-06-10 09:40:12 +02:00
committed by Paul Barker
parent ad26b871a3
commit e534446f94
1 changed files with 25 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

27
bitbake/lib/bb/fetch2/wget.py
View File

@@ -303,6 +303,18 @@ class Wget(FetchMethod):
http_error_403 = http_error_405
def _url_origin(url):
parsed = urllib.parse.urlsplit(url)
scheme = parsed.scheme.lower()
host = parsed.hostname.lower() if parsed.hostname else ""
port = parsed.port
if port is None:
port = {"http": 80, "https": 443}.get(scheme)
return (scheme, host, port)
def _same_origin(url_a, url_b):
return _url_origin(url_a) == _url_origin(url_b)
class FixedHTTPRedirectHandler(urllib.request.HTTPRedirectHandler):
"""
urllib2.HTTPRedirectHandler before 3.13 has two flaws:
@@ -316,6 +328,9 @@ class Wget(FetchMethod):
Until we depend on Python 3.13 onwards, copy the redirect_request
method to fix these issues.
Additionally, strip sensitive headers (Authorization, Cookie) when
redirecting to a different origin to avoid credential leaks.
"""
def redirect_request(self, req, fp, code, msg, headers, newurl):
m = req.get_method()
@@ -335,8 +350,16 @@ class Wget(FetchMethod):
newurl = newurl.replace(' ', '%20')
CONTENT_HEADERS = ("content-length", "content-type")
newheaders = {k: v for k, v in req.headers.items()
if k.lower() not in CONTENT_HEADERS}
SENSITIVE_REDIRECT_HEADERS = ("authorization", "cookie")
same_origin = _same_origin(req.get_full_url(), newurl)
newheaders = {}
for k, v in req.headers.items():
header = k.lower()
if header in CONTENT_HEADERS:
continue
if not same_origin and header in SENSITIVE_REDIRECT_HEADERS:
continue
newheaders[k] = v
return urllib.request.Request(newurl,
method="HEAD" if m == "HEAD" else "GET",
headers=newheaders,